)]}'
{"ceilometer/dispatcher/http.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.BoolOpt(\u0027batch_mode\u0027,"},{"line_number":46,"context_line":"                default\u003dFalse,"},{"line_number":47,"context_line":"                help\u003d\u0027Indicates whether samples are\u0027"},{"line_number":48,"context_line":"                     \u0027 published in a batch.\u0027),"},{"line_number":49,"context_line":"]"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"cfg.CONF.register_opts(http_dispatcher_opts, group\u003d\"dispatcher_http\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_5e93884f","line":48,"updated":"2016-09-28 12:36:56.000000000","message":"this probably can fit in one line.","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not isinstance(events, list):"},{"line_number":145,"context_line":"            events \u003d [events]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if self.batch_mode:"},{"line_number":148,"context_line":"            self.post_event(events)"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            for event in events:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_5f348fdd","line":147,"updated":"2016-09-28 12:36:56.000000000","message":"i feel like we could avoid this if condition every single time. maybe in __init__ add:\n\n  post_data \u003d post_event if batch_mode else lambda x: post_event(i) for i in x)\n\nsomething, like that (i still need my coffee). might want to hold off on this suggestion until further reviews.lol","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"},{"author":{"_account_id":14768,"name":"Darren Hague","email":"d.hague@sap.com","username":"dhague"},"change_message_id":"ae45cc8e7276b003b30613b46836f9a90c6c8cb0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        if not isinstance(events, list):"},{"line_number":145,"context_line":"            events \u003d [events]"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"        if self.batch_mode:"},{"line_number":148,"context_line":"            self.post_event(events)"},{"line_number":149,"context_line":"        else:"},{"line_number":150,"context_line":"            for event in events:"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_6b37fb4c","line":147,"in_reply_to":"3a98d1f4_5f348fdd","updated":"2016-10-03 15:14:26.000000000","message":"That would be neat, but \u0027for\u0027 statements aren\u0027t allowed in lambda expressions. I\u0027ve applied the principle in the next patchset though.","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        res \u003d None"},{"line_number":155,"context_line":"        try:"},{"line_number":156,"context_line":"            event_json \u003d json.dumps(event)"},{"line_number":157,"context_line":"            LOG.trace(\u0027Event Message: %s \u0027, event_json)"},{"line_number":158,"context_line":"            res \u003d requests.post(self.event_target,"},{"line_number":159,"context_line":"                                data\u003devent_json,"},{"line_number":160,"context_line":"                                headers\u003dself.headers,"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a8bc5a2_def4f888","line":157,"range":{"start_line":157,"start_character":40,"end_line":157,"end_character":41},"updated":"2016-09-28 12:36:56.000000000","message":"not needed whitespace","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"}],"ceilometer/tests/unit/dispatcher/test_http.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        with mock.patch.object(requests, \u0027post\u0027) as post:"},{"line_number":118,"context_line":"            dispatcher.record_metering_data([self.msg, self.msg])"},{"line_number":119,"context_line":"            self.assertEqual(2, post.call_count)"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        self.assertEqual(\u0027/path/to/cert.crt\u0027, post.call_args[1][\u0027verify\u0027])"},{"line_number":122,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_fcec8991","line":119,"updated":"2016-09-28 12:36:56.000000000","message":"tbh, i\u0027d prefer you have a new test rather than piggyback on this one","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":199,"context_line":""},{"line_number":200,"context_line":"        with mock.patch.object(requests, \u0027post\u0027) as post:"},{"line_number":201,"context_line":"            dispatcher.record_events([self.event, self.event])"},{"line_number":202,"context_line":"            self.assertEqual(2, post.call_count)"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"        self.assertEqual(\u0027/path/to/cert.crt\u0027, post.call_args[1][\u0027verify\u0027])"},{"line_number":205,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_1c02153f","line":202,"updated":"2016-09-28 12:36:56.000000000","message":"same as above","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    def test_http_dispatcher_batch_event(self):"},{"line_number":207,"context_line":"        self.CONF.dispatcher_http.event_target \u003d \u0027fake\u0027"},{"line_number":208,"context_line":"        self.CONF.dispatcher_http.batch_mode \u003d True"},{"line_number":209,"context_line":"        self.CONF.dispatcher_http.batch_count \u003d 1"},{"line_number":210,"context_line":"        self.CONF.dispatcher_http.batch_polling_interval \u003d 1"},{"line_number":211,"context_line":"        self.CONF.dispatcher_http.batch_polling_timeout \u003d 1"},{"line_number":212,"context_line":"        dispatcher \u003d http.HttpDispatcher(self.CONF)"},{"line_number":213,"context_line":""},{"line_number":214,"context_line":"        event \u003d event_models.Event(repr(uuid.uuid4()), \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a98d1f4_dc98ad6d","line":211,"range":{"start_line":209,"start_character":0,"end_line":211,"end_character":59},"updated":"2016-09-28 12:36:56.000000000","message":"not valid options","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"}],"tox.ini":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"bcc8a500c73386a02283b36ceefde49885246be2","unresolved":false,"context_lines":[{"line_number":82,"context_line":"[testenv:pep8]"},{"line_number":83,"context_line":"deps \u003d hacking\u003c0.12,\u003e\u003d0.11.0"},{"line_number":84,"context_line":"commands \u003d"},{"line_number":85,"context_line":"    flake8 --exclude\u003dpycharm-debug,doc/source/conf.py,install-guide/source/conf.py"},{"line_number":86,"context_line":"    # Check that .po and .pot files are valid:"},{"line_number":87,"context_line":"    bash -c \"find ceilometer -type f -regex \u0027.*\\.pot?\u0027 -print0|xargs -0 -n 1 msgfmt --check-format -o /dev/null\""},{"line_number":88,"context_line":""}],"source_content_type":"text/x-properties","patch_set":4,"id":"5a8bc5a2_9e13500d","line":85,"updated":"2016-09-28 12:36:56.000000000","message":"whats this for? seems completely unrelated to your patch","commit_id":"767dfc3507e550946cc6d6974e19edf0058f0756"}]}