)]}'
{"ceilometer/plugin.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"584ad5e92ba5202b7893beed7a1dbca0581ea17c","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                       event_type_to_handle))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def to_samples(self, notification):"},{"line_number":83,"context_line":"        \"\"\"Return samples produced by*process_notification* for the given"},{"line_number":84,"context_line":"        notification, if it\u0027s handled by this notification handler."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param notification: The notification to process."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2Ftuk%3D","line":83,"updated":"2013-07-24 15:42:57.000000000","message":"space missing before process","commit_id":"5177d5d8707a484c784d5789d93145c4398994f9"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"b6b3d852bb058b2159ed7d5676864a6718f2df12","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                       event_type_to_handle))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def to_samples(self, notification):"},{"line_number":83,"context_line":"        \"\"\"Return samples produced by*process_notification* for the given"},{"line_number":84,"context_line":"        notification, if it\u0027s handled by this notification handler."},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        :param notification: The notification to process."}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAQn%2F%2FtiQ%3D","line":83,"in_reply_to":"AAAAQn%2F%2Ftuk%3D","updated":"2013-07-24 16:20:12.000000000","message":"Done","commit_id":"5177d5d8707a484c784d5789d93145c4398994f9"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"4903236276c5898d19c76527bb6a2c5a8f7ea276","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return any(map(lambda e: fnmatch.fnmatch(event_type, e),"},{"line_number":80,"context_line":"                       event_type_to_handle))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def to_samples(self, notification):"},{"line_number":83,"context_line":"        \"\"\"Return samples produced by *process_notification* for the given"},{"line_number":84,"context_line":"        notification, if it\u0027s handled by this notification handler."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fs3A%3D","line":82,"updated":"2013-07-24 19:45:24.000000000","message":"This method is always treated as returning an iterable, but if the plugin does not handle the event type the method returns None, which causes an exception when the return value is passed to list().\n\nIt would be good to add some test cases with simple plugins and exercise to_samples() to add to the tests you have for _handle_event_type().","commit_id":"0f48c52195cad8a2c30645ed0dee617ba7ae5127"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0b4a1ec1740d3c6f8d0fd4a59a61197434ec3100","unresolved":false,"context_lines":[{"line_number":79,"context_line":"        return any(map(lambda e: fnmatch.fnmatch(event_type, e),"},{"line_number":80,"context_line":"                       event_type_to_handle))"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def to_samples(self, notification):"},{"line_number":83,"context_line":"        \"\"\"Return samples produced by *process_notification* for the given"},{"line_number":84,"context_line":"        notification, if it\u0027s handled by this notification handler."},{"line_number":85,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2Fq8E%3D","line":82,"in_reply_to":"AAAAQn%2F%2Fs3A%3D","updated":"2013-07-25 12:14:06.000000000","message":"Done","commit_id":"0f48c52195cad8a2c30645ed0dee617ba7ae5127"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"29688932e7ca1375b8342b83dbdd059fa44aa930","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if self._handle_event_type(notification[\u0027event_type\u0027],"},{"line_number":90,"context_line":"                                   self.event_types):"},{"line_number":91,"context_line":"            return self.process_notification(notification)"},{"line_number":92,"context_line":"        return iter(())"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class PollsterBase(PluginBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FWO4%3D","line":92,"updated":"2013-08-01 16:45:58.000000000","message":"You could also just return an empty list.","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"862ff20c5ae47e346f8c8f852ee278bb0edc4b70","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if self._handle_event_type(notification[\u0027event_type\u0027],"},{"line_number":90,"context_line":"                                   self.event_types):"},{"line_number":91,"context_line":"            return self.process_notification(notification)"},{"line_number":92,"context_line":"        return iter(())"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"class PollsterBase(PluginBase):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FOHQ%3D","line":92,"in_reply_to":"AAAAQn%2F%2FWO4%3D","updated":"2013-08-05 09:29:29.000000000","message":"Done","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"}],"ceilometer/volume/notifications.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"29688932e7ca1375b8342b83dbdd059fa44aa930","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    event_types \u003d ["},{"line_number":42,"context_line":"        \u0027volume.exists\u0027,"},{"line_number":43,"context_line":"        \u0027volume.create.end\u0027,"},{"line_number":44,"context_line":"        \u0027volume.delete.start\u0027,"},{"line_number":45,"context_line":"    ]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FWPI%3D","line":43,"updated":"2013-08-01 16:45:58.000000000","message":"We can wildcard these, too, right?","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"862ff20c5ae47e346f8c8f852ee278bb0edc4b70","unresolved":false,"context_lines":[{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    event_types \u003d ["},{"line_number":42,"context_line":"        \u0027volume.exists\u0027,"},{"line_number":43,"context_line":"        \u0027volume.create.end\u0027,"},{"line_number":44,"context_line":"        \u0027volume.delete.start\u0027,"},{"line_number":45,"context_line":"    ]"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FOHM%3D","line":43,"in_reply_to":"AAAAQn%2F%2FWPI%3D","updated":"2013-08-05 09:29:29.000000000","message":"Done","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"}],"tests/network/test_notifications.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9359f9e0417c6cfdf73d9e0b0fd71211878e2fb9","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def test_network(self):"},{"line_number":251,"context_line":"        v \u003d notifications.Network()"},{"line_number":252,"context_line":"        events \u003d v.event_types"},{"line_number":253,"context_line":"        assert events"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_subnet(self):"},{"line_number":256,"context_line":"        v \u003d notifications.Subnet()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FX%2BU%3D","line":253,"updated":"2013-08-01 07:03:32.000000000","message":"Why changing only two old assert on TestEventTypes ?","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"9c34deeb3990f625f2c7608efa90d9e8881ee3d5","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def test_network(self):"},{"line_number":251,"context_line":"        v \u003d notifications.Network()"},{"line_number":252,"context_line":"        events \u003d v.event_types"},{"line_number":253,"context_line":"        assert events"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_subnet(self):"},{"line_number":256,"context_line":"        v \u003d notifications.Subnet()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FX3Y%3D","line":253,"in_reply_to":"AAAAQn%2F%2FX%2BU%3D","updated":"2013-08-01 07:59:26.000000000","message":"I don\u0027t get your question. :(","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c07557c129829b03633d354a891bb309c8ab726d","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def test_network(self):"},{"line_number":251,"context_line":"        v \u003d notifications.Network()"},{"line_number":252,"context_line":"        events \u003d v.event_types"},{"line_number":253,"context_line":"        assert events"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_subnet(self):"},{"line_number":256,"context_line":"        v \u003d notifications.Subnet()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FXuo%3D","line":253,"in_reply_to":"AAAAQn%2F%2FX3Y%3D","updated":"2013-08-01 08:52:05.000000000","message":"Just that some \u0027assert\u0027 has been changed to \u0027self.assertTrue\u0027 but not all. But it is not really important.","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"4de6479c18d5a95eb9388dcdcc56660a5937c795","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    def test_network(self):"},{"line_number":251,"context_line":"        v \u003d notifications.Network()"},{"line_number":252,"context_line":"        events \u003d v.event_types"},{"line_number":253,"context_line":"        assert events"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"    def test_subnet(self):"},{"line_number":256,"context_line":"        v \u003d notifications.Subnet()"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2FXmY%3D","line":253,"in_reply_to":"AAAAQn%2F%2FXuo%3D","updated":"2013-08-01 09:25:07.000000000","message":"Ah :) I only changes the line if I have to touch them. I avoid rewriting code just for pleasure, since it pollutes history and tools like git blame for low gain.","commit_id":"2dd3fb46c1c1c6147ddc3fd4946534869380802d"}]}