)]}'
{"ceilometer/collector.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9f1a24b47f5b79797674decb4c62d31538d1ce90","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            address_family \u003d socket.AF_INET6"},{"line_number":108,"context_line":"        udp \u003d socket.socket(address_family, socket.SOCK_DGRAM)"},{"line_number":109,"context_line":"        udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)"},{"line_number":110,"context_line":"        udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)"},{"line_number":111,"context_line":"        udp.bind((cfg.CONF.collector.udp_address,"},{"line_number":112,"context_line":"                  cfg.CONF.collector.udp_port))"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_11671e26","line":110,"updated":"2016-10-12 07:03:45.000000000","message":"This is a nice addition, but not all platforms support this, you need linux and kernel \u003e\u003d 3.9 so perhaps we should add a try/except around to ensure it doesn\u0027t fail.","commit_id":"f13759d273c9df2330698b38d3c1f3c067e33720"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"77482a378702701dbe14750d3a6fb8c5a70b48ac","unresolved":false,"context_lines":[{"line_number":107,"context_line":"            address_family \u003d socket.AF_INET6"},{"line_number":108,"context_line":"        udp \u003d socket.socket(address_family, socket.SOCK_DGRAM)"},{"line_number":109,"context_line":"        udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)"},{"line_number":110,"context_line":"        udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)"},{"line_number":111,"context_line":"        udp.bind((cfg.CONF.collector.udp_address,"},{"line_number":112,"context_line":"                  cfg.CONF.collector.udp_port))"},{"line_number":113,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa6399be_9c47c51c","line":110,"in_reply_to":"fa6399be_11671e26","updated":"2016-10-12 07:15:56.000000000","message":"Forget my comment FreeBSD \u003e\u003d 5 OSX \u003e\u003d 10.3 have the option too, rhel7 have kernel 3.10, ubuntu xenial have 4.4, we are good I think !","commit_id":"f13759d273c9df2330698b38d3c1f3c067e33720"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"bdda8958b550e276671fc6c39d7e3d4885456070","unresolved":false,"context_lines":[{"line_number":111,"context_line":"            # NOTE(zhengwei): linux kernel \u003e\u003d 3.9"},{"line_number":112,"context_line":"            udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)"},{"line_number":113,"context_line":"        except Exception:"},{"line_number":114,"context_line":"            LOG.warning(_(\"Kernel dosn\u0027t support socket.SO_REUSEPORT option\"))"},{"line_number":115,"context_line":"        udp.bind((cfg.CONF.collector.udp_address,"},{"line_number":116,"context_line":"                  cfg.CONF.collector.udp_port))"},{"line_number":117,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"fa6399be_5f9d1c58","line":114,"updated":"2016-10-12 09:07:58.000000000","message":"I think you need _LW not _ though I\u0027m no expert.\n\nIt\u0027d be good to give a better explicit message something like:\n\n\"Your system does not support socket.SO_REUSEPORT option. Only one worker will be able to process incoming data.\"","commit_id":"e0afafedb7631e1242723baa4386bc6c5aab7ea3"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"16255b66b6541433ec5e97219329bb979a0116ea","unresolved":false,"context_lines":[{"line_number":112,"context_line":"            # NOTE(zhengwei): linux kernel \u003e\u003d 3.9"},{"line_number":113,"context_line":"            udp.setsockopt(socket.SOL_SOCKET, socket.SO_REUSEPORT, 1)"},{"line_number":114,"context_line":"        except Exception:"},{"line_number":115,"context_line":"            LOG.warning(_LW(\"Kernel does not support socket.SO_REUSEPORT\""},{"line_number":116,"context_line":"                            \"option. Only one worker will be able to process\""},{"line_number":117,"context_line":"                            \"incoming data.\"))"},{"line_number":118,"context_line":"        udp.bind((cfg.CONF.collector.udp_address,"}],"source_content_type":"text/x-python","patch_set":5,"id":"fa6399be_bd852eae","line":115,"updated":"2016-10-13 08:46:08.000000000","message":"you miss spaces at the end of the line before \"","commit_id":"a30a753799a1696ce82958e965151ca271b91484"}],"ceilometer/tests/functional/test_collector.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"838b0cfd5a36ed847def40bfe12465c56591e315","unresolved":false,"context_lines":[{"line_number":15,"context_line":"import socket"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import mock"},{"line_number":18,"context_line":"from mock import call"},{"line_number":19,"context_line":"import msgpack"},{"line_number":20,"context_line":"from oslo_config import fixture as fixture_config"},{"line_number":21,"context_line":"import oslo_messaging"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa6399be_fea41da7","line":18,"updated":"2016-10-12 16:15:50.000000000","message":"you probably don\u0027t need to import this and can just use mock.call","commit_id":"b50220a6d27421fcd0a2eb61a20d2364932a0618"}]}