)]}'
{"ceilometer/storage/impl_mongodb.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f91bfc6bbd0db46f71d41221f22da4e3891b18d5","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def __init__(self, conf):"},{"line_number":248,"context_line":"        url \u003d conf.database.connection"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if url \u003d\u003d \u0027mongodb://__test__\u0027:"},{"line_number":251,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_MONGODB_URL\u0027)"},{"line_number":252,"context_line":"            if not url:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fm3U%3D","line":249,"updated":"2013-07-26 16:32:02.000000000","message":"this question might not be for you Alexei but is this ever used after this change? do we need it?","commit_id":"e8cab3bce7d685dbd35e03a5003b522e2196f939"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a6856ea3bd0442d1cb50d3b9888c21c5eb1381d0","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def __init__(self, conf):"},{"line_number":248,"context_line":"        url \u003d conf.database.connection"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if url \u003d\u003d \u0027mongodb://__test__\u0027:"},{"line_number":251,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_MONGODB_URL\u0027)"},{"line_number":252,"context_line":"            if not url:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fjsw%3D","line":249,"in_reply_to":"AAAAQn%2F%2Fjt0%3D","updated":"2013-07-29 08:42:34.000000000","message":"I totally misread the code so forgot what I wrote. This is the Good Way to do it.\n\nAgreed that the __test__ handling is useless.","commit_id":"e8cab3bce7d685dbd35e03a5003b522e2196f939"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2357fe9702dba77141f82a5b7e6940dab0a75e4d","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def __init__(self, conf):"},{"line_number":248,"context_line":"        url \u003d conf.database.connection"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"        if url \u003d\u003d \u0027mongodb://__test__\u0027:"},{"line_number":251,"context_line":"            url \u003d os.environ.get(\u0027CEILOMETER_TEST_MONGODB_URL\u0027)"},{"line_number":252,"context_line":"            if not url:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fjt0%3D","line":249,"in_reply_to":"AAAAQn%2F%2Fm3U%3D","updated":"2013-07-29 08:32:38.000000000","message":"No it wouldn\u0027t be indeed.\n\nI like the idea but not the implementation. Basically I prefer we keep the __test__ scheme for now. We used to have subclasses of the main drivers to run tests, but we got bitten because things were often overloaded for bad reason and hid bugs.\n\n+ there\u0027 no reason to hard code localhost:29000, using the environment variable is much better; just make the database suffixed in the code below with an uuid.","commit_id":"e8cab3bce7d685dbd35e03a5003b522e2196f939"}],"ceilometer/tests/db.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a6856ea3bd0442d1cb50d3b9888c21c5eb1381d0","unresolved":false,"context_lines":[{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class MongoDBFakeConnectionUrl(object):"},{"line_number":47,"context_line":"    def __str__(self):"},{"line_number":48,"context_line":"        return \u0027mongodb://localhost:29000/ceilometer_%s\u0027 % uuid.uuid4().hex"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"class MixinTestsWithBackendScenarios(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fjss%3D","line":48,"updated":"2013-07-29 08:42:34.000000000","message":"Use the env var :)","commit_id":"e8cab3bce7d685dbd35e03a5003b522e2196f939"}],"tests/storage/test_impl_mongodb.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f91bfc6bbd0db46f71d41221f22da4e3891b18d5","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                         impl_mongodb.Connection(cfg.CONF).conn)"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"    def test_replica_set(self):"},{"line_number":52,"context_line":"        # FIXME(Alexei_987) should not hardcode URL here"},{"line_number":53,"context_line":"        cfg.CONF.set_override("},{"line_number":54,"context_line":"            \u0027connection\u0027,"},{"line_number":55,"context_line":"            \u0027mongodb://localhost:29000/ceilometer?replicaSet\u003dfoobar\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQn%2F%2Fm3g%3D","line":52,"updated":"2013-07-26 16:32:02.000000000","message":"we can address this FIXME here right?","commit_id":"e8cab3bce7d685dbd35e03a5003b522e2196f939"}]}