)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"47863723d092981b418dedb1dc4fcbcf99aa188a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Remove source as a publisher argument"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We used to have source as a publisher argument, but this anyway ends being"},{"line_number":10,"context_line":"included in its Sample itself. So rather than complicating the internal"},{"line_number":11,"context_line":"publishing API, simplify it and just include source as a Sample field."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAQn%2F%2FeUM%3D","line":9,"updated":"2013-07-30 16:18:50.000000000","message":"(nit) s/anyway ends being/always ends up being/","commit_id":"7e1dfbf97f6b1c58ca38a92e31fbf2c2cd052a21"}],"ceilometer/objectstore/swift_middleware.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"3f2f2adad5df246956acd7042095cc4884bac511","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        with pipeline.PublishContext("},{"line_number":134,"context_line":"                context.get_admin_context(),"},{"line_number":135,"context_line":"                cfg.CONF.sample_source,"},{"line_number":136,"context_line":"                self.pipeline_manager.pipelines,"},{"line_number":137,"context_line":"        ) as publisher:"},{"line_number":138,"context_line":"            if bytes_received:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FX8M%3D","side":"PARENT","line":135,"updated":"2013-08-01 07:36:11.000000000","message":"No source is set in each sample here and no default source is set in sample.Sample.\nI guess something is missing here or I haven\u0027t found where the default source is set.\n\nFor sure the source must be set before it has been sent to the publisher. To allow different source per swift cluster for example.","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cee2da8bdeccf38cd369868b6fda39855ffa4b6e","unresolved":false,"context_lines":[{"line_number":132,"context_line":""},{"line_number":133,"context_line":"        with pipeline.PublishContext("},{"line_number":134,"context_line":"                context.get_admin_context(),"},{"line_number":135,"context_line":"                cfg.CONF.sample_source,"},{"line_number":136,"context_line":"                self.pipeline_manager.pipelines,"},{"line_number":137,"context_line":"        ) as publisher:"},{"line_number":138,"context_line":"            if bytes_received:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FX0s%3D","side":"PARENT","line":135,"in_reply_to":"AAAAQn%2F%2FX8M%3D","updated":"2013-08-01 08:18:02.000000000","message":"There\u0027s a default source set in Samples","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"}],"ceilometer/sample.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"47863723d092981b418dedb1dc4fcbcf99aa188a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"TYPE_CUMULATIVE \u003d \u0027cumulative\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def from_notification(cls, name, type, volume, unit,"},{"line_number":82,"context_line":"                      user_id, project_id, resource_id,"},{"line_number":83,"context_line":"                      message):"},{"line_number":84,"context_line":"    metadata \u003d copy.copy(message[\u0027payload\u0027])"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAQn%2F%2FeWU%3D","line":81,"updated":"2013-07-30 16:18:50.000000000","message":"can this be moved into above class and then we drop the \u0027Sample.from_notification \u003d ...\u0027 below?","commit_id":"7e1dfbf97f6b1c58ca38a92e31fbf2c2cd052a21"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3346d6de928dd61dbddf22a70b527f049c0c8413","unresolved":false,"context_lines":[{"line_number":78,"context_line":"TYPE_CUMULATIVE \u003d \u0027cumulative\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def from_notification(cls, name, type, volume, unit,"},{"line_number":82,"context_line":"                      user_id, project_id, resource_id,"},{"line_number":83,"context_line":"                      message):"},{"line_number":84,"context_line":"    metadata \u003d copy.copy(message[\u0027payload\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FWgI%3D","line":81,"updated":"2013-08-01 15:25:37.000000000","message":"i take it we don\u0027t want to move this function into Sample class?","commit_id":"dc64a316194d4d02770db8bbdd011fbfe9b62f51"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8640727e6cc21b628c1dab7528319140e5942f3a","unresolved":false,"context_lines":[{"line_number":78,"context_line":"TYPE_CUMULATIVE \u003d \u0027cumulative\u0027"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"def from_notification(cls, name, type, volume, unit,"},{"line_number":82,"context_line":"                      user_id, project_id, resource_id,"},{"line_number":83,"context_line":"                      message):"},{"line_number":84,"context_line":"    metadata \u003d copy.copy(message[\u0027payload\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAQn%2F%2FOGI%3D","line":81,"in_reply_to":"AAAAQn%2F%2FWgI%3D","updated":"2013-08-05 09:33:02.000000000","message":"Ah I forgot to move it, nice catch again!","commit_id":"dc64a316194d4d02770db8bbdd011fbfe9b62f51"}]}