)]}'
{"ceilometer/transformer/conversions.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5c7c5b5ec22d98a1d7b3a1ff75ca2cb438bf71a1","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            counter \u003d self._convert(counter, rate_of_change)"},{"line_number":141,"context_line":"            LOG.debug(_(\u0027converted to: %s\u0027) % (counter,))"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            LOG.warn(_(\u0027dropping counter with no predecessor: %s\u0027) %"},{"line_number":144,"context_line":"                     (counter,))"},{"line_number":145,"context_line":"            counter \u003d None"},{"line_number":146,"context_line":"        return counter"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FbuA%3D","line":143,"updated":"2013-07-31 09:30:21.000000000","message":"Actually I think it should be a ,","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6a84088efa366df86e08e3805ce1196c8626e890","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            counter \u003d self._convert(counter, rate_of_change)"},{"line_number":141,"context_line":"            LOG.debug(_(\u0027converted to: %s\u0027) % (counter,))"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            LOG.warn(_(\u0027dropping counter with no predecessor: %s\u0027) %"},{"line_number":144,"context_line":"                     (counter,))"},{"line_number":145,"context_line":"            counter \u003d None"},{"line_number":146,"context_line":"        return counter"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2FbVw%3D","line":143,"in_reply_to":"AAAAQn%2F%2Fbg4%3D","updated":"2013-07-31 11:19:40.000000000","message":"Not sure I\u0027ve been clear with my command. I meant LOG.warn(\"my stirng %s\", counter)\nBut since the code above does the same, fair enough.","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"28ea15c9b547a085857678d709d4180ef0fb7c92","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            counter \u003d self._convert(counter, rate_of_change)"},{"line_number":141,"context_line":"            LOG.debug(_(\u0027converted to: %s\u0027) % (counter,))"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            LOG.warn(_(\u0027dropping counter with no predecessor: %s\u0027) %"},{"line_number":144,"context_line":"                     (counter,))"},{"line_number":145,"context_line":"            counter \u003d None"},{"line_number":146,"context_line":"        return counter"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fbg4%3D","line":143,"in_reply_to":"AAAAQn%2F%2Fbms%3D","updated":"2013-07-31 10:30:55.000000000","message":"Yes, you are correct. The else branch is only entered when there\u0027s no prior primary counter, so the derived counter based on rate-of-change cannot yet be calculated (at least two instances of the primary counter must have been seen before the derived counter can be emitted).\n\nBTW the approach to fixing this seems acceptable to me, as it\u0027s consistent with the other counter logging calls in the same class. I had exactly the same fix in my devstack, just didn\u0027t get around to proposing as a patch.","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"},{"author":{"_account_id":5055,"name":"Rain Suo","email":"yugsuo@gmail.com","username":"yugsuo"},"change_message_id":"842cdcb7fb66944cc899ee692244377ed700a585","unresolved":false,"context_lines":[{"line_number":140,"context_line":"            counter \u003d self._convert(counter, rate_of_change)"},{"line_number":141,"context_line":"            LOG.debug(_(\u0027converted to: %s\u0027) % (counter,))"},{"line_number":142,"context_line":"        else:"},{"line_number":143,"context_line":"            LOG.warn(_(\u0027dropping counter with no predecessor: %s\u0027) %"},{"line_number":144,"context_line":"                     (counter,))"},{"line_number":145,"context_line":"            counter \u003d None"},{"line_number":146,"context_line":"        return counter"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQn%2F%2Fbms%3D","line":143,"in_reply_to":"AAAAQn%2F%2FbuA%3D","updated":"2013-07-31 10:02:10.000000000","message":"Hmm, no....I don\u0027t think so, the counter that enter \"else...\" is actually the first counter of this meter, and it is actually dropped then. The second will be record and transformed. Am I right?","commit_id":"c9cd931eafef123387e9ed3342874dcf9e4848f5"}]}