)]}'
{"ceilometer/publisher/direct.py":[{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"d7b44081aad2a09909af754e66d4de51bf13e7e9","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        super(DirectPublisher, self).__init__(conf, parsed_url)"},{"line_number":40,"context_line":"        default_dispatcher \u003d parsed_url.scheme"},{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Uses \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_8a4b3bb0","line":42,"range":{"start_line":42,"start_character":73,"end_line":42,"end_character":77},"updated":"2016-11-14 19:56:27.000000000","message":"Use","commit_id":"024dfa81b5b97728319f34d27d168f5c9942dc48"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0a4b841a0167bee9f9e4b27c9f5e92f90a3c4e80","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        super(DirectPublisher, self).__init__(conf, parsed_url)"},{"line_number":40,"context_line":"        default_dispatcher \u003d parsed_url.scheme"},{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Uses \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_193bf9ec","line":42,"range":{"start_line":42,"start_character":73,"end_line":42,"end_character":77},"in_reply_to":"7a77a97e_8a4b3bb0","updated":"2016-11-15 07:01:44.000000000","message":"Done","commit_id":"024dfa81b5b97728319f34d27d168f5c9942dc48"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"d7b44081aad2a09909af754e66d4de51bf13e7e9","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        default_dispatcher \u003d parsed_url.scheme"},{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Uses \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_0ad64bc5","line":43,"range":{"start_line":43,"start_character":51,"end_line":43,"end_character":58},"updated":"2016-11-14 19:56:27.000000000","message":"instead, e.g.","commit_id":"024dfa81b5b97728319f34d27d168f5c9942dc48"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"0a4b841a0167bee9f9e4b27c9f5e92f90a3c4e80","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        default_dispatcher \u003d parsed_url.scheme"},{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Uses \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a77a97e_3940b556","line":43,"range":{"start_line":43,"start_character":51,"end_line":43,"end_character":58},"in_reply_to":"7a77a97e_0ad64bc5","updated":"2016-11-15 07:01:44.000000000","message":"Done","commit_id":"024dfa81b5b97728319f34d27d168f5c9942dc48"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"0b64c4379b22054638f98a9fd9c8615dcfbe7424","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Use \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead, e.g. \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"},{"line_number":47,"context_line":"        self.dispatcher_name \u003d options.get(\u0027dispatcher\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_78c5998c","line":44,"range":{"start_line":44,"start_character":42,"end_line":44,"end_character":46},"updated":"2016-11-16 02:22:12.000000000","message":"There is file publisher, Will we use direct publisher to replace?","commit_id":"f843b7882fb806cf564c5b3106f601815a48c93b"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"94b92171fbc9461a573c8c4c04902a1ddf31e740","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Use \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead, e.g. \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"},{"line_number":47,"context_line":"        self.dispatcher_name \u003d options.get(\u0027dispatcher\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_733da9ba","line":44,"range":{"start_line":44,"start_character":42,"end_line":44,"end_character":46},"in_reply_to":"7a77a97e_197ae4f1","updated":"2016-11-16 11:22:59.000000000","message":"I can see the file_alt. my patch is merging the file dispatcher and file publisher. I am just not sure why we need reuse direct to implement the same thing as file publisher.","commit_id":"f843b7882fb806cf564c5b3106f601815a48c93b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"7afc93cb46fdb3423f48bc82493ccc3e787f8046","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Use \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead, e.g. \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"},{"line_number":47,"context_line":"        self.dispatcher_name \u003d options.get(\u0027dispatcher\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_caad8c85","line":44,"range":{"start_line":44,"start_character":42,"end_line":44,"end_character":46},"in_reply_to":"7a77a97e_733da9ba","updated":"2016-11-17 18:20:04.000000000","message":"I keep that only for backward compat, but yeah at this end all of these \u0027alt\u0027 will be dropped.","commit_id":"f843b7882fb806cf564c5b3106f601815a48c93b"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c575ab7ef65d2361907b20e27e8d638e859dbd26","unresolved":false,"context_lines":[{"line_number":41,"context_line":"        if default_dispatcher \u003d\u003d \u0027direct\u0027:"},{"line_number":42,"context_line":"            LOG.warning(_LW(\u0027Direct publisher is deprecated for removal. Use \u0027"},{"line_number":43,"context_line":"                            \u0027an explicit publisher instead, e.g. \"gnocchi\", \u0027"},{"line_number":44,"context_line":"                            \u0027\"database\", \"file\", ...\u0027))"},{"line_number":45,"context_line":"            default_dispatcher \u003d \u0027database\u0027"},{"line_number":46,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"},{"line_number":47,"context_line":"        self.dispatcher_name \u003d options.get(\u0027dispatcher\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"7a77a97e_197ae4f1","line":44,"range":{"start_line":44,"start_character":42,"end_line":44,"end_character":46},"in_reply_to":"7a77a97e_78c5998c","updated":"2016-11-16 06:50:57.000000000","message":"unfortunately file dispatcher and file publisher differ in implementation. If you looks at the setup.cfg, you will see I have called the dispatcher one file_alt. I have seen some other review to merge them.","commit_id":"f843b7882fb806cf564c5b3106f601815a48c93b"}]}