)]}'
{"ceilometer/publisher/direct.py":[{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"943b3d43dc194f5afeb7910e6cebb143d55f57b6","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if not isinstance(samples, list):"},{"line_number":77,"context_line":"            samples \u003d [samples]"},{"line_number":78,"context_line":"        self.get_sample_dispatcher().record_metering_data(["},{"line_number":79,"context_line":"            utils.meter_message_from_counter(sample, None)"},{"line_number":80,"context_line":"            for sample in samples])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def publish_events(self, events):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_e0eeaa20","line":79,"updated":"2016-11-11 21:27:55.000000000","message":"This feels obfuscated to me...  can we make it explicit - I\u0027d like comment _and_ code change for a bit of explicitness, but you decide, e.g.:\n\n    # not published externally; skip signing\n    self.get_sample_dispatcher().record_metering_data([\n            utils.meter_message_from_counter(sample, secret\u003dNone)\n            for sample in samples])","commit_id":"43d0faf0080871b47ba655dba77914bba793f050"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"eeb3fc720eba6c6135e91d988bec0780ec712e14","unresolved":false,"context_lines":[{"line_number":76,"context_line":"        if not isinstance(samples, list):"},{"line_number":77,"context_line":"            samples \u003d [samples]"},{"line_number":78,"context_line":"        self.get_sample_dispatcher().record_metering_data(["},{"line_number":79,"context_line":"            utils.meter_message_from_counter(sample, None)"},{"line_number":80,"context_line":"            for sample in samples])"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    def publish_events(self, events):"}],"source_content_type":"text/x-python","patch_set":2,"id":"9a629dbe_4070360b","line":79,"in_reply_to":"9a629dbe_e0eeaa20","updated":"2016-11-11 21:39:14.000000000","message":"Done","commit_id":"43d0faf0080871b47ba655dba77914bba793f050"},{"author":{"_account_id":8290,"name":"liusheng","email":"liusheng2048@gmail.com","username":"LiuSheng"},"change_message_id":"0b2e63d0ca0713be7bc9b11d7eb69f776bd0c0fb","unresolved":false,"context_lines":[{"line_number":75,"context_line":""},{"line_number":76,"context_line":"        if not isinstance(samples, list):"},{"line_number":77,"context_line":"            samples \u003d [samples]"},{"line_number":78,"context_line":"        # not published externally; skip signing"},{"line_number":79,"context_line":"        self.get_sample_dispatcher().record_metering_data(["},{"line_number":80,"context_line":"            utils.meter_message_from_counter(sample, secret\u003dNone)"},{"line_number":81,"context_line":"            for sample in samples])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_01b7ed39","line":78,"range":{"start_line":78,"start_character":7,"end_line":78,"end_character":48},"updated":"2016-11-15 13:09:29.000000000","message":"the message_signature will be record in db, if we skip this, that signature will not be computed and added into the message. it may cause inconsistency of data","commit_id":"21c2bb4ca96988e4d433e8d3794133eeba41c1bb"}]}