)]}'
{"ceilometer/publisher/http.py":[{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"43b7efe2e42cf9c2af0cd4ff93ab9153c0f91d61","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                self.verify_ssl \u003d strutils.bool_from_string("},{"line_number":90,"context_line":"                    params.get(\u0027verify_ssl\u0027, strict\u003dTrue)"},{"line_number":91,"context_line":"            except ValueError:"},{"line_number":92,"context_line":"                self.verify_ssl \u003d params.get(\u0027verify_ssl\u0027) or True"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            self.timeout \u003d 1"},{"line_number":95,"context_line":"            max_retries \u003d 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_a0d592e5","line":92,"updated":"2016-11-11 21:35:53.000000000","message":"Bug:   if params[\u0027verify_ssl\u0027] is False, this will override it,\nand set self.verify_ssl to True;  you want to do this instead:\n\n    self.verify_ssl \u003d params.get(\u0027verify_ssl\u0027, True)","commit_id":"142391f2da606d7c5adf6db7ef374e1a09a39aeb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fbf7f05a1c8d205b7d3254538c6795fc8c1332ff","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                self.verify_ssl \u003d strutils.bool_from_string("},{"line_number":90,"context_line":"                    params.get(\u0027verify_ssl\u0027, strict\u003dTrue)"},{"line_number":91,"context_line":"            except ValueError:"},{"line_number":92,"context_line":"                self.verify_ssl \u003d params.get(\u0027verify_ssl\u0027) or True"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            self.timeout \u003d 1"},{"line_number":95,"context_line":"            max_retries \u003d 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_b9085b93","line":92,"in_reply_to":"9a629dbe_278de67b","updated":"2016-11-14 19:09:07.000000000","message":"basically, the purpose is to accept either a True equivalent value, a False equivalent value, or a string path. if it\u0027s none of these, just default to True.\n\ni don\u0027t believe what you\u0027re proposing is logically equivalent. specifically if verify_ssl\u003d\u0027\u0027, i want it to give me True.\n\ni\u0027ll update new patch and we can adjust based on that.","commit_id":"142391f2da606d7c5adf6db7ef374e1a09a39aeb"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"3fd18ba3e712b2d830fb9ca5f5b459c7e4d7b9d4","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                self.verify_ssl \u003d strutils.bool_from_string("},{"line_number":90,"context_line":"                    params.get(\u0027verify_ssl\u0027, strict\u003dTrue)"},{"line_number":91,"context_line":"            except ValueError:"},{"line_number":92,"context_line":"                self.verify_ssl \u003d params.get(\u0027verify_ssl\u0027) or True"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            self.timeout \u003d 1"},{"line_number":95,"context_line":"            max_retries \u003d 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_d6693e27","line":92,"in_reply_to":"9a629dbe_a0d592e5","updated":"2016-11-14 14:45:24.000000000","message":"if it\u0027s \u0027false\u0027 it actually won\u0027t get to this code. it only gets here if verify_ssl is something that cant be mapped to True/False.","commit_id":"142391f2da606d7c5adf6db7ef374e1a09a39aeb"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"db4cdbb9ade0e05d664c826850de97c371848925","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                self.verify_ssl \u003d strutils.bool_from_string("},{"line_number":90,"context_line":"                    params.get(\u0027verify_ssl\u0027, strict\u003dTrue)"},{"line_number":91,"context_line":"            except ValueError:"},{"line_number":92,"context_line":"                self.verify_ssl \u003d params.get(\u0027verify_ssl\u0027) or True"},{"line_number":93,"context_line":"        else:"},{"line_number":94,"context_line":"            self.timeout \u003d 1"},{"line_number":95,"context_line":"            max_retries \u003d 2"}],"source_content_type":"text/x-python","patch_set":1,"id":"9a629dbe_278de67b","line":92,"in_reply_to":"9a629dbe_d6693e27","updated":"2016-11-14 15:36:47.000000000","message":"...yes - I was aware of that when I wrote this - still, it\u0027s incorrect code, even if this instance may have no code-path effect, there is a roomful of new grads who don\u0027t know python who will take it up as an \"example\".\n\nHopefully you\u0027ll make a decision to either explicitly make it \"True\" by default, or ...  I suppose the correct form of get is really just next to impossible to defend here, perhaps (if a bool got through here, something else is wrong)...\n\nBut I hope you get my point is its ... not clear, and not explicit nor clearly correct as is...\n\nI understand its still in development code, too...","commit_id":"142391f2da606d7c5adf6db7ef374e1a09a39aeb"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"42d4c757432e766916fad13ea6e1ce1033f5fe9a","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.verify_ssl \u003d (self._get_param(params, \u0027verify_ssl\u0027, None)"},{"line_number":90,"context_line":"                               or True)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.session \u003d requests.Session()"},{"line_number":93,"context_line":"        self.session.mount(self.target,"},{"line_number":94,"context_line":"                           adapters.HTTPAdapter(max_retries\u003dself.max_retries))"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_f9a55db5","line":92,"updated":"2016-11-15 06:54:05.000000000","message":"Creating a session per publisher mean having the number of http connections limited to 10 (pool_connections/pool_maxsize of HTTPAdapter). Perhaps later this should be configurable.","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"084589c1cde4c2ca874d78d06040f0899a256b18","unresolved":false,"context_lines":[{"line_number":89,"context_line":"            self.verify_ssl \u003d (self._get_param(params, \u0027verify_ssl\u0027, None)"},{"line_number":90,"context_line":"                               or True)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.session \u003d requests.Session()"},{"line_number":93,"context_line":"        self.session.mount(self.target,"},{"line_number":94,"context_line":"                           adapters.HTTPAdapter(max_retries\u003dself.max_retries))"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_d73a0c36","line":92,"in_reply_to":"7a77a97e_f9a55db5","updated":"2016-11-15 17:45:43.000000000","message":"should i keep it as before or add a TODO?","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"42d4c757432e766916fad13ea6e1ce1033f5fe9a","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.session \u003d requests.Session()"},{"line_number":93,"context_line":"        self.session.mount(self.target,"},{"line_number":94,"context_line":"                           adapters.HTTPAdapter(max_retries\u003dself.max_retries))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        LOG.debug(\u0027HttpPublisher for endpoint %s is initialized!\u0027 %"},{"line_number":97,"context_line":"                  self.target)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_994e29c0","line":94,"updated":"2016-11-15 06:54:05.000000000","message":"This only works for HTTP and not for HTTPS. I known that the bug was present before your change. So no need to fix this here. but perhaps a TODO/FIXME ?","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"084589c1cde4c2ca874d78d06040f0899a256b18","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"        self.session \u003d requests.Session()"},{"line_number":93,"context_line":"        self.session.mount(self.target,"},{"line_number":94,"context_line":"                           adapters.HTTPAdapter(max_retries\u003dself.max_retries))"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"        LOG.debug(\u0027HttpPublisher for endpoint %s is initialized!\u0027 %"},{"line_number":97,"context_line":"                  self.target)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_173d642b","line":94,"in_reply_to":"7a77a97e_994e29c0","updated":"2016-11-15 17:45:43.000000000","message":"sure.","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"42d4c757432e766916fad13ea6e1ce1033f5fe9a","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :param events: events from pipeline after transformation"},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        self.poster([event.serialize() for event in events])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_99e549aa","line":142,"updated":"2016-11-15 06:54:05.000000000","message":"Does this break application that expect the old format ?","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"084589c1cde4c2ca874d78d06040f0899a256b18","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        :param events: events from pipeline after transformation"},{"line_number":141,"context_line":"        \"\"\""},{"line_number":142,"context_line":"        self.poster([event.serialize() for event in events])"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a77a97e_3778a0f2","line":142,"in_reply_to":"7a77a97e_99e549aa","updated":"2016-11-15 17:45:43.000000000","message":"yes, this will break... but i hate the fact that we only send events if we have raw... this seems very limited to a single use case.\n\nmaybe i can add a \u0027raw_only\u0027 tag?\n\ni do prefer we do not have this raw_only path as default.","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"}],"releasenotes/notes/deprecate-http-dispatcher-dbbaacee8182b550.yaml":[{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1fc32425e9606e4f24df32934090b0bd77261a88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Configuration values can passed in via the querystring of publisher in "},{"line_number":4,"context_line":"    pipeline. For example, rather than setting target, timeout, verify_ssl,"},{"line_number":5,"context_line":"    and batch_mode under [dispatcher_http] section of conf, you can specify"},{"line_number":6,"context_line":"    http://\u003ctarget\u003e/?verify_ssl\u003dTrue\u0026batch\u003dTrue\u0026timeout\u003d10"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a77a97e_8d3c2731","line":3,"range":{"start_line":3,"start_character":25,"end_line":3,"end_character":29},"updated":"2016-11-15 03:48:34.000000000","message":"can be","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1fc32425e9606e4f24df32934090b0bd77261a88","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Configuration values can passed in via the querystring of publisher in "},{"line_number":4,"context_line":"    pipeline. For example, rather than setting target, timeout, verify_ssl,"},{"line_number":5,"context_line":"    and batch_mode under [dispatcher_http] section of conf, you can specify"},{"line_number":6,"context_line":"    http://\u003ctarget\u003e/?verify_ssl\u003dTrue\u0026batch\u003dTrue\u0026timeout\u003d10"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"7a77a97e_8d798732","line":3,"range":{"start_line":3,"start_character":74,"end_line":3,"end_character":75},"updated":"2016-11-15 03:48:34.000000000","message":"space","commit_id":"45bb5e4a4144a5930e74c8d23f8d75b4079f04ab"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7f919e63faebd8ffd0a53f76ab090700743db8b7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - Configuration values can passed in via the querystring of publisher in "},{"line_number":4,"context_line":"    pipeline. For example, rather than setting target, timeout, verify_ssl,"},{"line_number":5,"context_line":"    and batch_mode under [dispatcher_http] section of conf, you can specify"},{"line_number":6,"context_line":"    http://\u003ctarget\u003e/?verify_ssl\u003dTrue\u0026batch\u003dTrue\u0026timeout\u003d10. Use `raw_only\u003d1`"}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3a461143_1c8fcc2a","line":3,"updated":"2017-01-30 20:43:48.000000000","message":"trailing whitespace","commit_id":"e2e74892daa79388accb6df4d4642a4632332911"}]}