)]}'
{"ceilometer/pipeline.py":[{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"7730a85f2c043f483771c6c72ac56c1c1e0516f2","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_2df25a06","line":456,"updated":"2016-11-19 06:55:29.000000000","message":"is the text of the Exception  `Exception as err` part) no longer useful to include with the error message?","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"0ff644916335bc0f054cde5d9cb738e0977f8f13","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_326ee0c9","line":456,"in_reply_to":"7a77a97e_07852458","updated":"2016-11-22 11:48:04.000000000","message":"actually it doesn\u0027t need catch all, use \"except Exception\" can catch what we want.","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"30e2bc207afec3bd4f5c33f258f5ced8c4102f21","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_fdcba6a1","line":456,"in_reply_to":"7a77a97e_2df25a06","updated":"2016-11-20 16:45:13.000000000","message":"I think the error seems not to be useful. if it must be included, just add it in future.","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"dfc81c414c44ef67aa16a1be8ce0d0067b5af293","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_75c83475","line":456,"in_reply_to":"7a77a97e_326ee0c9","updated":"2016-11-22 15:54:36.000000000","message":"Yes.  Sorry, my mistake when digging into this, I was focused on loss of exception text (which you chose to leave out).  Ok.","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"dca5128606e096bbf1e2d095ef3b154a8498259a","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_07852458","line":456,"in_reply_to":"7a77a97e_90f43388","updated":"2016-11-22 11:35:45.000000000","message":"yes","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":19594,"name":"Yarko Tymciurak","email":"yarko.tymciurak@intel.com","username":"yarkot"},"change_message_id":"d9fd6a48a2e334b3b145dcd64bcf2fa26725aee5","unresolved":false,"context_lines":[{"line_number":453,"context_line":"                                                  \u0027trans\u0027: transformer})"},{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7a77a97e_90f43388","line":456,"in_reply_to":"7a77a97e_fdcba6a1","updated":"2016-11-21 18:11:31.000000000","message":"Since \"except:\"  catches more than \"except Exception as e:\", this will also catch (and log) things which the previous did not -  like system exits, etc.\n\nIs that a change you intend?","commit_id":"58bd994435d233acf5475f7638dc09ec0a3634ac"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"8bb0d0a3feb282c22d1774ba7e4a5e9cbcace657","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":460,"context_line":"                                             \u0027trans\u0027: transformer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_19f0ddc8","line":457,"updated":"2016-11-25 20:33:59.000000000","message":"This is actually LOG.error(..., exc_info\u003dTrue)\n\nwhich I\u0027d prefer rather than LOG.exception which is likely deprecated or soon to be","commit_id":"1184035b0599b230d8d8170a386a37aed8690cea"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"940de17f6194de29f283657621a844ffe168d4c8","unresolved":false,"context_lines":[{"line_number":454,"context_line":"                    return"},{"line_number":455,"context_line":"            return sample"},{"line_number":456,"context_line":"        except Exception:"},{"line_number":457,"context_line":"            LOG.exception(_("},{"line_number":458,"context_line":"                \"Pipeline %(pipeline)s: Exit after error from transformer \""},{"line_number":459,"context_line":"                \"%(trans)s for %(smp)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":460,"context_line":"                                             \u0027trans\u0027: transformer,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a74a57a_8171b946","line":457,"in_reply_to":"5a74a57a_19f0ddc8","updated":"2016-11-28 08:51:09.000000000","message":"Done","commit_id":"1184035b0599b230d8d8170a386a37aed8690cea"}]}