)]}'
{"tests/api/v2/test_alarm_scenarios.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"fab21fb7ac4e726c45d66ac88509699cdc6acfbc","unresolved":false,"context_lines":[{"line_number":124,"context_line":"                       headers\u003dself.auth_headers)"},{"line_number":125,"context_line":"        alarms \u003d list(self.conn.get_alarms())"},{"line_number":126,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":127,"context_line":"        for i in range(4):"},{"line_number":128,"context_line":"            if alarms[i].name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":129,"context_line":"                posted_flag \u003d True"},{"line_number":130,"context_line":"                self.assertEquals(alarms[i].repeat_actions, True)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAQ3%2F%2F9vU%3D","line":127,"updated":"2013-08-12 12:01:27.000000000","message":"for alarm in alarms:\n  if alarm.name \u003d\u003d \"added_alarm\":\n    self.assertTrue(alarm.repeat_actions)\n    break\nelse:\n  self.fail(\"Alarm not found\")","commit_id":"463de088e8b320f3ad984d7f0caea2280e1541ba"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"03a1fd9ddd6fb4aef697f24d0227bef4c454aa8a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertTrue(alarm.repeat_actions)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQ3%2F%2F9WU%3D","line":128,"updated":"2013-08-12 13:51:47.000000000","message":"i\u0027d prefer if this was self.assertIs(alarm.repeat_actions, True) to verify it\u0027s actually of value True","commit_id":"e15533b23c92df8026db3ad6976779f4537e4269"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"98a48574905fd9a7bfb6213c5e0d6eb86939f3e2","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertTrue(alarm.repeat_actions)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAQ3%2F%2F9RE%3D","line":128,"in_reply_to":"AAAAQ3%2F%2F9WU%3D","updated":"2013-08-12 14:09:00.000000000","message":"My bad, I think I\u0027m the one that proposed that; if that\u0027s suppose to be a boolean, assertEqual might be more explicit indeed.","commit_id":"e15533b23c92df8026db3ad6976779f4537e4269"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"d006a8726e1d5cf36044619dcddfc48d8c3b2558","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertEqual(alarm.repeat_actions, True)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQ3%2F%2F4pY%3D","line":128,"updated":"2013-08-13 14:12:19.000000000","message":"Agree with Sandy that it LOOKS better to use assertTrue than using assertEqual though it serves the same purposes. Not sure if the patchset\ncomment really answers Sandy\u0027s comment though.","commit_id":"0bc97738c67c38235fb709381b7f08057efc599c"},{"author":{"_account_id":688,"name":"Sandy Walsh","email":"sandy.walsh@rackspace.com","username":"sandy-walsh"},"change_message_id":"fc219adf4fa09cdf4c83d3495151fa10ee197d88","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertEqual(alarm.repeat_actions, True)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQ3%2F%2F4yo%3D","line":128,"updated":"2013-08-13 13:42:50.000000000","message":"assertTrue()?","commit_id":"0bc97738c67c38235fb709381b7f08057efc599c"},{"author":{"_account_id":7642,"name":"Fengqian Gao","email":"fengqian.gao@intel.com","username":"Fengqian"},"change_message_id":"46646b895897fda9a767cc33ee41eee76aea410d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertEqual(alarm.repeat_actions, True)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQ3%2F%2F4mg%3D","line":128,"in_reply_to":"AAAAQ3%2F%2F4pY%3D","updated":"2013-08-13 15:59:21.000000000","message":"@litong01\n\nPlease see comment in patch set 4.\n\nI agree with the comments in patch set 4. \n\nHere, alarm.repeat_actions suppose to be a boolean, it should be better to check it equals \"True\". If use assertTrue, what if the alarm.repeat_actions \u003d\u003d 2?\n\n\nThanks\n\nFengqian","commit_id":"0bc97738c67c38235fb709381b7f08057efc599c"},{"author":{"_account_id":7642,"name":"Fengqian Gao","email":"fengqian.gao@intel.com","username":"Fengqian"},"change_message_id":"a7e6f586ccc2682c72c6a30331a55601b37aca86","unresolved":false,"context_lines":[{"line_number":125,"context_line":"        self.assertEquals(4, len(alarms))"},{"line_number":126,"context_line":"        for alarm in alarms:"},{"line_number":127,"context_line":"            if alarm.name \u003d\u003d \u0027added_alarm\u0027:"},{"line_number":128,"context_line":"                self.assertEqual(alarm.repeat_actions, True)"},{"line_number":129,"context_line":"                break"},{"line_number":130,"context_line":"        else:"},{"line_number":131,"context_line":"            self.fail(\"Alarm not found\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAQ3%2F%2F4xI%3D","line":128,"in_reply_to":"AAAAQ3%2F%2F4yo%3D","updated":"2013-08-13 13:48:28.000000000","message":"About this question, please see the comments in patch set 4:)\n\nTHanks\n\n\nFengqian","commit_id":"0bc97738c67c38235fb709381b7f08057efc599c"}]}