)]}'
{"devstack/plugin.sh":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"2bbba7f43f810b53d59afbafe87fdd033e242c83","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Set configuration for storage backend when no collector."},{"line_number":281,"context_line":"function _ceilometer_configure_storage_backend_without_collector {"},{"line_number":282,"context_line":"    if [ \"$CEILOMETER_BACKEND\" \u003d \u0027none\u0027 ] ; then"},{"line_number":283,"context_line":"        if ! is_service_enabled panko-api; then"},{"line_number":284,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":285,"context_line":"        fi"},{"line_number":286,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":287,"context_line":"        dispatcher\u003ddatabase"},{"line_number":288,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"},{"line_number":289,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":290,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027es\u0027 ] ; then"},{"line_number":291,"context_line":"        dispatcher\u003ddatabase"},{"line_number":292,"context_line":"        # es is only supported for events. we will use sql for metering."},{"line_number":293,"context_line":"        iniset $CEILOMETER_CONF database event_connection es://localhost:9200"},{"line_number":294,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":295,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":296,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mongodb\u0027 ] ; then"},{"line_number":297,"context_line":"        dispatcher\u003ddatabase"},{"line_number":298,"context_line":"        iniset $CEILOMETER_CONF database event_connection mongodb://localhost:27017/ceilometer"},{"line_number":299,"context_line":"        iniset $CEILOMETER_CONF database metering_connection mongodb://localhost:27017/ceilometer"},{"line_number":300,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027gnocchi\u0027 ] ; then"},{"line_number":301,"context_line":"        dispatcher\u003dgnocchi"},{"line_number":302,"context_line":"        # NOTE(gordc): set higher retry in case gnocchi is started after ceilometer on a slow machine"},{"line_number":303,"context_line":"        iniset $CEILOMETER_CONF storage max_retries 20"},{"line_number":304,"context_line":"        # NOTE(gordc): set batching to better handle recording on a slow machine"},{"line_number":305,"context_line":"        iniset $CEILOMETER_CONF dispatcher_gnocchi archive_policy ${GNOCCHI_ARCHIVE_POLICY}"},{"line_number":306,"context_line":"        if is_service_enabled swift \u0026\u0026 [[ \"$GNOCCHI_STORAGE_BACKEND\" \u003d \u0027swift\u0027 ]] ; then"},{"line_number":307,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"True\""},{"line_number":308,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_project \"gnocchi_swift\""},{"line_number":309,"context_line":"        else"},{"line_number":310,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"False\""},{"line_number":311,"context_line":"        fi"},{"line_number":312,"context_line":"    else"},{"line_number":313,"context_line":"        die $LINENO \"Unable to configure unknown CEILOMETER_BACKEND $CEILOMETER_BACKEND\""},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":"    if [ \"$dispatcher\" ]; then"},{"line_number":316,"context_line":"        sed -i \u0027s/notifier:\\/\\//direct:\\/\\/?dispatcher\u003d\u0027$dispatcher\u0027/g\u0027 $CEILOMETER_YAML_DIR/event_pipeline.yaml $CEILOMETER_YAML_DIR/pipeline.yaml"},{"line_number":317,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_b706091a","line":314,"range":{"start_line":282,"start_character":0,"end_line":314,"end_character":6},"updated":"2016-12-21 14:10:03.000000000","message":"you should not need to copy/paste this section. you just need to change the publishers in pipeline.yaml and event_pipeline.yaml files","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dbd868a1ffedc780dbaaca5affed1da6239b31e2","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Set configuration for storage backend when no collector."},{"line_number":281,"context_line":"function _ceilometer_configure_storage_backend_without_collector {"},{"line_number":282,"context_line":"    if [ \"$CEILOMETER_BACKEND\" \u003d \u0027none\u0027 ] ; then"},{"line_number":283,"context_line":"        if ! is_service_enabled panko-api; then"},{"line_number":284,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":285,"context_line":"        fi"},{"line_number":286,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":287,"context_line":"        dispatcher\u003ddatabase"},{"line_number":288,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"},{"line_number":289,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":290,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027es\u0027 ] ; then"},{"line_number":291,"context_line":"        dispatcher\u003ddatabase"},{"line_number":292,"context_line":"        # es is only supported for events. we will use sql for metering."},{"line_number":293,"context_line":"        iniset $CEILOMETER_CONF database event_connection es://localhost:9200"},{"line_number":294,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":295,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":296,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mongodb\u0027 ] ; then"},{"line_number":297,"context_line":"        dispatcher\u003ddatabase"},{"line_number":298,"context_line":"        iniset $CEILOMETER_CONF database event_connection mongodb://localhost:27017/ceilometer"},{"line_number":299,"context_line":"        iniset $CEILOMETER_CONF database metering_connection mongodb://localhost:27017/ceilometer"},{"line_number":300,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027gnocchi\u0027 ] ; then"},{"line_number":301,"context_line":"        dispatcher\u003dgnocchi"},{"line_number":302,"context_line":"        # NOTE(gordc): set higher retry in case gnocchi is started after ceilometer on a slow machine"},{"line_number":303,"context_line":"        iniset $CEILOMETER_CONF storage max_retries 20"},{"line_number":304,"context_line":"        # NOTE(gordc): set batching to better handle recording on a slow machine"},{"line_number":305,"context_line":"        iniset $CEILOMETER_CONF dispatcher_gnocchi archive_policy ${GNOCCHI_ARCHIVE_POLICY}"},{"line_number":306,"context_line":"        if is_service_enabled swift \u0026\u0026 [[ \"$GNOCCHI_STORAGE_BACKEND\" \u003d \u0027swift\u0027 ]] ; then"},{"line_number":307,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"True\""},{"line_number":308,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_project \"gnocchi_swift\""},{"line_number":309,"context_line":"        else"},{"line_number":310,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"False\""},{"line_number":311,"context_line":"        fi"},{"line_number":312,"context_line":"    else"},{"line_number":313,"context_line":"        die $LINENO \"Unable to configure unknown CEILOMETER_BACKEND $CEILOMETER_BACKEND\""},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":"    if [ \"$dispatcher\" ]; then"},{"line_number":316,"context_line":"        sed -i \u0027s/notifier:\\/\\//direct:\\/\\/?dispatcher\u003d\u0027$dispatcher\u0027/g\u0027 $CEILOMETER_YAML_DIR/event_pipeline.yaml $CEILOMETER_YAML_DIR/pipeline.yaml"},{"line_number":317,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa48f94a_12d12cfc","line":314,"range":{"start_line":282,"start_character":0,"end_line":314,"end_character":6},"in_reply_to":"1a6eadb0_57edb5b5","updated":"2016-12-21 17:23:04.000000000","message":"what i mean is that regardless if collector is enabled or not, this code needs to run","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"03ba0e87eb12ea6a5ea600fce2a40fc496c298c2","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Set configuration for storage backend when no collector."},{"line_number":281,"context_line":"function _ceilometer_configure_storage_backend_without_collector {"},{"line_number":282,"context_line":"    if [ \"$CEILOMETER_BACKEND\" \u003d \u0027none\u0027 ] ; then"},{"line_number":283,"context_line":"        if ! is_service_enabled panko-api; then"},{"line_number":284,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":285,"context_line":"        fi"},{"line_number":286,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":287,"context_line":"        dispatcher\u003ddatabase"},{"line_number":288,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"},{"line_number":289,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":290,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027es\u0027 ] ; then"},{"line_number":291,"context_line":"        dispatcher\u003ddatabase"},{"line_number":292,"context_line":"        # es is only supported for events. we will use sql for metering."},{"line_number":293,"context_line":"        iniset $CEILOMETER_CONF database event_connection es://localhost:9200"},{"line_number":294,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":295,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":296,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mongodb\u0027 ] ; then"},{"line_number":297,"context_line":"        dispatcher\u003ddatabase"},{"line_number":298,"context_line":"        iniset $CEILOMETER_CONF database event_connection mongodb://localhost:27017/ceilometer"},{"line_number":299,"context_line":"        iniset $CEILOMETER_CONF database metering_connection mongodb://localhost:27017/ceilometer"},{"line_number":300,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027gnocchi\u0027 ] ; then"},{"line_number":301,"context_line":"        dispatcher\u003dgnocchi"},{"line_number":302,"context_line":"        # NOTE(gordc): set higher retry in case gnocchi is started after ceilometer on a slow machine"},{"line_number":303,"context_line":"        iniset $CEILOMETER_CONF storage max_retries 20"},{"line_number":304,"context_line":"        # NOTE(gordc): set batching to better handle recording on a slow machine"},{"line_number":305,"context_line":"        iniset $CEILOMETER_CONF dispatcher_gnocchi archive_policy ${GNOCCHI_ARCHIVE_POLICY}"},{"line_number":306,"context_line":"        if is_service_enabled swift \u0026\u0026 [[ \"$GNOCCHI_STORAGE_BACKEND\" \u003d \u0027swift\u0027 ]] ; then"},{"line_number":307,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"True\""},{"line_number":308,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_project \"gnocchi_swift\""},{"line_number":309,"context_line":"        else"},{"line_number":310,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"False\""},{"line_number":311,"context_line":"        fi"},{"line_number":312,"context_line":"    else"},{"line_number":313,"context_line":"        die $LINENO \"Unable to configure unknown CEILOMETER_BACKEND $CEILOMETER_BACKEND\""},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":"    if [ \"$dispatcher\" ]; then"},{"line_number":316,"context_line":"        sed -i \u0027s/notifier:\\/\\//direct:\\/\\/?dispatcher\u003d\u0027$dispatcher\u0027/g\u0027 $CEILOMETER_YAML_DIR/event_pipeline.yaml $CEILOMETER_YAML_DIR/pipeline.yaml"},{"line_number":317,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_57edb5b5","line":314,"range":{"start_line":282,"start_character":0,"end_line":314,"end_character":6},"in_reply_to":"1a6eadb0_b706091a","updated":"2016-12-21 14:25:58.000000000","message":"this function is the configure for no collector. do you mean we don\u0027t need set CEILOMETER_CONF properly in this case?","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1d3ed34868a475069090ef42ac57c9966c25efe5","unresolved":false,"context_lines":[{"line_number":279,"context_line":""},{"line_number":280,"context_line":"# Set configuration for storage backend when no collector."},{"line_number":281,"context_line":"function _ceilometer_configure_storage_backend_without_collector {"},{"line_number":282,"context_line":"    if [ \"$CEILOMETER_BACKEND\" \u003d \u0027none\u0027 ] ; then"},{"line_number":283,"context_line":"        if ! is_service_enabled panko-api; then"},{"line_number":284,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":285,"context_line":"        fi"},{"line_number":286,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":287,"context_line":"        dispatcher\u003ddatabase"},{"line_number":288,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"},{"line_number":289,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":290,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027es\u0027 ] ; then"},{"line_number":291,"context_line":"        dispatcher\u003ddatabase"},{"line_number":292,"context_line":"        # es is only supported for events. we will use sql for metering."},{"line_number":293,"context_line":"        iniset $CEILOMETER_CONF database event_connection es://localhost:9200"},{"line_number":294,"context_line":"        iniset $CEILOMETER_CONF database metering_connection $(database_connection_url ceilometer)"},{"line_number":295,"context_line":"        ${TOP_DIR}/pkg/elasticsearch.sh start"},{"line_number":296,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mongodb\u0027 ] ; then"},{"line_number":297,"context_line":"        dispatcher\u003ddatabase"},{"line_number":298,"context_line":"        iniset $CEILOMETER_CONF database event_connection mongodb://localhost:27017/ceilometer"},{"line_number":299,"context_line":"        iniset $CEILOMETER_CONF database metering_connection mongodb://localhost:27017/ceilometer"},{"line_number":300,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027gnocchi\u0027 ] ; then"},{"line_number":301,"context_line":"        dispatcher\u003dgnocchi"},{"line_number":302,"context_line":"        # NOTE(gordc): set higher retry in case gnocchi is started after ceilometer on a slow machine"},{"line_number":303,"context_line":"        iniset $CEILOMETER_CONF storage max_retries 20"},{"line_number":304,"context_line":"        # NOTE(gordc): set batching to better handle recording on a slow machine"},{"line_number":305,"context_line":"        iniset $CEILOMETER_CONF dispatcher_gnocchi archive_policy ${GNOCCHI_ARCHIVE_POLICY}"},{"line_number":306,"context_line":"        if is_service_enabled swift \u0026\u0026 [[ \"$GNOCCHI_STORAGE_BACKEND\" \u003d \u0027swift\u0027 ]] ; then"},{"line_number":307,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"True\""},{"line_number":308,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_project \"gnocchi_swift\""},{"line_number":309,"context_line":"        else"},{"line_number":310,"context_line":"            iniset $CEILOMETER_CONF dispatcher_gnocchi filter_service_activity \"False\""},{"line_number":311,"context_line":"        fi"},{"line_number":312,"context_line":"    else"},{"line_number":313,"context_line":"        die $LINENO \"Unable to configure unknown CEILOMETER_BACKEND $CEILOMETER_BACKEND\""},{"line_number":314,"context_line":"    fi"},{"line_number":315,"context_line":"    if [ \"$dispatcher\" ]; then"},{"line_number":316,"context_line":"        sed -i \u0027s/notifier:\\/\\//direct:\\/\\/?dispatcher\u003d\u0027$dispatcher\u0027/g\u0027 $CEILOMETER_YAML_DIR/event_pipeline.yaml $CEILOMETER_YAML_DIR/pipeline.yaml"},{"line_number":317,"context_line":"    fi"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa48f94a_72f9984d","line":314,"range":{"start_line":282,"start_character":0,"end_line":314,"end_character":6},"in_reply_to":"fa48f94a_12d12cfc","updated":"2016-12-21 17:31:27.000000000","message":"but some code in _ceilometer_configure_storage_backend doesn\u0027t need to run when no collector. for instance, \niniset $CEILOMETER_CONF DEFAULT meter_dispatchers database\niniset $CEILOMETER_CONF collector batch_size 50\niniset $CEILOMETER_CONF collector batch_timeout 5 \nthey have been removed in this function","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dbd868a1ffedc780dbaaca5affed1da6239b31e2","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    # Configure storage"},{"line_number":375,"context_line":"    if is_service_enabled ceilometer-collector ceilometer-api; then"},{"line_number":376,"context_line":"        _ceilometer_configure_storage_backend"},{"line_number":377,"context_line":"        iniset $CEILOMETER_CONF collector workers $API_WORKERS"},{"line_number":378,"context_line":"    elif !is_service_enabled ceilometer-collector; then"},{"line_number":379,"context_line":"        _ceilometer_configure_storage_backend_without_collector"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa48f94a_b2086093","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":45},"updated":"2016-12-21 17:23:04.000000000","message":"just make this run regardless if collector or api is enabled.","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"1d3ed34868a475069090ef42ac57c9966c25efe5","unresolved":false,"context_lines":[{"line_number":373,"context_line":""},{"line_number":374,"context_line":"    # Configure storage"},{"line_number":375,"context_line":"    if is_service_enabled ceilometer-collector ceilometer-api; then"},{"line_number":376,"context_line":"        _ceilometer_configure_storage_backend"},{"line_number":377,"context_line":"        iniset $CEILOMETER_CONF collector workers $API_WORKERS"},{"line_number":378,"context_line":"    elif !is_service_enabled ceilometer-collector; then"},{"line_number":379,"context_line":"        _ceilometer_configure_storage_backend_without_collector"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa48f94a_92bb5c75","line":376,"range":{"start_line":376,"start_character":8,"end_line":376,"end_character":45},"in_reply_to":"fa48f94a_b2086093","updated":"2016-12-21 17:31:27.000000000","message":"you may see _ceilometer_configure_storage_backend again :)\nsome configures need to be done after collector is enabled","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"03ba0e87eb12ea6a5ea600fce2a40fc496c298c2","unresolved":false,"context_lines":[{"line_number":375,"context_line":"    if is_service_enabled ceilometer-collector ceilometer-api; then"},{"line_number":376,"context_line":"        _ceilometer_configure_storage_backend"},{"line_number":377,"context_line":"        iniset $CEILOMETER_CONF collector workers $API_WORKERS"},{"line_number":378,"context_line":"    elif !is_service_enabled ceilometer-collector; then"},{"line_number":379,"context_line":"        _ceilometer_configure_storage_backend_without_collector"},{"line_number":380,"context_line":"    fi"},{"line_number":381,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"1a6eadb0_d70e258b","line":378,"range":{"start_line":378,"start_character":4,"end_line":378,"end_character":49},"updated":"2016-12-21 14:25:58.000000000","message":"this is an alternative way","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"dbd868a1ffedc780dbaaca5affed1da6239b31e2","unresolved":false,"context_lines":[{"line_number":376,"context_line":"        _ceilometer_configure_storage_backend"},{"line_number":377,"context_line":"        iniset $CEILOMETER_CONF collector workers $API_WORKERS"},{"line_number":378,"context_line":"    elif !is_service_enabled ceilometer-collector; then"},{"line_number":379,"context_line":"        _ceilometer_configure_storage_backend_without_collector"},{"line_number":380,"context_line":"    fi"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    if [[ \"$VIRT_DRIVER\" \u003d \u0027vsphere\u0027 ]]; then"}],"source_content_type":"text/x-sh","patch_set":3,"id":"fa48f94a_52f2d49b","line":379,"range":{"start_line":379,"start_character":8,"end_line":379,"end_character":63},"updated":"2016-12-21 17:23:04.000000000","message":"and have this part configure the pipeline","commit_id":"d29c6dc35adf49332b151f92b4d9d852d6a3d325"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"52790a7aac67c3fa64a6d929109a60b91194d76b","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":238,"context_line":"        fi"},{"line_number":239,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":240,"context_line":"        if is_service_enabled ceilometer-collector; then"},{"line_number":241,"context_line":"            iniset $CEILOMETER_CONF DEFAULT meter_dispatchers database"},{"line_number":242,"context_line":"        fi"},{"line_number":243,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"9a57fde8_0079bdfc","line":240,"updated":"2017-01-12 16:37:35.000000000","message":"i feel like these checks are unnecessary. you should really just be changing the *pipeline.yaml\n\ncan we maybe start by just adding a warning that we\u0027re deprecated collector (if we didn\u0027t do that already)","commit_id":"7e5f20f33f8347e43318eba08e01d4636107dee1"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"0905e93434671c688aa3a4b6bc2b803f0c71d733","unresolved":false,"context_lines":[{"line_number":237,"context_line":"            echo_summary \"All Ceilometer backends seems disabled, set \\$CEILOMETER_BACKEND to select one.\""},{"line_number":238,"context_line":"        fi"},{"line_number":239,"context_line":"    elif [ \"$CEILOMETER_BACKEND\" \u003d \u0027mysql\u0027 ] || [ \"$CEILOMETER_BACKEND\" \u003d \u0027postgresql\u0027 ] ; then"},{"line_number":240,"context_line":"        if is_service_enabled ceilometer-collector; then"},{"line_number":241,"context_line":"            iniset $CEILOMETER_CONF DEFAULT meter_dispatchers database"},{"line_number":242,"context_line":"        fi"},{"line_number":243,"context_line":"        iniset $CEILOMETER_CONF database event_connection $(database_connection_url ceilometer)"}],"source_content_type":"text/x-sh","patch_set":9,"id":"7a3c09a3_88a8ef21","line":240,"in_reply_to":"9a57fde8_0079bdfc","updated":"2017-01-17 12:09:39.000000000","message":"if ceilometer-collector will be not enabled in future, I think it\u0027s necessary anyway. but if you think this check is really earlier than collector being removed, I would add a warn instead.","commit_id":"7e5f20f33f8347e43318eba08e01d4636107dee1"}]}