)]}'
{"ceilometer/meter/notifications.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"f8aafd5a90ab291f75ed3a381e1d46c231c61068","unresolved":false,"context_lines":[{"line_number":165,"context_line":"            yield sample"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"class ProcessMeterNotifications(middleware.HTTPRequest):"},{"line_number":169,"context_line":""},{"line_number":170,"context_line":"    event_types \u003d []"},{"line_number":171,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_4744bf73","line":168,"range":{"start_line":168,"start_character":32,"end_line":168,"end_character":54},"updated":"2017-01-19 12:39:48.000000000","message":"wtf? :)\n\nI understand you want to share get_targets but that seems overstretched. Maybe do that in a common class.","commit_id":"0f22a2ddf711a71b2e741834dfe80f851c547647"}],"ceilometer/middleware.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"eeba7dc5fef1eeb191eae2aae05e18fdb7e7a146","unresolved":false,"context_lines":[{"line_number":36,"context_line":"#  cfg.CONF.magnum_control_exchange"},{"line_number":37,"context_line":"#  cfg.CONF.dns_control_exchange],"},{"line_number":38,"context_line":"OPTS \u003d ["},{"line_number":39,"context_line":"    cfg.MultiStrOpt(\u0027http_control_exchanges\u0027,"},{"line_number":40,"context_line":"                    default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027neutron\u0027, \u0027cinder\u0027, \u0027heat\u0027,"},{"line_number":41,"context_line":"                             \u0027keystone\u0027, \u0027sahara\u0027, \u0027trove\u0027, \u0027zaqar\u0027, \u0027swift\u0027,"},{"line_number":42,"context_line":"                             \u0027ceilometer\u0027, \u0027magnum\u0027, \u0027dns\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a3905b3_6630d057","line":39,"updated":"2017-01-19 15:55:34.000000000","message":"can you rename this to something more generic and deprecate this http_* name.\n\ni would just deprecate all these to be honest: https://github.com/openstack/ceilometer/blob/83d805b51e7ec96118917f1873e9e072ba8150ab/ceilometer/exchange_control.py","commit_id":"0f22a2ddf711a71b2e741834dfe80f851c547647"}],"ceilometer/notification.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"ee232cb6e740f2274536cb9e9bae71b6c69cfdc1","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                self._configure_pipeline_listener()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":368,"context_line":"class NotificationProcessBase(plugin_base.NotificationBase):"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_targets(self, conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_3978aff8","line":367,"updated":"2017-02-02 08:29:59.000000000","message":"why? nothing is declared as abstract","commit_id":"245aa00d709b3e37378cbaccc199411720dd88dc"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"01f4f30dab2b8ef6c6885996cbb6a64613b1f8ad","unresolved":false,"context_lines":[{"line_number":364,"context_line":"                self._configure_pipeline_listener()"},{"line_number":365,"context_line":""},{"line_number":366,"context_line":""},{"line_number":367,"context_line":"@six.add_metaclass(abc.ABCMeta)"},{"line_number":368,"context_line":"class NotificationProcessBase(plugin_base.NotificationBase):"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    def get_targets(self, conf):"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a461143_044b8a5a","line":367,"in_reply_to":"3a461143_3978aff8","updated":"2017-02-02 08:45:18.000000000","message":"just be inattentive. I thought make get_targets abstract, seems no need.","commit_id":"245aa00d709b3e37378cbaccc199411720dd88dc"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"456ce586fd05359b95a31f870cd3a8ffb597d30b","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               \u0027default value is 1.\u0027)"},{"line_number":82,"context_line":"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# NOTE(sileht): reading config values at loadtime won\u0027t works"},{"line_number":85,"context_line":"# we should use set_defaults at runtime to set"},{"line_number":86,"context_line":"# notification_control_exchanges to"},{"line_number":87,"context_line":"# [cfg.CONF.nova_control_exchange,"},{"line_number":88,"context_line":"#  cfg.CONF.glance_control_exchange,"},{"line_number":89,"context_line":"#  cfg.CONF.neutron_control_exchange,"},{"line_number":90,"context_line":"#  cfg.CONF.cinder_control_exchange"},{"line_number":91,"context_line":"#  cfg.CONF.heat_control_exchange"},{"line_number":92,"context_line":"#  cfg.CONF.keystone_control_exchange"},{"line_number":93,"context_line":"#  cfg.CONF.sahara_control_exchange"},{"line_number":94,"context_line":"#  cfg.CONF.trove_control_exchange"},{"line_number":95,"context_line":"#  cfg.CONF.zaqar_control_exchange"},{"line_number":96,"context_line":"#  cfg.CONF.swift_control_exchange"},{"line_number":97,"context_line":"#  cfg.CONF.ceilometer_control_exchange"},{"line_number":98,"context_line":"#  cfg.CONF.magnum_control_exchange"},{"line_number":99,"context_line":"#  cfg.CONF.dns_control_exchange],"},{"line_number":100,"context_line":"EXCHANGES_OPTS \u003d ["},{"line_number":101,"context_line":"    cfg.MultiStrOpt(\u0027notification_control_exchanges\u0027,"},{"line_number":102,"context_line":"                    default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027neutron\u0027, \u0027cinder\u0027, \u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_21878d13","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":34},"updated":"2017-02-02 13:27:17.000000000","message":"this note is irrelevant since all these are deprecated.","commit_id":"fb2bc7455aac9c049ac1afa4e8ea3c86287fda1f"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"91419ba073baa48a342564dcf0e4f5759e8d263a","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               \u0027default value is 1.\u0027)"},{"line_number":82,"context_line":"]"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"# NOTE(sileht): reading config values at loadtime won\u0027t works"},{"line_number":85,"context_line":"# we should use set_defaults at runtime to set"},{"line_number":86,"context_line":"# notification_control_exchanges to"},{"line_number":87,"context_line":"# [cfg.CONF.nova_control_exchange,"},{"line_number":88,"context_line":"#  cfg.CONF.glance_control_exchange,"},{"line_number":89,"context_line":"#  cfg.CONF.neutron_control_exchange,"},{"line_number":90,"context_line":"#  cfg.CONF.cinder_control_exchange"},{"line_number":91,"context_line":"#  cfg.CONF.heat_control_exchange"},{"line_number":92,"context_line":"#  cfg.CONF.keystone_control_exchange"},{"line_number":93,"context_line":"#  cfg.CONF.sahara_control_exchange"},{"line_number":94,"context_line":"#  cfg.CONF.trove_control_exchange"},{"line_number":95,"context_line":"#  cfg.CONF.zaqar_control_exchange"},{"line_number":96,"context_line":"#  cfg.CONF.swift_control_exchange"},{"line_number":97,"context_line":"#  cfg.CONF.ceilometer_control_exchange"},{"line_number":98,"context_line":"#  cfg.CONF.magnum_control_exchange"},{"line_number":99,"context_line":"#  cfg.CONF.dns_control_exchange],"},{"line_number":100,"context_line":"EXCHANGES_OPTS \u003d ["},{"line_number":101,"context_line":"    cfg.MultiStrOpt(\u0027notification_control_exchanges\u0027,"},{"line_number":102,"context_line":"                    default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027neutron\u0027, \u0027cinder\u0027, \u0027heat\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_42aad81a","line":99,"range":{"start_line":84,"start_character":0,"end_line":99,"end_character":34},"in_reply_to":"3a461143_21878d13","updated":"2017-02-02 14:22:28.000000000","message":"Done","commit_id":"fb2bc7455aac9c049ac1afa4e8ea3c86287fda1f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"456ce586fd05359b95a31f870cd3a8ffb597d30b","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    cfg.MultiStrOpt(\u0027notification_control_exchanges\u0027,"},{"line_number":102,"context_line":"                    default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027neutron\u0027, \u0027cinder\u0027, \u0027heat\u0027,"},{"line_number":103,"context_line":"                             \u0027keystone\u0027, \u0027sahara\u0027, \u0027trove\u0027, \u0027zaqar\u0027, \u0027swift\u0027,"},{"line_number":104,"context_line":"                             \u0027ceilometer\u0027, \u0027magnum\u0027, \u0027dns\u0027],"},{"line_number":105,"context_line":"                    help\u003d\"Exchanges name to listen for notifications.\"),"},{"line_number":106,"context_line":"]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_e1766505","line":104,"updated":"2017-02-02 13:27:17.000000000","message":"set to have deprecated_name http_control_exchanges","commit_id":"fb2bc7455aac9c049ac1afa4e8ea3c86287fda1f"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"91419ba073baa48a342564dcf0e4f5759e8d263a","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    cfg.MultiStrOpt(\u0027notification_control_exchanges\u0027,"},{"line_number":102,"context_line":"                    default\u003d[\u0027nova\u0027, \u0027glance\u0027, \u0027neutron\u0027, \u0027cinder\u0027, \u0027heat\u0027,"},{"line_number":103,"context_line":"                             \u0027keystone\u0027, \u0027sahara\u0027, \u0027trove\u0027, \u0027zaqar\u0027, \u0027swift\u0027,"},{"line_number":104,"context_line":"                             \u0027ceilometer\u0027, \u0027magnum\u0027, \u0027dns\u0027],"},{"line_number":105,"context_line":"                    help\u003d\"Exchanges name to listen for notifications.\"),"},{"line_number":106,"context_line":"]"},{"line_number":107,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a461143_2286acb9","line":104,"in_reply_to":"3a461143_e1766505","updated":"2017-02-02 14:22:28.000000000","message":"Done","commit_id":"fb2bc7455aac9c049ac1afa4e8ea3c86287fda1f"}]}