)]}'
{"ceilometer/storage/sqlalchemy/alembic/versions/b6ae66d05e3_remove_extra_indexes.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"a2134365793fc875eda6b12ab5e021d2fbc5123a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":17,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"# under the License."},{"line_number":19,"context_line":"\"\"\"Remone extra indexes"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Revision ID: b6ae66d05e3"},{"line_number":22,"context_line":"Revises: 17738166b91"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASX%2F%2F1vM%3D","line":19,"updated":"2013-08-26 14:49:11.000000000","message":"s/Remone/Remove/","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":6507,"name":"Shturm Svetlana","email":"svetlana.v.shturm@gmail.com","username":"sshturm"},"change_message_id":"e01f0d501250387c52cbc539e51b93ad01d03c74","unresolved":false,"context_lines":[{"line_number":16,"context_line":"# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the"},{"line_number":17,"context_line":"# License for the specific language governing permissions and limitations"},{"line_number":18,"context_line":"# under the License."},{"line_number":19,"context_line":"\"\"\"Remone extra indexes"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Revision ID: b6ae66d05e3"},{"line_number":22,"context_line":"Revises: 17738166b91"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8K8%3D","line":19,"in_reply_to":"AAAASX%2F%2F1vM%3D","updated":"2013-08-27 18:48:41.000000000","message":"Done","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"705b187ee1cbd206216cc78fdd373894a9990293","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    ([\u0027mysql\u0027], \u0027source\u0027, \u0027id\u0027, (\u0027id\u0027,), False, True))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def index_cleanup(engine_name, table_name, uniq_name, columns, create\u003dTrue,"},{"line_number":44,"context_line":"                  unique\u003dFalse):"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if create and engine.name in engine_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8TA%3D","line":43,"updated":"2013-08-27 18:14:37.000000000","message":"Please change engine_name to engine_names so it is clear that a list is expected. Same change in upgrade() and downgrade().","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":6507,"name":"Shturm Svetlana","email":"svetlana.v.shturm@gmail.com","username":"sshturm"},"change_message_id":"e01f0d501250387c52cbc539e51b93ad01d03c74","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    ([\u0027mysql\u0027], \u0027source\u0027, \u0027id\u0027, (\u0027id\u0027,), False, True))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"def index_cleanup(engine_name, table_name, uniq_name, columns, create\u003dTrue,"},{"line_number":44,"context_line":"                  unique\u003dFalse):"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if create and engine.name in engine_name:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8K4%3D","line":43,"in_reply_to":"AAAASn%2F%2F8TA%3D","updated":"2013-08-27 18:48:41.000000000","message":"Done","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"705b187ee1cbd206216cc78fdd373894a9990293","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def index_cleanup(engine_name, table_name, uniq_name, columns, create\u003dTrue,"},{"line_number":44,"context_line":"                  unique\u003dFalse):"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if create and engine.name in engine_name:"},{"line_number":47,"context_line":"        # We have unique constraint in postgres for `resource` table."},{"line_number":48,"context_line":"        # But it should be a simple index. So, we should delete unique key"},{"line_number":49,"context_line":"        # before index creation."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8Ss%3D","line":46,"updated":"2013-08-27 18:14:37.000000000","message":"The \"engine.name in engine_name\" test is performed in both if statements. It could be checked one time before the other if statements:\n\n  if engine.name not in engine_names:\n    return","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":6507,"name":"Shturm Svetlana","email":"svetlana.v.shturm@gmail.com","username":"sshturm"},"change_message_id":"e01f0d501250387c52cbc539e51b93ad01d03c74","unresolved":false,"context_lines":[{"line_number":43,"context_line":"def index_cleanup(engine_name, table_name, uniq_name, columns, create\u003dTrue,"},{"line_number":44,"context_line":"                  unique\u003dFalse):"},{"line_number":45,"context_line":"    engine \u003d op.get_bind().engine"},{"line_number":46,"context_line":"    if create and engine.name in engine_name:"},{"line_number":47,"context_line":"        # We have unique constraint in postgres for `resource` table."},{"line_number":48,"context_line":"        # But it should be a simple index. So, we should delete unique key"},{"line_number":49,"context_line":"        # before index creation."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8K0%3D","line":46,"in_reply_to":"AAAASn%2F%2F8Ss%3D","updated":"2013-08-27 18:48:41.000000000","message":"Done","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"705b187ee1cbd206216cc78fdd373894a9990293","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":51,"context_line":"            op.drop_constraint(uniq_name, table_name, type_\u003d\u0027unique\u0027)"},{"line_number":52,"context_line":"        op.create_index(uniq_name, table_name, columns, unique\u003dunique)"},{"line_number":53,"context_line":"    elif not create and engine.name in engine_name:"},{"line_number":54,"context_line":"        if unique:"},{"line_number":55,"context_line":"            op.drop_constraint(uniq_name, table_name, type_\u003d\u0027unique\u0027)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8Sc%3D","line":53,"updated":"2013-08-27 18:14:37.000000000","message":"This would then become \"else:\" because the only test is for create.","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"},{"author":{"_account_id":6507,"name":"Shturm Svetlana","email":"svetlana.v.shturm@gmail.com","username":"sshturm"},"change_message_id":"e01f0d501250387c52cbc539e51b93ad01d03c74","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if engine.name \u003d\u003d \u0027postgresql\u0027:"},{"line_number":51,"context_line":"            op.drop_constraint(uniq_name, table_name, type_\u003d\u0027unique\u0027)"},{"line_number":52,"context_line":"        op.create_index(uniq_name, table_name, columns, unique\u003dunique)"},{"line_number":53,"context_line":"    elif not create and engine.name in engine_name:"},{"line_number":54,"context_line":"        if unique:"},{"line_number":55,"context_line":"            op.drop_constraint(uniq_name, table_name, type_\u003d\u0027unique\u0027)"},{"line_number":56,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F8Kw%3D","line":53,"in_reply_to":"AAAASn%2F%2F8Sc%3D","updated":"2013-08-27 18:48:41.000000000","message":"Done","commit_id":"b027dad65fbcc0b5df23dc64696e6ecf99f5702d"}]}