)]}'
{"ceilometer/hardware/plugin.py":[{"author":{"_account_id":8669,"name":"Lucas Graf","email":"graflu0@students.zhaw.ch","username":"graflu0"},"change_message_id":"caf152c3008fd93ca55c6af915df3d9b1a7a8714","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        i_cache \u003d cache.setdefault(host_url.hostname, {})"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            if host_url.hostname not in i_cache:"},{"line_number":50,"context_line":"                i_cache[host_url.hostname] \u003d func(host_url)"},{"line_number":51,"context_line":"            return i_cache[host_url.hostname]"},{"line_number":52,"context_line":"        except NotImplementedError as err:"},{"line_number":53,"context_line":"            #Log NotImplementedError in severity INFO to avoid the log"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F9%2BY%3D","line":50,"updated":"2013-09-16 12:59:12.000000000","message":"\u0027i_cache[host_url.hostname] \u003d func(host_url)\u0027 causes empty disk and network samples. Use \u0027i_cache[host_url.hostname] \u003d list(func(host_url))\u0027 instead","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"32b201c2a55ec0364aaf369887400f8d234781db","unresolved":false,"context_lines":[{"line_number":47,"context_line":"        i_cache \u003d cache.setdefault(host_url.hostname, {})"},{"line_number":48,"context_line":"        try:"},{"line_number":49,"context_line":"            if host_url.hostname not in i_cache:"},{"line_number":50,"context_line":"                i_cache[host_url.hostname] \u003d func(host_url)"},{"line_number":51,"context_line":"            return i_cache[host_url.hostname]"},{"line_number":52,"context_line":"        except NotImplementedError as err:"},{"line_number":53,"context_line":"            #Log NotImplementedError in severity INFO to avoid the log"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7Pc%3D","line":50,"in_reply_to":"AAAAS3%2F%2F9%2BY%3D","updated":"2013-09-17 05:31:38.000000000","message":"Done","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                   err\u003derr))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @abc.abstractmethod"},{"line_number":76,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":77,"context_line":"        \"\"\"Generate an interable Sample from the data returned by inspector"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param host_url: host url of the endpoint"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBdg%3D","line":76,"updated":"2014-01-18 18:16:39.000000000","message":"Should that be generate_samples()?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":73,"context_line":"                                   err\u003derr))"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    @abc.abstractmethod"},{"line_number":76,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":77,"context_line":"        \"\"\"Generate an interable Sample from the data returned by inspector"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        :param host_url: host url of the endpoint"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B3%2Fs%3D","line":76,"in_reply_to":"AAAAUH%2F%2FBdg%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8019455be1858de878450ab68f30a0de0c4871ca","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        :param host_url: host url of the endpoint"},{"line_number":90,"context_line":"        :param c_data: data returned by the corresponding inspector, of"},{"line_number":91,"context_line":"                       one of the types defined in the file"},{"line_number":92,"context_line":"                       ceiloemter.hardware.inspector.base.CPUStats"},{"line_number":93,"context_line":"        \"\"\""},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def _get_inspector(self, parsed_url):"}],"source_content_type":"text/x-python","patch_set":15,"id":"AAAAUH%2F9Wjg%3D","line":92,"updated":"2014-02-07 14:51:47.000000000","message":"ceilometer","commit_id":"8209c4ec6a4c296f6d4585aaddd4596a1f3d43ae"}],"ceilometer/hardware/pollsters/cpu.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"bcd61589e0aa70323260efe1c2f886df9bdaab87","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_cpu\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            yield self._get_counter(host_url, c_data)"},{"line_number":50,"context_line":"        except Exception as err:"},{"line_number":51,"context_line":"            LOG.exception(\u0027could not get CPU time for host %s: %s\u0027,"},{"line_number":52,"context_line":"                          host_url.hostname, err)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F5PA%3D","line":50,"updated":"2013-08-28 10:08:02.000000000","message":"Just thinking: If the Inspector return NotImplementedError (like the base class for Inspect propose)  what do you thing about changing the severity in case of a NotImplementedError ?","commit_id":"e792db9d01257c44b5acbae1baa161585171c9fd"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"759ced74d7e42a90d741e7325c913e6fd30fb581","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_cpu\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            yield self._get_counter(host_url, c_data)"},{"line_number":50,"context_line":"        except Exception as err:"},{"line_number":51,"context_line":"            LOG.exception(\u0027could not get CPU time for host %s: %s\u0027,"},{"line_number":52,"context_line":"                          host_url.hostname, err)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F0Ls%3D","line":50,"in_reply_to":"AAAASn%2F%2F0rs%3D","updated":"2013-08-29 07:58:10.000000000","message":"ok, I\u0027ll handle the NotImplementedError in the base _populate_cache() method with severity level INFO.","commit_id":"e792db9d01257c44b5acbae1baa161585171c9fd"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"b7a675c84e72da42720a4d5487bc3ac02540bfae","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_cpu\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            yield self._get_counter(host_url, c_data)"},{"line_number":50,"context_line":"        except Exception as err:"},{"line_number":51,"context_line":"            LOG.exception(\u0027could not get CPU time for host %s: %s\u0027,"},{"line_number":52,"context_line":"                          host_url.hostname, err)"},{"line_number":53,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAASn%2F%2F0rs%3D","line":50,"in_reply_to":"AAAASn%2F%2F5PA%3D","updated":"2013-08-29 04:54:06.000000000","message":"@Mehdi,\n\nWhich severity for NotImplementedError do you suggest? Just wondering any other things need to be done besides the LOG in case of NotImplementedError.","commit_id":"e792db9d01257c44b5acbae1baa161585171c9fd"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    CACHE_KEY_CPU \u003d \u0027cpu\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtNI%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"_get_sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    CACHE_KEY_CPU \u003d \u0027cpu\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FowE%3D","line":37,"in_reply_to":"AAAASn%2F%2FtNI%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"},{"line_number":41,"context_line":"        h_cache \u003d cache.setdefault(self.CACHE_KEY_CPU, {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtNE%3D","line":38,"updated":"2013-08-30 17:10:29.000000000","message":"s/Counter/Sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"},{"line_number":41,"context_line":"        h_cache \u003d cache.setdefault(self.CACHE_KEY_CPU, {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FowA%3D","line":38,"in_reply_to":"AAAASn%2F%2FtNE%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":56,"context_line":"class CPUUtil1MinPollster(_Base):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @staticmethod"},{"line_number":59,"context_line":"    def _get_counter(host, c_data):"},{"line_number":60,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":61,"context_line":"                                           name\u003d\u0027cpu.util.1min\u0027,"},{"line_number":62,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtMY%3D","line":59,"updated":"2013-08-30 17:10:29.000000000","message":"_get_sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":56,"context_line":"class CPUUtil1MinPollster(_Base):"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    @staticmethod"},{"line_number":59,"context_line":"    def _get_counter(host, c_data):"},{"line_number":60,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":61,"context_line":"                                           name\u003d\u0027cpu.util.1min\u0027,"},{"line_number":62,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fov8%3D","line":59,"in_reply_to":"AAAASn%2F%2FtMY%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":68,"context_line":"class CPUUtil5MinPollster(_Base):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @staticmethod"},{"line_number":71,"context_line":"    def _get_counter(host, c_data):"},{"line_number":72,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":73,"context_line":"                                           name\u003d\u0027cpu.util.5min\u0027,"},{"line_number":74,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtMI%3D","line":71,"updated":"2013-08-30 17:10:29.000000000","message":"_get_sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":68,"context_line":"class CPUUtil5MinPollster(_Base):"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @staticmethod"},{"line_number":71,"context_line":"    def _get_counter(host, c_data):"},{"line_number":72,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":73,"context_line":"                                           name\u003d\u0027cpu.util.5min\u0027,"},{"line_number":74,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fov4%3D","line":71,"in_reply_to":"AAAASn%2F%2FtMI%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class CPUUtil15MinPollster(_Base):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @staticmethod"},{"line_number":83,"context_line":"    def _get_counter(host, c_data):"},{"line_number":84,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":85,"context_line":"                                           name\u003d\u0027cpu.util.15min\u0027,"},{"line_number":86,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtMM%3D","line":83,"updated":"2013-08-30 17:10:29.000000000","message":"_get_sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":80,"context_line":"class CPUUtil15MinPollster(_Base):"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    @staticmethod"},{"line_number":83,"context_line":"    def _get_counter(host, c_data):"},{"line_number":84,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":85,"context_line":"                                           name\u003d\u0027cpu.util.15min\u0027,"},{"line_number":86,"context_line":"                                           type\u003dsample.TYPE_GAUGE,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fov0%3D","line":83,"in_reply_to":"AAAASn%2F%2FtMM%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":8669,"name":"Lucas Graf","email":"graflu0@students.zhaw.ch","username":"graflu0"},"change_message_id":"caf152c3008fd93ca55c6af915df3d9b1a7a8714","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_cpu\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            if c_data:"},{"line_number":50,"context_line":"                yield self._get_sample(host_url, c_data)"},{"line_number":51,"context_line":"        except Exception as err:"},{"line_number":52,"context_line":"            LOG.exception(\u0027could not get CPU time for host %s: %s\u0027,"},{"line_number":53,"context_line":"                          host_url.hostname, err)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F97c%3D","line":50,"updated":"2013-09-16 12:59:12.000000000","message":"instead of \u0027yield self._get_sample(host_url, c_data)\u0027 use a for loop and a yield:\nfor cpu_stats in c_data:\n                    yield self._get_sample(host_url, cpu_stats)\nthis is caused by changes in snmp.py","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"32b201c2a55ec0364aaf369887400f8d234781db","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_cpu\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            if c_data:"},{"line_number":50,"context_line":"                yield self._get_sample(host_url, c_data)"},{"line_number":51,"context_line":"        except Exception as err:"},{"line_number":52,"context_line":"            LOG.exception(\u0027could not get CPU time for host %s: %s\u0027,"},{"line_number":53,"context_line":"                          host_url.hostname, err)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7PU%3D","line":50,"in_reply_to":"AAAAS3%2F%2F97c%3D","updated":"2013-09-17 05:31:38.000000000","message":"Done","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def _get_sample(host, c_data):"},{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBcg%3D","line":39,"updated":"2014-01-18 18:16:39.000000000","message":"What type is the c_data argument?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    @abc.abstractmethod"},{"line_number":38,"context_line":"    def _get_sample(host, c_data):"},{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B3%2B0%3D","line":39,"in_reply_to":"AAAAUH%2F%2FBcg%3D","updated":"2014-01-21 08:29:04.000000000","message":"ceiloemter.hardware.inspector.base.CPUStats","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"},{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBdY%3D","line":42,"updated":"2014-01-18 18:16:39.000000000","message":"How about a generator expression, to avoid looping in python?\n\n  return (self._get_sample(host_url, c_data) for c_data in data)","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"},{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B3%2Bw%3D","line":42,"in_reply_to":"AAAAUH%2F%2FBdY%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class CPUUtil1MinPollster(_Base):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _get_sample(host, c_data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBdU%3D","line":46,"updated":"2014-01-18 18:16:39.000000000","message":"Do we need separate pollsters for the different time periods? We don\u0027t treat other data sources this way.","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"class CPUUtil1MinPollster(_Base):"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _get_sample(host, c_data):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B3%2BU%3D","line":46,"in_reply_to":"AAAAUH%2F%2FBdU%3D","updated":"2014-01-21 08:29:04.000000000","message":"Doesn\u0027t we have a guild line about one pollster one meter?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"}],"ceilometer/hardware/pollsters/disk.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    CACHE_KEY_DISK \u003d \u0027disk\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @abc.abstractmethod"},{"line_number":45,"context_line":"    def _get_counter(host, disk, info):"},{"line_number":46,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtCA%3D","line":45,"updated":"2013-08-30 17:10:29.000000000","message":"sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":42,"context_line":"    CACHE_KEY_DISK \u003d \u0027disk\u0027"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    @abc.abstractmethod"},{"line_number":45,"context_line":"    def _get_counter(host, disk, info):"},{"line_number":46,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FovI%3D","line":45,"in_reply_to":"AAAASn%2F%2FtCA%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":53,"context_line":"        for disk, info in data:"},{"line_number":54,"context_line":"            LOG.info(self.DISKSPACE_USAGE_MESSAGE,"},{"line_number":55,"context_line":"                     host_url.hostname, info.size,"},{"line_number":56,"context_line":"                     info.used, disk.device, disk.path)"},{"line_number":57,"context_line":"            yield self._get_sample(host_url, disk, info)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBdM%3D","line":54,"updated":"2014-01-18 18:16:39.000000000","message":"This logging is probably too verbose.\n\nSee the comment in the previous file about using a generator expression.","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":53,"context_line":"        for disk, info in data:"},{"line_number":54,"context_line":"            LOG.info(self.DISKSPACE_USAGE_MESSAGE,"},{"line_number":55,"context_line":"                     host_url.hostname, info.size,"},{"line_number":56,"context_line":"                     info.used, disk.device, disk.path)"},{"line_number":57,"context_line":"            yield self._get_sample(host_url, disk, info)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B3%2BI%3D","line":54,"in_reply_to":"AAAAUH%2F%2FBdM%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"}],"ceilometer/hardware/pollsters/memory.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    CACHE_KEY_MEMORY \u003d \u0027memory\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtC8%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"sample","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    CACHE_KEY_MEMORY \u003d \u0027memory\u0027"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    @abc.abstractmethod"},{"line_number":37,"context_line":"    def _get_counter(host, c_data):"},{"line_number":38,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FovE%3D","line":37,"in_reply_to":"AAAASn%2F%2FtC8%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":8669,"name":"Lucas Graf","email":"graflu0@students.zhaw.ch","username":"graflu0"},"change_message_id":"caf152c3008fd93ca55c6af915df3d9b1a7a8714","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_memoryspace\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            if c_data:"},{"line_number":50,"context_line":"                yield self._get_sample(host_url, c_data)"},{"line_number":51,"context_line":"        except Exception as err:"},{"line_number":52,"context_line":"            LOG.exception(\u0027could not get memory usage for host %s: %s\u0027,"},{"line_number":53,"context_line":"                          host_url.hostname, err)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F970%3D","line":50,"updated":"2013-09-16 12:59:12.000000000","message":"instead of \u0027yield self._get_sample(host_url, c_data)\u0027 use a for loop and a yield:\nfor memory_stats in c_data:\n                    yield self._get_sample(host_url, memory_stats)\nthis is caused by changes in snmp.py","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"32b201c2a55ec0364aaf369887400f8d234781db","unresolved":false,"context_lines":[{"line_number":47,"context_line":"                \u0027inspect_memoryspace\u0027,"},{"line_number":48,"context_line":"            )"},{"line_number":49,"context_line":"            if c_data:"},{"line_number":50,"context_line":"                yield self._get_sample(host_url, c_data)"},{"line_number":51,"context_line":"        except Exception as err:"},{"line_number":52,"context_line":"            LOG.exception(\u0027could not get memory usage for host %s: %s\u0027,"},{"line_number":53,"context_line":"                          host_url.hostname, err)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAS3%2F%2F7PI%3D","line":50,"in_reply_to":"AAAAS3%2F%2F970%3D","updated":"2013-09-17 05:31:38.000000000","message":"Done","commit_id":"054a98b28bb1f3b9460c773c2f6d3de6fb18c042"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _get_sample(host, c_data):"},{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"},{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBdI%3D","line":41,"updated":"2014-01-18 18:16:39.000000000","message":"This is the third subclass of HardwarePollster that follows this pattern. I think we need to either think about the design of HardwarePollster itself, or add another base class in the same module instead of redefining the looping logic in every module.","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"    def _get_sample(host, c_data):"},{"line_number":39,"context_line":"        \"\"\"Return one Sample.\"\"\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":42,"context_line":"        for c_data in data:"},{"line_number":43,"context_line":"            yield self._get_sample(host_url, c_data)"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B37w%3D","line":41,"in_reply_to":"AAAAUH%2F%2FBdI%3D","updated":"2014-01-21 08:29:04.000000000","message":"I\u0027ll move it to the base pollster class. Thanks for the advice","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"166799d36b390c81773eb880bd3e045a2acfe1f6","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _get_sample(host, c_data):"},{"line_number":50,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":51,"context_line":"                                          name\u003d\u0027memory.size.total\u0027,"},{"line_number":52,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":53,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":54,"context_line":"                                          volume\u003dc_data.total,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FGgQ%3D","line":51,"updated":"2014-01-17 12:51:50.000000000","message":"Is the size implicit here?\n\ni.e. would \u0027memory.total\u0027 work better?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":48,"context_line":"    @staticmethod"},{"line_number":49,"context_line":"    def _get_sample(host, c_data):"},{"line_number":50,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":51,"context_line":"                                          name\u003d\u0027memory.size.total\u0027,"},{"line_number":52,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":53,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":54,"context_line":"                                          volume\u003dc_data.total,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B378%3D","line":51,"in_reply_to":"AAAAUH%2F%2FGgQ%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"166799d36b390c81773eb880bd3e045a2acfe1f6","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":51,"context_line":"                                          name\u003d\u0027memory.size.total\u0027,"},{"line_number":52,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":53,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":54,"context_line":"                                          volume\u003dc_data.total,"},{"line_number":55,"context_line":"                                          )"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FGgA%3D","line":53,"updated":"2014-01-17 12:51:50.000000000","message":"The unit used for the existing memory meter is MB as opposed to B.\n\nWould it be a good idea to make these consistent?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"166799d36b390c81773eb880bd3e045a2acfe1f6","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def _get_sample(host, c_data):"},{"line_number":62,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":63,"context_line":"                                          name\u003d\u0027memory.size.used\u0027,"},{"line_number":64,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":65,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":66,"context_line":"                                          volume\u003dc_data.used,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FGf8%3D","line":63,"updated":"2014-01-17 12:51:50.000000000","message":"Similarly, maybe \u0027memory.used\u0027 would suffice?","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"    @staticmethod"},{"line_number":61,"context_line":"    def _get_sample(host, c_data):"},{"line_number":62,"context_line":"        return util.make_sample_from_host(host,"},{"line_number":63,"context_line":"                                          name\u003d\u0027memory.size.used\u0027,"},{"line_number":64,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":65,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":66,"context_line":"                                          volume\u003dc_data.used,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B374%3D","line":63,"in_reply_to":"AAAAUH%2F%2FGf8%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"166799d36b390c81773eb880bd3e045a2acfe1f6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                          name\u003d\u0027memory.size.used\u0027,"},{"line_number":64,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":65,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":66,"context_line":"                                          volume\u003dc_data.used,"},{"line_number":67,"context_line":"                                          )"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FGfs%3D","line":66,"updated":"2014-01-17 12:51:50.000000000","message":"How about?\n\n -                                        unit\u003d\u0027B\u0027,\n -                                        volume\u003dc_data.used,\n +                                        unit\u003d\u0027MB\u0027,\n +                                        volume\u003dc_data.used / (1024*1024),","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                                          name\u003d\u0027memory.size.used\u0027,"},{"line_number":64,"context_line":"                                          type\u003dsample.TYPE_GAUGE,"},{"line_number":65,"context_line":"                                          unit\u003d\u0027B\u0027,"},{"line_number":66,"context_line":"                                          volume\u003dc_data.used,"},{"line_number":67,"context_line":"                                          )"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBc8%3D","line":66,"in_reply_to":"AAAAUH%2F%2FGfs%3D","updated":"2014-01-18 18:16:39.000000000","message":"We generally try to report the data with as much granularity as it was given to us. That said, it seems unlikely to be useful to report on RAM smaller than 1 MB. :-)","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"}],"ceilometer/hardware/pollsters/net.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    CACHE_KEY_NIC \u003d \u0027nic\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @abc.abstractmethod"},{"line_number":42,"context_line":"    def _get_counter(host, nic, info):"},{"line_number":43,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtL4%3D","line":42,"updated":"2013-08-30 17:10:29.000000000","message":"_get_sample... same for below","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    CACHE_KEY_NIC \u003d \u0027nic\u0027"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    @abc.abstractmethod"},{"line_number":42,"context_line":"    def _get_counter(host, nic, info):"},{"line_number":43,"context_line":"        \"\"\"Return one Counter.\"\"\""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    def get_samples(self, manager, cache, host_url):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FovA%3D","line":42,"in_reply_to":"AAAASn%2F%2FtL4%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _get_counter(host, nic, info):"},{"line_number":81,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":82,"context_line":"                                           name\u003d\u0027network.incoming.bytes\u0027,"},{"line_number":83,"context_line":"                                           type\u003dsample.TYPE_CUMULATIVE,"},{"line_number":84,"context_line":"                                           unit\u003d\u0027B\u0027,"},{"line_number":85,"context_line":"                                           volume\u003dinfo.rx_bytes,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtDE%3D","line":82,"updated":"2013-08-30 17:10:29.000000000","message":"same name as hypervisor stat, do we expect users to filter between hardware and hypervisor stat based on source/resource_id?","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":79,"context_line":"    @staticmethod"},{"line_number":80,"context_line":"    def _get_counter(host, nic, info):"},{"line_number":81,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":82,"context_line":"                                           name\u003d\u0027network.incoming.bytes\u0027,"},{"line_number":83,"context_line":"                                           type\u003dsample.TYPE_CUMULATIVE,"},{"line_number":84,"context_line":"                                           unit\u003d\u0027B\u0027,"},{"line_number":85,"context_line":"                                           volume\u003dinfo.rx_bytes,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fouk%3D","line":82,"in_reply_to":"AAAASn%2F%2FtDE%3D","updated":"2013-09-02 03:39:10.000000000","message":"Yes. They\u0027re meaning the quite the same thing, but for different resources, one for VM instance, and one for the physical hardware.","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":92,"context_line":"    @staticmethod"},{"line_number":93,"context_line":"    def _get_counter(host, nic, info):"},{"line_number":94,"context_line":"        return util.make_counter_from_host(host,"},{"line_number":95,"context_line":"                                           name\u003d\u0027network.outgoing.bytes\u0027,"},{"line_number":96,"context_line":"                                           type\u003dsample.TYPE_CUMULATIVE,"},{"line_number":97,"context_line":"                                           unit\u003d\u0027B\u0027,"},{"line_number":98,"context_line":"                                           volume\u003dinfo.tx_bytes,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtDA%3D","line":95,"updated":"2013-08-30 17:10:29.000000000","message":"same as above","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":50,"context_line":"        for nic, info in data:"},{"line_number":51,"context_line":"            LOG.info(self.NET_USAGE_MESSAGE, host_url.hostname,"},{"line_number":52,"context_line":"                     nic.name, info.rx_bytes, info.tx_bytes)"},{"line_number":53,"context_line":"            yield self._get_sample(host_url, nic, info)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBco%3D","line":51,"updated":"2014-01-18 18:16:39.000000000","message":"Logging too verbosely.","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":48,"context_line":""},{"line_number":49,"context_line":"    def generator_samples(self, host_url, data):"},{"line_number":50,"context_line":"        for nic, info in data:"},{"line_number":51,"context_line":"            LOG.info(self.NET_USAGE_MESSAGE, host_url.hostname,"},{"line_number":52,"context_line":"                     nic.name, info.rx_bytes, info.tx_bytes)"},{"line_number":53,"context_line":"            yield self._get_sample(host_url, nic, info)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B37k%3D","line":51,"in_reply_to":"AAAAUH%2F%2FBco%3D","updated":"2014-01-21 08:29:04.000000000","message":"Done","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"}],"ceilometer/hardware/pollsters/util.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_counter_from_host(host_url, name, type, unit, volume,"},{"line_number":34,"context_line":"                           res_metadata\u003dNone):"},{"line_number":35,"context_line":"    resource_metadata \u003d dict()"},{"line_number":36,"context_line":"    if(res_metadata is not None):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtLs%3D","line":33,"updated":"2013-08-30 17:10:29.000000000","message":"make_sample_from_host","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    return {\u0027resource_url\u0027: urlparse.urlunsplit(host_url)}"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"def make_counter_from_host(host_url, name, type, unit, volume,"},{"line_number":34,"context_line":"                           res_metadata\u003dNone):"},{"line_number":35,"context_line":"    resource_metadata \u003d dict()"},{"line_number":36,"context_line":"    if(res_metadata is not None):"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fovo%3D","line":33,"in_reply_to":"AAAASn%2F%2FtLs%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def make_counter_from_host(host_url, name, type, unit, volume,"},{"line_number":34,"context_line":"                           res_metadata\u003dNone):"},{"line_number":35,"context_line":"    resource_metadata \u003d dict()"},{"line_number":36,"context_line":"    if(res_metadata is not None):"},{"line_number":37,"context_line":"        metadata \u003d copy.copy(res_metadata)"},{"line_number":38,"context_line":"        resource_metadata \u003d dict(zip(metadata._fields, metadata))"},{"line_number":39,"context_line":"    resource_metadata.update(get_metadata_from_host(host_url))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtK0%3D","line":36,"updated":"2013-08-30 17:10:29.000000000","message":"remove the parentheses","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":33,"context_line":"def make_counter_from_host(host_url, name, type, unit, volume,"},{"line_number":34,"context_line":"                           res_metadata\u003dNone):"},{"line_number":35,"context_line":"    resource_metadata \u003d dict()"},{"line_number":36,"context_line":"    if(res_metadata is not None):"},{"line_number":37,"context_line":"        metadata \u003d copy.copy(res_metadata)"},{"line_number":38,"context_line":"        resource_metadata \u003d dict(zip(metadata._fields, metadata))"},{"line_number":39,"context_line":"    resource_metadata.update(get_metadata_from_host(host_url))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2Fovk%3D","line":36,"in_reply_to":"AAAASn%2F%2FtK0%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"166799d36b390c81773eb880bd3e045a2acfe1f6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        unit\u003dunit,"},{"line_number":45,"context_line":"        volume\u003dvolume,"},{"line_number":46,"context_line":"        user_id\u003dNone,"},{"line_number":47,"context_line":"        project_id\u003dNone,"},{"line_number":48,"context_line":"        resource_id\u003dhost_url.hostname,"},{"line_number":49,"context_line":"        timestamp\u003dtimeutils.isotime(),"},{"line_number":50,"context_line":"        resource_metadata\u003dresource_metadata,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FGdA%3D","line":47,"updated":"2014-01-17 12:51:50.000000000","message":"Say in the case of a nova_bm or ironic node that\u0027s being monitored via this SNMP agent, would it still make sense for the user and project IDs to be left unset?\n\n(I\u0027m not even sure if such an admin user is identifiable via the ironic API)","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5e6de390130643331e8fedb7988a6dfba6e46b0d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        unit\u003dunit,"},{"line_number":45,"context_line":"        volume\u003dvolume,"},{"line_number":46,"context_line":"        user_id\u003dNone,"},{"line_number":47,"context_line":"        project_id\u003dNone,"},{"line_number":48,"context_line":"        resource_id\u003dhost_url.hostname,"},{"line_number":49,"context_line":"        timestamp\u003dtimeutils.isotime(),"},{"line_number":50,"context_line":"        resource_metadata\u003dresource_metadata,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2B34s%3D","line":47,"in_reply_to":"AAAAUH%2F%2FBcY%3D","updated":"2014-01-21 08:29:04.000000000","message":"This is for physical device, it may or may not be managed by Ironic. For non-ironic devices, we don\u0027t know the project_id at all. However, I\u0027ll make project_id/user_id as parameter, but let the default to be None","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"},{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"6e8b077523c3c822428af5e9517d5e01e82c599d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        unit\u003dunit,"},{"line_number":45,"context_line":"        volume\u003dvolume,"},{"line_number":46,"context_line":"        user_id\u003dNone,"},{"line_number":47,"context_line":"        project_id\u003dNone,"},{"line_number":48,"context_line":"        resource_id\u003dhost_url.hostname,"},{"line_number":49,"context_line":"        timestamp\u003dtimeutils.isotime(),"},{"line_number":50,"context_line":"        resource_metadata\u003dresource_metadata,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAUH%2F%2FBcY%3D","line":47,"in_reply_to":"AAAAUH%2F%2FGdA%3D","updated":"2014-01-18 18:16:39.000000000","message":"Without a project id set the data can only be used by an admin user, because the incoming query for another user will have their project id added by the policy code in v2.py. Maybe that\u0027s OK for bare metal stats? Will it work with the alarm code, though? I don\u0027t know if project ownership is automatically enforced there.","commit_id":"b4d293ae6cddc09456475f080e4a564775de0681"}],"etc/ceilometer/pipeline.yaml":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"790a44552e18bd98f1fd10e985a5ca5aaac3f350","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    meters:"},{"line_number":6,"context_line":"        - \"*\""},{"line_number":7,"context_line":"    resources:"},{"line_number":8,"context_line":"#       - snmp://localhost"},{"line_number":9,"context_line":"    transformers:"},{"line_number":10,"context_line":"    publishers:"},{"line_number":11,"context_line":"        - rpc://"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"AAAAUH%2F%2FOec%3D","line":8,"updated":"2014-01-16 06:48:57.000000000","message":"nit: not sure a example should be provided yet, the code is just base class for futur pollster currently.","commit_id":"676b5d5d322afb2ff62a4e91ce32ddf7cf933ce4"}],"setup.cfg":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"71d65a8d4beb1ddcb8af3e687e867b4656eb713b","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ceilometer.poll.hardware \u003d"},{"line_number":69,"context_line":"    cpu_util_1_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil1MinPollster"},{"line_number":70,"context_line":"    cpu_util_5_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil5MinPollster"},{"line_number":71,"context_line":"    cpu_util_15_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil15MinPollster"},{"line_number":72,"context_line":"    disk.size.total \u003d ceilometer.hardware.pollsters.disk:DiskTotalPollster"},{"line_number":73,"context_line":"    disk.size.used \u003d ceilometer.hardware.pollsters.disk:DiskUsedPollster"},{"line_number":74,"context_line":"    network.bandwidth.bytes \u003d ceilometer.hardware.pollsters.net:BandwidthBytesPollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"AAAASn%2F%2FvOU%3D","line":71,"updated":"2013-08-30 06:50:13.000000000","message":"Why does cpu pollster names are not dotted ?","commit_id":"d6890d604e745aa4b26d8fb3ba6a5531383ea862"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1a68221d670535e04e2f02bd38d4a910d357521d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"ceilometer.poll.hardware \u003d"},{"line_number":69,"context_line":"    cpu_util_1_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil1MinPollster"},{"line_number":70,"context_line":"    cpu_util_5_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil5MinPollster"},{"line_number":71,"context_line":"    cpu_util_15_min \u003d ceilometer.hardware.pollsters.cpu:CPUUtil15MinPollster"},{"line_number":72,"context_line":"    disk.size.total \u003d ceilometer.hardware.pollsters.disk:DiskTotalPollster"},{"line_number":73,"context_line":"    disk.size.used \u003d ceilometer.hardware.pollsters.disk:DiskUsedPollster"},{"line_number":74,"context_line":"    network.bandwidth.bytes \u003d ceilometer.hardware.pollsters.net:BandwidthBytesPollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":7,"id":"AAAASn%2F%2FvKM%3D","line":71,"in_reply_to":"AAAASn%2F%2FvOU%3D","updated":"2013-08-30 07:11:44.000000000","message":"my bad, i\u0027ll change that","commit_id":"d6890d604e745aa4b26d8fb3ba6a5531383ea862"}],"tests/hardware/pollsters/test_cpu.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestCPUPollsters(base.TestPollsterBase):"},{"line_number":28,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":29,"context_line":"    def _check_get_samples(self, factory, name, expected):"},{"line_number":30,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":31,"context_line":"        mgr.load_inspector(self.host)"},{"line_number":32,"context_line":"        pollster \u003d factory()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtGQ%3D","line":29,"updated":"2013-08-30 17:10:29.000000000","message":"most of this is the same across all the test files, maybe add this to base and share the code.","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"class TestCPUPollsters(base.TestPollsterBase):"},{"line_number":28,"context_line":"    @mock.patch(\u0027ceilometer.pipeline.setup_pipeline\u0027, mock.MagicMock())"},{"line_number":29,"context_line":"    def _check_get_samples(self, factory, name, expected):"},{"line_number":30,"context_line":"        mgr \u003d manager.AgentManager()"},{"line_number":31,"context_line":"        mgr.load_inspector(self.host)"},{"line_number":32,"context_line":"        pollster \u003d factory()"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FosY%3D","line":29,"in_reply_to":"AAAASn%2F%2FtGQ%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        assert pollster.CACHE_KEY_CPU in cache"},{"line_number":38,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_CPU]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(set([s.name for s in samples]),"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtI8%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"self.assertIn","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        assert pollster.CACHE_KEY_CPU in cache"},{"line_number":38,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_CPU]"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"        self.assertEqual(set([s.name for s in samples]),"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FosU%3D","line":37,"in_reply_to":"AAAASn%2F%2FtI8%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"}],"tests/hardware/pollsters/test_disk.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_DISK in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_DISK]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtHg%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"self.assertIn","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_DISK in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_DISK]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FosQ%3D","line":37,"in_reply_to":"AAAASn%2F%2FtHg%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"}],"tests/hardware/pollsters/test_memory.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_MEMORY in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_MEMORY]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtHc%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"self.assertIn","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_MEMORY in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_MEMORY]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FosM%3D","line":37,"in_reply_to":"AAAASn%2F%2FtHc%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"}],"tests/hardware/pollsters/test_net.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"371527de63ae5ee341965ab6e0535fd972d1b3aa","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_NIC in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_NIC]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FtHM%3D","line":37,"updated":"2013-08-30 17:10:29.000000000","message":"self.assertIn","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"9458423c15608892a2fdfc000dd28fa7ada466af","unresolved":false,"context_lines":[{"line_number":34,"context_line":"        samples \u003d list(pollster.get_samples(mgr, cache, self.host))"},{"line_number":35,"context_line":"        assert samples"},{"line_number":36,"context_line":"        assert pollster.CACHE_KEY_NIC in cache"},{"line_number":37,"context_line":"        assert self.host.hostname in cache[pollster.CACHE_KEY_NIC]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"        self.assertEqual(set([s.name for s in samples]),"},{"line_number":40,"context_line":"                         set([name]))"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAASn%2F%2FosI%3D","line":37,"in_reply_to":"AAAASn%2F%2FtHM%3D","updated":"2013-09-02 03:39:10.000000000","message":"Done","commit_id":"5c4593bfba09830fa4b2a0d4adc81138ef84f7c6"}]}