)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"19ef332788b16265914f92747e16413f366e43b8","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Network: process metering reports from Neutron"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"blueprint https://blueprints.launchpad.net/ceilometer/+spec/ceilometer-quantum-bw-metering"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Change-Id: Idbcc5843e1840ff2659a58d991f4256f56c93a4d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAASn%2F%2FeP4%3D","line":9,"updated":"2013-09-04 12:20:54.000000000","message":"this should probably be:\nblueprint ceilometer-quantum-bw-metering","commit_id":"3636a044a6ec04eea4ace7cbb3b377d2f412598e"}],"ceilometer/network/notifications.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"80a9d2375989ce04b19ba8f4d75dd753da8abf50","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2F8jQ%3D","line":152,"updated":"2013-08-27 17:13:28.000000000","message":"If that\u0027s the name of the event in neutron, we should try to get them to use something more descriptive. \"metering\" could be measuring anything and \"report\" is redundant.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cfb6cc4deffabec19e28e087281c4ef2edb04b16","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FusQ%3D","line":152,"in_reply_to":"AAAASn%2F%2F5d4%3D","updated":"2013-08-30 10:13:39.000000000","message":"l3.meter or something sounds better indeed","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"a7f51f216a1776c845ff1be885131d074e611173","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2F5d4%3D","line":152,"in_reply_to":"AAAASn%2F%2F6ds%3D","updated":"2013-08-28 08:56:04.000000000","message":"since I\u0027m in charge of the neutron side of the metering, I can change it. what do you think of \"l3_meter\" ?","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6676443fa34afb8893290bc677ec3fc89ceb65f3","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2F6ds%3D","line":152,"in_reply_to":"AAAASn%2F%2F8jQ%3D","updated":"2013-08-28 02:37:31.000000000","message":"agreed.\n\nalso, does this needs to be a property? does a standard list clash with the inherited property?","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"95a8cca312addcd78fee75785a23130085712730","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fs%2FM%3D","line":152,"in_reply_to":"AAAASn%2F%2FuqA%3D","updated":"2013-08-30 17:25:22.000000000","message":"A new patch set has been submitted with l3.meter","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ff9f4c28ca177aa93a7b4330c21f9c36985f28e1","unresolved":false,"context_lines":[{"line_number":149,"context_line":"    \"\"\""},{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027metering.report\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FuqA%3D","line":152,"in_reply_to":"AAAASn%2F%2FusQ%3D","updated":"2013-08-30 10:28:44.000000000","message":"OK, I\u0027ll use that. Sylvain, could you make the appropriate changes on your side ?","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"71e05ab0835ffbf5b989338f3b1e7d54351ba36f","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("},{"line_number":156,"context_line":"            name\u003d\u0027bandwidth\u0027,"},{"line_number":157,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":158,"context_line":"            unit\u003d\u0027bytes\u0027,"},{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Furw%3D","line":156,"updated":"2013-08-30 10:15:51.000000000","message":"Why don\u0027t we have incoming and outgoing bytes?","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"007be19bd397dc726adb4edf996371e213d20f7c","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("},{"line_number":156,"context_line":"            name\u003d\u0027bandwidth\u0027,"},{"line_number":157,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":158,"context_line":"            unit\u003d\u0027bytes\u0027,"},{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FupE%3D","line":156,"in_reply_to":"AAAASn%2F%2Fup4%3D","updated":"2013-08-30 10:31:30.000000000","message":"Yeah that\u0027s more a question towards Sylvain","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"62dc058c401f158ebf7081f15d72521fa57d912b","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("},{"line_number":156,"context_line":"            name\u003d\u0027bandwidth\u0027,"},{"line_number":157,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":158,"context_line":"            unit\u003d\u0027bytes\u0027,"},{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FoBk%3D","line":156,"in_reply_to":"AAAASn%2F%2FupE%3D","updated":"2013-09-02 09:23:07.000000000","message":"Each direction incoming/outgoing is associated to one label rule, so if the operator/admin wants to get both directions separately, he have to set up two labels, then two notifications will be published.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ff9f4c28ca177aa93a7b4330c21f9c36985f28e1","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("},{"line_number":156,"context_line":"            name\u003d\u0027bandwidth\u0027,"},{"line_number":157,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":158,"context_line":"            unit\u003d\u0027bytes\u0027,"},{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fup4%3D","line":156,"in_reply_to":"AAAASn%2F%2Furw%3D","updated":"2013-08-30 10:28:44.000000000","message":"Do I have any way of knowing whether the reports are about incoming/outgoing bytes ? I might have missed a field, but I think the only thing I get from Neutron\u0027s report is the number of bytes.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"71e05ab0835ffbf5b989338f3b1e7d54351ba36f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"},{"line_number":160,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":161,"context_line":"            project_id\u003dmessage[\u0027_context_project_id\u0027],"},{"line_number":162,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027label_id\u0027],"},{"line_number":163,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fur4%3D","line":162,"updated":"2013-08-30 10:15:51.000000000","message":"Note that in the sample in the tests, project and user are None, this looks like it won\u0027t be very useful.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"007be19bd397dc726adb4edf996371e213d20f7c","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"},{"line_number":160,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":161,"context_line":"            project_id\u003dmessage[\u0027_context_project_id\u0027],"},{"line_number":162,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027label_id\u0027],"},{"line_number":163,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FupA%3D","line":162,"in_reply_to":"AAAASn%2F%2Fup0%3D","updated":"2013-08-30 10:31:30.000000000","message":"Do so, I hope Sylvain can help us here.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":7141,"name":"Sylvain Afchain","email":"safchain@redhat.com","username":"sylvainA"},"change_message_id":"95a8cca312addcd78fee75785a23130085712730","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"},{"line_number":160,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":161,"context_line":"            project_id\u003dmessage[\u0027_context_project_id\u0027],"},{"line_number":162,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027label_id\u0027],"},{"line_number":163,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fs%2Bg%3D","line":162,"in_reply_to":"AAAASn%2F%2FupA%3D","updated":"2013-08-30 17:25:22.000000000","message":"The last patch set publish the \u0027tenant_id\u0027 in the payload.","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"ff9f4c28ca177aa93a7b4330c21f9c36985f28e1","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"},{"line_number":160,"context_line":"            user_id\u003dmessage[\u0027_context_user_id\u0027],"},{"line_number":161,"context_line":"            project_id\u003dmessage[\u0027_context_project_id\u0027],"},{"line_number":162,"context_line":"            resource_id\u003dmessage[\u0027payload\u0027][\u0027label_id\u0027],"},{"line_number":163,"context_line":"            message\u003dmessage)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fup0%3D","line":162,"in_reply_to":"AAAASn%2F%2Fur4%3D","updated":"2013-08-30 10:28:44.000000000","message":"Yes, the project and user are None in Neutron\u0027s reports. I could probably use \"None\" directly here :)","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c3bccd7b5d1e7f61adefa6b46a67da897d07bdd4","unresolved":false,"context_lines":[{"line_number":150,"context_line":"    @property"},{"line_number":151,"context_line":"    def event_types(self):"},{"line_number":152,"context_line":"        return [\u0027l3.meter\u0027]"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def process_notification(self, message):"},{"line_number":155,"context_line":"        yield sample.Sample.from_notification("},{"line_number":156,"context_line":"            name\u003d\u0027bandwidth\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fkb8%3D","line":153,"updated":"2013-09-03 11:47:08.000000000","message":"No need to use @property, just event_types \u003d [\u0027l3.meter\u0027]","commit_id":"1fc86d8609a914c0c45c0124c51fff9fbc648cac"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"be7f3eadbf0991f774af72150ab2b57051cc6f71","unresolved":false,"context_lines":[{"line_number":153,"context_line":"        yield sample.Sample.from_notification("},{"line_number":154,"context_line":"            name\u003d\u0027bandwidth\u0027,"},{"line_number":155,"context_line":"            type\u003dsample.TYPE_DELTA,"},{"line_number":156,"context_line":"            unit\u003d\u0027bytes\u0027,"},{"line_number":157,"context_line":"            volume\u003dmessage[\u0027payload\u0027][\u0027bytes\u0027],"},{"line_number":158,"context_line":"            user_id\u003dNone,"},{"line_number":159,"context_line":"            project_id\u003dmessage[\u0027payload\u0027][\u0027tenant_id\u0027],"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAASn%2F%2FjwA%3D","line":156,"updated":"2013-09-03 14:29:07.000000000","message":"Sorry, I just recalled we use official abbreviation and B is already used everywhere. You may want to fix it too","commit_id":"e91f27ff21c9bb8142205cdb0f488fd637186446"}],"setup.cfg":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6676443fa34afb8893290bc677ec3fc89ceb65f3","unresolved":false,"context_lines":[{"line_number":51,"context_line":"    floatingip \u003d ceilometer.network.notifications:FloatingIP"},{"line_number":52,"context_line":"    http.request \u003d ceilometer.middleware:HTTPRequest"},{"line_number":53,"context_line":"    http.response \u003d ceilometer.middleware:HTTPResponse"},{"line_number":54,"context_line":"    bandwidth \u003d ceilometer.network.notifications:Bandwidth"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"ceilometer.poll.compute \u003d"},{"line_number":57,"context_line":"    disk.read.requests \u003d ceilometer.compute.pollsters.disk:ReadRequestsPollster"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"AAAASn%2F%2F6dc%3D","line":54,"updated":"2013-08-28 02:37:31.000000000","message":"maybe group this with other network.notifications if you need another patch","commit_id":"1cf9a06365493c75db1f182972500f6005fac98c"}]}