)]}'
{"ceilometer/agent/discovery/tenant.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"3f39c04b79b84c69e56bac0cebb6c010b00613f1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                domain_tenants \u003d manager.keystone.projects.list(domain)"},{"line_number":37,"context_line":"                LOG.debug(\"Found %s tenants in domain %s\", len(domain_tenants),"},{"line_number":38,"context_line":"                          domain.name)"},{"line_number":39,"context_line":"                tenants \u003d tenants + domain_tenants"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            tenants \u003d manager.keystone.projects.list()"},{"line_number":42,"context_line":"            LOG.debug(\"No domains - found %s tenants in default domain\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_9e5a5682","line":39,"updated":"2017-03-07 20:49:20.000000000","message":"are we sure the list of tenant is unique per domain?","commit_id":"fb73df0b4053b46339e208e2858da393b9630136"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"cf2bde0219136331d643d535f61c48c12822ab6a","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                domain_tenants \u003d manager.keystone.projects.list(domain)"},{"line_number":37,"context_line":"                LOG.debug(\"Found %s tenants in domain %s\", len(domain_tenants),"},{"line_number":38,"context_line":"                          domain.name)"},{"line_number":39,"context_line":"                tenants \u003d tenants + domain_tenants"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            tenants \u003d manager.keystone.projects.list()"},{"line_number":42,"context_line":"            LOG.debug(\"No domains - found %s tenants in default domain\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_8754b421","line":39,"in_reply_to":"9a30ddce_4469da24","updated":"2017-03-08 11:03:58.000000000","message":"Ah, ok :) In that case I\u0027m reassured","commit_id":"fb73df0b4053b46339e208e2858da393b9630136"},{"author":{"_account_id":14768,"name":"Darren Hague","email":"d.hague@sap.com","username":"dhague"},"change_message_id":"f5e0df0f5910a2820d7b9ec9b16194de665f155e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                domain_tenants \u003d manager.keystone.projects.list(domain)"},{"line_number":37,"context_line":"                LOG.debug(\"Found %s tenants in domain %s\", len(domain_tenants),"},{"line_number":38,"context_line":"                          domain.name)"},{"line_number":39,"context_line":"                tenants \u003d tenants + domain_tenants"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            tenants \u003d manager.keystone.projects.list()"},{"line_number":42,"context_line":"            LOG.debug(\"No domains - found %s tenants in default domain\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_4469da24","line":39,"in_reply_to":"9a30ddce_616330dd","updated":"2017-03-08 10:24:54.000000000","message":"Sorry, I mis-typed. A given project can belong to only one domain - projects are stored in a hierarchy with domains at the root. There is no risk of a project appearing twice in the tenants array.","commit_id":"fb73df0b4053b46339e208e2858da393b9630136"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2b513940ed37ed74b46c5f660e0e0e6a67ebe7c1","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                domain_tenants \u003d manager.keystone.projects.list(domain)"},{"line_number":37,"context_line":"                LOG.debug(\"Found %s tenants in domain %s\", len(domain_tenants),"},{"line_number":38,"context_line":"                          domain.name)"},{"line_number":39,"context_line":"                tenants \u003d tenants + domain_tenants"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            tenants \u003d manager.keystone.projects.list()"},{"line_number":42,"context_line":"            LOG.debug(\"No domains - found %s tenants in default domain\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_616330dd","line":39,"in_reply_to":"9a30ddce_82b10792","updated":"2017-03-08 09:49:12.000000000","message":"Unique *per domain* which means the domain foobar can be in two domains, but not be the same project IIUC. Which is a problem here since the project will be listed twice in the tenants array. No?","commit_id":"fb73df0b4053b46339e208e2858da393b9630136"},{"author":{"_account_id":14768,"name":"Darren Hague","email":"d.hague@sap.com","username":"dhague"},"change_message_id":"6c9e3974cde015771fbd0f9ea94e3ef6eff02996","unresolved":false,"context_lines":[{"line_number":36,"context_line":"                domain_tenants \u003d manager.keystone.projects.list(domain)"},{"line_number":37,"context_line":"                LOG.debug(\"Found %s tenants in domain %s\", len(domain_tenants),"},{"line_number":38,"context_line":"                          domain.name)"},{"line_number":39,"context_line":"                tenants \u003d tenants + domain_tenants"},{"line_number":40,"context_line":"        else:"},{"line_number":41,"context_line":"            tenants \u003d manager.keystone.projects.list()"},{"line_number":42,"context_line":"            LOG.debug(\"No domains - found %s tenants in default domain\","}],"source_content_type":"text/x-python","patch_set":1,"id":"9a30ddce_82b10792","line":39,"in_reply_to":"9a30ddce_9e5a5682","updated":"2017-03-08 09:16:56.000000000","message":"Tenants (i.e. projects in v3-speak) are definitely unique per domain - see https://developer.openstack.org/api-ref/identity/v3/index.html#projects for more details.","commit_id":"fb73df0b4053b46339e208e2858da393b9630136"}]}