)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8412696ac82415e1bdd1395d81cde3f8f81972f5","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Tong Li \u003clitong01@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-08-29 22:30:53 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db2 implementation does not sort results of get_resources"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I7094842e725698343712f2666106317c57f1f262"},{"line_number":10,"context_line":"fixes: bug #1218047"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAASn%2F%2Fv4I%3D","line":7,"updated":"2013-08-30 02:43:06.000000000","message":"This describes the bug, but not the change as proposed, since now the driver *does* sort the results.","commit_id":"ec8975d4ee5ab216aa8e78082bd7c1c18b261e65"}],"ceilometer/storage/impl_db2.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"8412696ac82415e1bdd1395d81cde3f8f81972f5","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # will not be exception when real db2 gets used as backend."},{"line_number":190,"context_line":"        server_info \u003d self.conn.server_info()"},{"line_number":191,"context_line":"        if server_info.get(\u0027sysInfo\u0027):"},{"line_number":192,"context_line":"            self._is_mongo \u003d True"},{"line_number":193,"context_line":"        else:"},{"line_number":194,"context_line":"            self._is_mongo \u003d False"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fv4M%3D","line":192,"updated":"2013-08-30 02:43:06.000000000","message":"This variable name is confusing. We always use pymongo, so what is this really checking?","commit_id":"ec8975d4ee5ab216aa8e78082bd7c1c18b261e65"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"073fcea04e48835d72a07e7231dc923ec8562757","unresolved":false,"context_lines":[{"line_number":189,"context_line":"        # will not be exception when real db2 gets used as backend."},{"line_number":190,"context_line":"        server_info \u003d self.conn.server_info()"},{"line_number":191,"context_line":"        if server_info.get(\u0027sysInfo\u0027):"},{"line_number":192,"context_line":"            self._is_mongo \u003d True"},{"line_number":193,"context_line":"        else:"},{"line_number":194,"context_line":"            self._is_mongo \u003d False"},{"line_number":195,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2Fvx4%3D","line":192,"in_reply_to":"AAAASn%2F%2Fv4M%3D","updated":"2013-08-30 03:22:13.000000000","message":"we are using mongodb as a backend for jenkins testing. Some of the code\nhas to be written based on what backend is.","commit_id":"ec8975d4ee5ab216aa8e78082bd7c1c18b261e65"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5949dfb26db461aaff7becddca4e3e96ac604856","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                self.db.project.find(q, fields\u003d[\u0027_id\u0027],"},{"line_number":344,"context_line":"                                     sort\u003d[(\u0027_id\u0027, pymongo.ASCENDING)]))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def _build_sort(cls, sort_keys\u003d[], sort_dir\u003d\u0027desc\u0027):"},{"line_number":348,"context_line":"        \"\"\"Returns a query sort requirement"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fuy0%3D","line":346,"updated":"2013-08-30 09:43:14.000000000","message":"@staticmethod","commit_id":"917e5045599d0457e72ba04bdd79f06b53e79d3f"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"c8133f10aff1c8a174fd468fb07114d85291152b","unresolved":false,"context_lines":[{"line_number":343,"context_line":"                self.db.project.find(q, fields\u003d[\u0027_id\u0027],"},{"line_number":344,"context_line":"                                     sort\u003d[(\u0027_id\u0027, pymongo.ASCENDING)]))"},{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @classmethod"},{"line_number":347,"context_line":"    def _build_sort(cls, sort_keys\u003d[], sort_dir\u003d\u0027desc\u0027):"},{"line_number":348,"context_line":"        \"\"\"Returns a query sort requirement"},{"line_number":349,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Fuis%3D","line":346,"in_reply_to":"AAAASn%2F%2Fuy0%3D","updated":"2013-08-30 11:24:48.000000000","message":"Done","commit_id":"917e5045599d0457e72ba04bdd79f06b53e79d3f"},{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"c15d83f9dee11ad9b1d7ba0e96f87a307a831917","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        resource_ids \u003d self.db.meter.find(q).distinct(\u0027resource_id\u0027)"},{"line_number":419,"context_line":"        if self._is_mongo:"},{"line_number":420,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: resource_ids}}"},{"line_number":421,"context_line":"        else:"},{"line_number":422,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: [m[\u0027_id\u0027] for m in resource_ids]}}"},{"line_number":423,"context_line":"        for resource in self.db.resource.find(q, sort\u003dall_sort):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Ft%2FM%3D","line":420,"updated":"2013-08-30 14:25:49.000000000","message":"Why is it not using the sort here? This is the mongo case - so wouldn\u0027t the test fail. Also there needs to be aggregation here to deal with min/max, and latest representation.\n\nAm I missing something? :\\","commit_id":"917e5045599d0457e72ba04bdd79f06b53e79d3f"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"554eaceafef2dbc7f2ba96559cadd37bd304cfb0","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        resource_ids \u003d self.db.meter.find(q).distinct(\u0027resource_id\u0027)"},{"line_number":419,"context_line":"        if self._is_mongo:"},{"line_number":420,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: resource_ids}}"},{"line_number":421,"context_line":"        else:"},{"line_number":422,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: [m[\u0027_id\u0027] for m in resource_ids]}}"},{"line_number":423,"context_line":"        for resource in self.db.resource.find(q, sort\u003dall_sort):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2Ft98%3D","line":420,"in_reply_to":"AAAASn%2F%2Ft%2FM%3D","updated":"2013-08-30 14:27:34.000000000","message":"sort is used when get resources later. Here is just to get these IDs. why\ndo we need sort here?","commit_id":"917e5045599d0457e72ba04bdd79f06b53e79d3f"},{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"76632cd6030db264c86f2b866176b75804d9154f","unresolved":false,"context_lines":[{"line_number":417,"context_line":""},{"line_number":418,"context_line":"        resource_ids \u003d self.db.meter.find(q).distinct(\u0027resource_id\u0027)"},{"line_number":419,"context_line":"        if self._is_mongo:"},{"line_number":420,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: resource_ids}}"},{"line_number":421,"context_line":"        else:"},{"line_number":422,"context_line":"            q \u003d {\u0027_id\u0027: {\u0027$in\u0027: [m[\u0027_id\u0027] for m in resource_ids]}}"},{"line_number":423,"context_line":"        for resource in self.db.resource.find(q, sort\u003dall_sort):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAASn%2F%2FswI%3D","line":420,"in_reply_to":"AAAASn%2F%2Ft98%3D","updated":"2013-08-30 18:16:44.000000000","message":"I\u0027m sorry, I was looking at this line incorrectly. The conversation in IRC brought out the main concerns, I think.","commit_id":"917e5045599d0457e72ba04bdd79f06b53e79d3f"}]}