)]}'
{"ceilometer/publisher/zaqar.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"5e7d65885fb752f57aaffaf689fabf1a33e57dcf","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    @property"},{"line_number":58,"context_line":"    def client(self):"},{"line_number":59,"context_line":"        if self._client is None:"},{"line_number":60,"context_line":"            group \u003d \u0027zaqar\u0027"},{"line_number":61,"context_line":"            auth_plugin \u003d loading.load_auth_from_conf_options(self.conf, group)"},{"line_number":62,"context_line":"            session \u003d loading.load_session_from_conf_options("},{"line_number":63,"context_line":"                self.conf, group, auth\u003dauth_plugin)"},{"line_number":64,"context_line":"            self._client \u003d zaqarclient.Client(session\u003dsession)"},{"line_number":65,"context_line":"        return self._client"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5ff73747_61af89e3","line":63,"range":{"start_line":60,"start_character":12,"end_line":63,"end_character":51},"updated":"2017-04-25 14:49:55.000000000","message":"Can you use \"ceilometer.keystone_client.get_session(conf, group\u003dself.conf.zaquar.auth_section)\" instead ?\n\nSo that will pick the \"service_credentials\" group by default if [zaquar]/auth_section is unset.","commit_id":"86df9a565fca3a3933dcd5322da6e2de55b19b78"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"8e329747726e22765bce53e6a2cd8feeee6b2fb6","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":49,"context_line":"        super(ZaqarPublisher, self).__init__(conf, parsed_url)"},{"line_number":50,"context_line":"        self.queue_name \u003d parsed_url.hostname"},{"line_number":51,"context_line":"        if not self.queue_name:"},{"line_number":52,"context_line":"            raise ValueError(\u0027Must specify a queue in the zaqar publisher\u0027)"},{"line_number":53,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_9ddf8dd5","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":45},"updated":"2017-04-25 20:39:29.000000000","message":"Shouldn\u0027t we use an option instead of hostname for the queue_name ? so the queue name can contains any characters.","commit_id":"d24f6ef1fbc96b6303c0f019d89729b6176dfaaf"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"cb8db704d4d27c49b61ad9b90210b1d7738825d0","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":49,"context_line":"        super(ZaqarPublisher, self).__init__(conf, parsed_url)"},{"line_number":50,"context_line":"        self.queue_name \u003d parsed_url.hostname"},{"line_number":51,"context_line":"        if not self.queue_name:"},{"line_number":52,"context_line":"            raise ValueError(\u0027Must specify a queue in the zaqar publisher\u0027)"},{"line_number":53,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_fb68a21d","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":45},"in_reply_to":"5ff73747_05e40de0","updated":"2017-04-27 09:31:10.000000000","message":"Ah okay that\u0027s fair.","commit_id":"d24f6ef1fbc96b6303c0f019d89729b6176dfaaf"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"986a56c8ec47d4db7a602d4b798719042bb0bf08","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":49,"context_line":"        super(ZaqarPublisher, self).__init__(conf, parsed_url)"},{"line_number":50,"context_line":"        self.queue_name \u003d parsed_url.hostname"},{"line_number":51,"context_line":"        if not self.queue_name:"},{"line_number":52,"context_line":"            raise ValueError(\u0027Must specify a queue in the zaqar publisher\u0027)"},{"line_number":53,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_df25ffc3","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":45},"in_reply_to":"5ff73747_9ddf8dd5","updated":"2017-04-26 06:38:41.000000000","message":"You mean an option in the config file? That would mean I can only use one queue for all pipelines, I\u0027d like to have several.","commit_id":"d24f6ef1fbc96b6303c0f019d89729b6176dfaaf"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d627e35a436a5a73ab880151c5662955539e7250","unresolved":false,"context_lines":[{"line_number":47,"context_line":"    \"\"\""},{"line_number":48,"context_line":"    def __init__(self, conf, parsed_url):"},{"line_number":49,"context_line":"        super(ZaqarPublisher, self).__init__(conf, parsed_url)"},{"line_number":50,"context_line":"        self.queue_name \u003d parsed_url.hostname"},{"line_number":51,"context_line":"        if not self.queue_name:"},{"line_number":52,"context_line":"            raise ValueError(\u0027Must specify a queue in the zaqar publisher\u0027)"},{"line_number":53,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5ff73747_05e40de0","line":50,"range":{"start_line":50,"start_character":37,"end_line":50,"end_character":45},"in_reply_to":"5ff73747_df25ffc3","updated":"2017-04-27 08:30:31.000000000","message":"I just don\u0027t want to use \u0027parsed_url.hostname\u0027 because it have many restrictions with allowed chars.\n\nI imagine: \n * zaqar://?queue\u003dmeter_queue\u0026ttl\u003d1200\nor:\n * zaqar:///meter_queue?ttl\u003d1200\n\nI prefer the first one because is more explicit.","commit_id":"d24f6ef1fbc96b6303c0f019d89729b6176dfaaf"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5757412fde25fbedfbd6f376513943347d801132","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        options \u003d urlparse.parse_qs(parsed_url.query)"},{"line_number":51,"context_line":"        self.queue_name \u003d options.get(\u0027queue\u0027, [None])[0]"},{"line_number":52,"context_line":"        if not self.queue_name:"},{"line_number":53,"context_line":"            raise ValueError(\u0027Must specify a queue in the zaqar publisher\u0027)"},{"line_number":54,"context_line":"        self.ttl \u003d int(options.pop(\u0027ttl\u0027, [DEFAULT_TTL])[0])"},{"line_number":55,"context_line":"        self._client \u003d None"},{"line_number":56,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5ff73747_ab4df53e","line":53,"range":{"start_line":53,"start_character":58,"end_line":53,"end_character":63},"updated":"2017-04-28 13:37:12.000000000","message":"Zaqar","commit_id":"ab58aaeed17db48812f87fec74f8300ee668ad76"}],"test-requirements.txt":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"5757412fde25fbedfbd6f376513943347d801132","unresolved":false,"context_lines":[{"line_number":29,"context_line":"WebTest\u003e\u003d2.0 # MIT"},{"line_number":30,"context_line":"pifpaf\u003e\u003d0.0.11 # Apache-2.0"},{"line_number":31,"context_line":"os-api-ref\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":32,"context_line":"python-zaqarclient\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"5ff73747_cb360152","line":32,"updated":"2017-04-28 13:37:12.000000000","message":"not against it, though maybe adding an extra [zaqar] in setup.cfg to avoid the mandatory installation of it would  be nice.\n\nthat\u0027d also help deployment","commit_id":"ab58aaeed17db48812f87fec74f8300ee668ad76"},{"author":{"_account_id":7385,"name":"Thomas Herve","email":"therve@redhat.com","username":"therve"},"change_message_id":"779448e1cce311580d97685ab3fbb4c63950406b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"WebTest\u003e\u003d2.0 # MIT"},{"line_number":30,"context_line":"pifpaf\u003e\u003d0.0.11 # Apache-2.0"},{"line_number":31,"context_line":"os-api-ref\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":32,"context_line":"python-zaqarclient\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"5ff73747_d9713baa","line":32,"in_reply_to":"5ff73747_cb360152","updated":"2017-04-28 14:12:52.000000000","message":"That wouldn\u0027t help testing though, or do I miss something?","commit_id":"ab58aaeed17db48812f87fec74f8300ee668ad76"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"c17560f21afbb88cbecc37d699ac09b10a704204","unresolved":false,"context_lines":[{"line_number":29,"context_line":"WebTest\u003e\u003d2.0 # MIT"},{"line_number":30,"context_line":"pifpaf\u003e\u003d0.0.11 # Apache-2.0"},{"line_number":31,"context_line":"os-api-ref\u003e\u003d0.1.0 # Apache-2.0"},{"line_number":32,"context_line":"python-zaqarclient\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":3,"id":"5ff73747_d4e8e2b3","line":32,"in_reply_to":"5ff73747_d9713baa","updated":"2017-04-28 14:51:21.000000000","message":"For testing you\u0027d need to edit e.g. tox.ini to make sure the zaqar extra is selected, as it\u0027s done for e.g. gnocchi or postgresql","commit_id":"ab58aaeed17db48812f87fec74f8300ee668ad76"}]}