)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5678,"name":"John Herndon","email":"john.herndon@hp.com","username":"john-herndon"},"change_message_id":"ce7626ca6055aeb7d3c1183295eeecfc6fabaafe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mehdi Abaakouk \u003cmehdi.abaakouk@enovance.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-09-11 12:44:22 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Don\u0027t publish samples if resource_id in missing"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In swift API, the user can call uri without the resource_id."},{"line_number":10,"context_line":"This change skip the samples publishing instead of raising the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAASn%2F%2FH9w%3D","line":7,"updated":"2013-09-11 15:45:27.000000000","message":"is missing*","commit_id":"1841dc236679cc566ffdddd51edc327bdc148fbc"}],"ceilometer/objectstore/swift_middleware.py":[{"author":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"change_message_id":"3bc5f254914246a0a25950ece14f9ad13296369a","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        version, account, container, obj \u003d split_path(req.path, 1, 4, True)"},{"line_number":118,"context_line":"        now \u003d timeutils.utcnow().isoformat()"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        if not account:"},{"line_number":121,"context_line":"            return"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        resource_metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAASn%2F%2FHFE%3D","line":120,"updated":"2013-09-11 19:58:02.000000000","message":"Could you add a comment with an example of a case where this could happen? Is it a valid swift URL?","commit_id":"1841dc236679cc566ffdddd51edc327bdc148fbc"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"791f2c1531a196a1d68188fd22d6b1d29336ef8d","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #note(sileht): if the user request a path like"},{"line_number":124,"context_line":"        #http://swift_domain:5000/5.0/, the account is empty"},{"line_number":125,"context_line":"        if not account:"},{"line_number":126,"context_line":"            return"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        resource_metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F9gU%3D","line":125,"updated":"2013-09-16 14:55:27.000000000","message":"AFAICT this patch is now useless because the code on line 118 would fail if there\u0027s no account in the URL.","commit_id":"89dae7e32305a5c2a09b1a64175377171b99d652"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"74fee16821f4c8a89b00779a16b12bf0fee4edfe","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"        #note(sileht): if the user request a path like"},{"line_number":124,"context_line":"        #http://swift_domain:5000/5.0/, the account is empty"},{"line_number":125,"context_line":"        if not account:"},{"line_number":126,"context_line":"            return"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        resource_metadata \u003d {"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2F668%3D","line":125,"in_reply_to":"AAAAS3%2F%2F9gU%3D","updated":"2013-09-17 07:32:45.000000000","message":"My test case fail without the change. I will propose more sexy solution with a better usage of split_path","commit_id":"89dae7e32305a5c2a09b1a64175377171b99d652"}],"tests/objectstore/test_swift_middleware.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"397a43e1b25fda04a26af2626574cc7204ef7d2e","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        samples \u003d self.pipeline_manager.pipelines[0].samples"},{"line_number":251,"context_line":"        self.assertEqual(len(samples), 0)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_missing_ressource_id(self):"},{"line_number":254,"context_line":"        app \u003d swift_middleware.CeilometerMiddleware(FakeApp(), {})"},{"line_number":255,"context_line":"        req \u003d Request.blank(\u0027/5.0/\u0027,"},{"line_number":256,"context_line":"                            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027GET\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FkYA%3D","line":253,"updated":"2013-09-24 15:56:44.000000000","message":"s/ressource/resource/","commit_id":"7d983443f5fc09e378f4592fb210e305d1b5aed0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"a66c4904cb799506b08989b048fc74d940b5734c","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        samples \u003d self.pipeline_manager.pipelines[0].samples"},{"line_number":251,"context_line":"        self.assertEqual(len(samples), 0)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"    def test_missing_ressource_id(self):"},{"line_number":254,"context_line":"        app \u003d swift_middleware.CeilometerMiddleware(FakeApp(), {})"},{"line_number":255,"context_line":"        req \u003d Request.blank(\u0027/5.0/\u0027,"},{"line_number":256,"context_line":"                            environ\u003d{\u0027REQUEST_METHOD\u0027: \u0027GET\u0027})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAS3%2F%2FhyE%3D","line":253,"in_reply_to":"AAAAS3%2F%2FkYA%3D","updated":"2013-09-25 07:40:45.000000000","message":"Done","commit_id":"7d983443f5fc09e378f4592fb210e305d1b5aed0"}]}