)]}'
{"tests/agentbase.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"df61844850a2f2ceae5b662b6a1e603f5c9d78f7","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        mgr.create_polling_task \u003d mock.MagicMock()"},{"line_number":253,"context_line":"        service \u003d mock.MagicMock()"},{"line_number":254,"context_line":"        mgr.initialize_service_hook(service)"},{"line_number":255,"context_line":"        self.assertTrue(service.tg.add_timer.called)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_manager_exception_persistency(self):"},{"line_number":258,"context_line":"        self.pipeline_cfg.append({"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FgOY%3D","line":255,"updated":"2013-09-25 15:48:22.000000000","message":"Suggestion ... if you\u0027re going to assert that add_timer is called, might as well have a more detailed assertion on the actual timer task being created (i.e. assert that the call args are as expected).","commit_id":"259f064c98b683248c0dcc1ab67c355f094dcd3c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a0c29b98dd54709ccb6b26e7a48d31706eec870a","unresolved":false,"context_lines":[{"line_number":252,"context_line":"        mgr.create_polling_task \u003d mock.MagicMock()"},{"line_number":253,"context_line":"        service \u003d mock.MagicMock()"},{"line_number":254,"context_line":"        mgr.initialize_service_hook(service)"},{"line_number":255,"context_line":"        self.assertTrue(service.tg.add_timer.called)"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"    def test_manager_exception_persistency(self):"},{"line_number":258,"context_line":"        self.pipeline_cfg.append({"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAS3%2F%2FgNI%3D","line":255,"in_reply_to":"AAAAS3%2F%2FgOY%3D","updated":"2013-09-25 15:52:38.000000000","message":"Eoghan, since the method initialize_service_hook was not tested by any test\ncases, this patch adds that to cover the method test. Since that method does\nnot really return anything other than call add_timer method, so make sure it\ncalls that method ensures that the initialize_service_hook is indeed getting\ncalled. To test if the tg works as expected, I think it should be unit tested in\na separate unit test case which associates with service.tg. thanks for the comments though.","commit_id":"259f064c98b683248c0dcc1ab67c355f094dcd3c"}]}