)]}'
{"ceilometer/data/meters.d/meters.yaml":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"610799368e43acaf23a1a04fbfa486eeeb120166","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff346bd7_75b4de35","line":356,"updated":"2017-07-25 20:19:42.000000000","message":"this doesn\u0027t seem right. this already exists as resource_id so it\u0027s queryable already.","commit_id":"ca5f7b734eec1c8d35f4ceb1de33b9524b6ea67f"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9d38754ff97bb0dc52ce11158362be4bb50e6f2","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ff346bd7_85149445","line":356,"in_reply_to":"ff346bd7_75b4de35","updated":"2017-07-26 13:44:19.000000000","message":"It is not... for some reason is not working for me.","commit_id":"ca5f7b734eec1c8d35f4ceb1de33b9524b6ea67f"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b6a6b573c67796935a2eb41dc7f1ffaeb370f77f","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_c93d12de","line":356,"updated":"2017-07-26 16:55:01.000000000","message":"can you provide more details? what is the query you are attempting? this is probably a deficiency in Gnocchi if you\u0027re having issues querying on resource_id","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"29ad20c65c918a84581b447d38967a109fb52e17","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_d918201f","line":356,"in_reply_to":"ff346bd7_5af79460","updated":"2017-07-27 13:05:21.000000000","message":"If I remove the share_id attribute there is no way I can identify from which share I\u0027m getting that information. I\u0027m assuming that all the attributes that we have in gnocchi_resources is the one that creates an entry in the control database and the values that are actually stored. How are we going to keep track of which resource is which size and how it changes over time if we don\u0027t have a way to keep track of which resource we are talking about?","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"788c16c10c749921872c7c0ac520c9cd6d3dff1f","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_ac8adcbb","line":356,"in_reply_to":"ff346bd7_ac409ca6","updated":"2017-07-26 17:14:22.000000000","message":"Oops. Removing share_id from metadata and relying on resource_id.\n\nJul 26 14:10:47 ubuntu ceilometer-agent-notification[9403]: 2017-07-26 14:10:47.257 9744 ERROR ceilometer.dispatcher.gnocchi [-] Error creating resource 71fac341-571f-4b92-89dc-928977fe9172: Invalid input: required key not provided @ data[u\u0027resource_id\u0027] (HTTP 400): BadRequest: Invalid input: required key not provided @ data[u\u0027resource_id\u0027] (HTTP 400)","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"51f1525c92e2370742baadf02202c4c9693c5ea4","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_5af79460","line":356,"in_reply_to":"ff346bd7_ac8adcbb","updated":"2017-07-27 03:02:08.000000000","message":"What if you also remove the \u0027share_id\u0027 attribute \nin gnocchi_resources.yaml? I guess the share_id shouldn\u0027t be added in the metadata.","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08c6cf2c7541f07dda3736aadf9906e86d646f35","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_ac409ca6","line":356,"in_reply_to":"ff346bd7_c93d12de","updated":"2017-07-26 17:13:17.000000000","message":"So, if I add the field","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"b92b0964b7112529ccf4ddab1f24520e465bd9ff","unresolved":false,"context_lines":[{"line_number":353,"context_line":"    project_id: $.payload.project_id"},{"line_number":354,"context_line":"    resource_id: $.payload.share_id"},{"line_number":355,"context_line":"    metadata:"},{"line_number":356,"context_line":"      share_id: $.payload.share_id"},{"line_number":357,"context_line":"      name: $.payload.name"},{"line_number":358,"context_line":"      host: $.payload.host"},{"line_number":359,"context_line":"      status: $.payload.status"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_736f05fc","line":356,"in_reply_to":"ff346bd7_d918201f","updated":"2017-07-27 18:38:02.000000000","message":"Jul 26 14:10:47 ubuntu ceilometer-agent-notification[9403]: 2017-07-26 14:10:47.257 9744 ERROR ceilometer.dispatcher.gnocchi [-] Error creating resource 71fac341-571f-4b92-89dc-928977fe9172: Invalid input: required key not provided @ data[u\u0027resource_id\u0027] (HTTP 400): BadRequest: Invalid input: required key not provided @ data[u\u0027resource_id\u0027] (HTTP 400)\n\nerror means share_id is None. so it\u0027s unrelated\n\nright now, setting resource_id \u003d share_id, the gnocchi query is:\n\n  gnocchi measures show manila.share.size --resource_id \u003cshare_id\u003e\n\ni\u0027m not entirely sure how adding share_id in metadata helps any.","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"}],"ceilometer/dispatcher/data/gnocchi_resources.yaml":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6884e623a34978c845bc81ba5ea3f26110f17639","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    attributes:"},{"line_number":245,"context_line":"      name: resource_metadata.name"},{"line_number":246,"context_line":"      host: resource_metadata.host"},{"line_number":247,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"  - resource_type: switch"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_4e46f27e","side":"PARENT","line":247,"updated":"2017-07-25 16:30:37.000000000","message":"Why removing it if we still have it in meters.yaml ?","commit_id":"91e7483ed1d42b03e4e4a051b7c38bec381b6f0a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"23a59d7c222bd4df07e1ff2c179852c34c67b9e5","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    attributes:"},{"line_number":245,"context_line":"      name: resource_metadata.name"},{"line_number":246,"context_line":"      host: resource_metadata.host"},{"line_number":247,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":""},{"line_number":250,"context_line":"  - resource_type: switch"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_6950900b","side":"PARENT","line":247,"in_reply_to":"ff346bd7_4e46f27e","updated":"2017-07-25 16:35:41.000000000","message":"That was unintended, adding it now.","commit_id":"91e7483ed1d42b03e4e4a051b7c38bec381b6f0a"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6884e623a34978c845bc81ba5ea3f26110f17639","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      protocol: resource_metadata.proto"},{"line_number":250,"context_line":"      size: resource_metadata.size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_8e317a0e","line":250,"updated":"2017-07-25 16:30:37.000000000","message":"I don\u0027t we size in meters.yaml.","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"1e0603380388afd0d00e76913e2202cf21e8ebb8","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      protocol: resource_metadata.proto"},{"line_number":250,"context_line":"      size: resource_metadata.size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_c4e64145","line":250,"in_reply_to":"ff346bd7_69653045","updated":"2017-07-25 17:06:52.000000000","message":"Same attribute. It\u0027s safe to remove then.","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"115c27a45b921c2c6f05a8f6dea67957faa560d9","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      protocol: resource_metadata.proto"},{"line_number":250,"context_line":"      size: resource_metadata.size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_69653045","line":250,"in_reply_to":"ff346bd7_89d2945b","updated":"2017-07-25 16:53:58.000000000","message":"i think the question is what is this \u0027size\u0027 vs the \u0027size\u0027 value in volume?","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"23a59d7c222bd4df07e1ff2c179852c34c67b9e5","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      protocol: resource_metadata.proto"},{"line_number":250,"context_line":"      size: resource_metadata.size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_a9455845","line":250,"in_reply_to":"ff346bd7_8e317a0e","updated":"2017-07-25 16:35:41.000000000","message":"Sorry, not following. Could you rephrase?","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"17ee77a36a10dbf9fa5df2a0071f84a41b88ee8d","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      protocol: resource_metadata.proto"},{"line_number":250,"context_line":"      size: resource_metadata.size"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"ff346bd7_89d2945b","line":250,"in_reply_to":"ff346bd7_a9455845","updated":"2017-07-25 16:38:05.000000000","message":"Oh I think I got it... is that size attribute is not present in meters.yaml? It is present, but not in the metadata field. Shall I add it?","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"d5117a1131873881618d763635e6376d3bc5ea58","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":250,"context_line":"      protocol: resource_metadata.proto"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_716bb21d","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":39},"updated":"2017-07-26 15:42:09.000000000","message":"it\u0027s called protocol in meters.yaml","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"51f1525c92e2370742baadf02202c4c9693c5ea4","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":250,"context_line":"      protocol: resource_metadata.proto"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_7a65b81d","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":39},"in_reply_to":"ff346bd7_294ede96","updated":"2017-07-27 03:02:08.000000000","message":"this should keep up with meters.yaml. Obviously, the reason the error occurred is that there\u0027s not \u0027protocol\u0027 attribute in gnocchi_client.py.","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"08c6cf2c7541f07dda3736aadf9906e86d646f35","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":250,"context_line":"      protocol: resource_metadata.proto"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_294ede96","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":39},"in_reply_to":"ff346bd7_716bb21d","updated":"2017-07-26 17:13:17.000000000","message":"Changing this value to protocol as it is in meters.yaml throws me this error:\n\nJul 26 13:53:10 ubuntu ceilometer-agent-notification[27290]: 2017-07-26 13:53:10.816 27413 ERROR ceilometer.dispatcher.gnocchi [-] Error creating resource da407b9e-0d89-4bad-9ab8-3e487f403949: Invalid input: extra keys not allowed @ data[u\u0027protocol\u0027] (HTTP 400): BadRequest: Invalid input: extra keys not allowed @ data[u\u0027protocol\u0027] (HTTP 400)","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"29ad20c65c918a84581b447d38967a109fb52e17","unresolved":false,"context_lines":[{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"},{"line_number":249,"context_line":"      availability_zone: resource_metadata.availability_zone"},{"line_number":250,"context_line":"      protocol: resource_metadata.proto"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"  - resource_type: switch"},{"line_number":253,"context_line":"    metrics:"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"ff346bd7_790b74d5","line":250,"range":{"start_line":250,"start_character":34,"end_line":250,"end_character":39},"in_reply_to":"ff346bd7_7a65b81d","updated":"2017-07-27 13:05:21.000000000","message":"It is not obvious. I\u0027m assuming that we get the payload and we can access all the attributes, as we get it from manila. In order to our uses to keep track of the protocol, shall I put protocol field as well in gnocchi_client?","commit_id":"c994164347d18430a7a49cadb7535f34064a8b10"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"8530731db761176e64e68a2b8a553f75f75f234e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"    metrics:"},{"line_number":243,"context_line":"      - \u0027manila.share.size\u0027"},{"line_number":244,"context_line":"    attributes:"},{"line_number":245,"context_line":"      share_id: resource_metadata.resource_id"},{"line_number":246,"context_line":"      name: resource_metadata.name"},{"line_number":247,"context_line":"      host: resource_metadata.host"},{"line_number":248,"context_line":"      status: resource_metadata.status"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"df3967d1_d493f2a2","line":245,"updated":"2017-07-28 17:55:31.000000000","message":"i think you just need to remove this.","commit_id":"fb4f1c29c30b86b94a2be0004b1b5b123b0104fe"}],"ceilometer/gnocchi_client.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"6884e623a34978c845bc81ba5ea3f26110f17639","unresolved":false,"context_lines":[{"line_number":131,"context_line":"     \"type\": \"create_resource_type\","},{"line_number":132,"context_line":"     \"resource_type\": \"manila_share\","},{"line_number":133,"context_line":"     \"data\": [{"},{"line_number":134,"context_line":"         \"attributes\": {\"share_id\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":135,"context_line":"                                     \"max_length\": 255, \"required\": True},"},{"line_number":136,"context_line":"                        \"host\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":137,"context_line":"                                 \"max_length\": 255, \"required\": True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_8e63ba1a","line":134,"updated":"2017-07-25 16:30:37.000000000","message":"This will break migration. you must not change this list, but only append operation to it.","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"23a59d7c222bd4df07e1ff2c179852c34c67b9e5","unresolved":false,"context_lines":[{"line_number":131,"context_line":"     \"type\": \"create_resource_type\","},{"line_number":132,"context_line":"     \"resource_type\": \"manila_share\","},{"line_number":133,"context_line":"     \"data\": [{"},{"line_number":134,"context_line":"         \"attributes\": {\"share_id\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":135,"context_line":"                                     \"max_length\": 255, \"required\": True},"},{"line_number":136,"context_line":"                        \"host\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":137,"context_line":"                                 \"max_length\": 255, \"required\": True},"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff346bd7_29a848d9","line":134,"in_reply_to":"ff346bd7_8e63ba1a","updated":"2017-07-25 16:35:41.000000000","message":"This resource-type has been added in this release. This shouldn\u0027t hurt at this point. Both name and availability_zone are not mandatory and when the payload arrives with None values for those fields then the resource fails to create. We could set them as not required if you think it\u0027s more correct.","commit_id":"bcf48a00f73a509a863082451f1e7e925866bd3e"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"610799368e43acaf23a1a04fbfa486eeeb120166","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        \"availability_zone\": {\"type\": \"string\","},{"line_number":139,"context_line":"                                              \"min_length\": 0,"},{"line_number":140,"context_line":"                                              \"max_length\": 255,"},{"line_number":141,"context_line":"                                              \"required\": True},"},{"line_number":142,"context_line":"                        \"status\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":143,"context_line":"                                   \"max_length\": 255,"},{"line_number":144,"context_line":"                                   \"required\": True}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_b59366a3","side":"PARENT","line":141,"range":{"start_line":141,"start_character":58,"end_line":141,"end_character":62},"updated":"2017-07-25 20:19:42.000000000","message":"False","commit_id":"91e7483ed1d42b03e4e4a051b7c38bec381b6f0a"},{"author":{"_account_id":6413,"name":"Victoria Martinez de la Cruz","email":"victoria@redhat.com","username":"vkmc"},"change_message_id":"e9d38754ff97bb0dc52ce11158362be4bb50e6f2","unresolved":false,"context_lines":[{"line_number":138,"context_line":"                        \"availability_zone\": {\"type\": \"string\","},{"line_number":139,"context_line":"                                              \"min_length\": 0,"},{"line_number":140,"context_line":"                                              \"max_length\": 255,"},{"line_number":141,"context_line":"                                              \"required\": True},"},{"line_number":142,"context_line":"                        \"status\": {\"type\": \"string\", \"min_length\": 0,"},{"line_number":143,"context_line":"                                   \"max_length\": 255,"},{"line_number":144,"context_line":"                                   \"required\": True}}"}],"source_content_type":"text/x-python","patch_set":4,"id":"ff346bd7_451a2c6f","side":"PARENT","line":141,"range":{"start_line":141,"start_character":58,"end_line":141,"end_character":62},"in_reply_to":"ff346bd7_b59366a3","updated":"2017-07-26 13:44:19.000000000","message":"Ok, I\u0027ll add these back and set \"required\" to False.","commit_id":"91e7483ed1d42b03e4e4a051b7c38bec381b6f0a"}]}