)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c0928171f9192ba0acfffd8ceddc9d1061837947","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                   )"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"class AlarmNotFound(Exception):"},{"line_number":1215,"context_line":"    code \u003d 404"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def __init__(self, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FX80%3D","line":1214,"updated":"2013-09-27 21:27:03.000000000","message":"I wonder do we really need a separate NotFound exception for different entity types (resources versus alarms etc.)?\n\nWould it be neater to just have a single generic EntityNotFound exception type and then parameterize the \u0027Resource\u0027 versus \u0027Alarm\u0027 etc in the exception msg?","commit_id":"ea7195db3439c661bf6fa8fa81af1be9c812f8e0"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"a8818f3f0c47664cdfe66a45bc65f007d4212419","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                   )"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"class AlarmNotFound(Exception):"},{"line_number":1215,"context_line":"    code \u003d 404"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def __init__(self, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FXNQ%3D","line":1214,"in_reply_to":"AAAAS3%2F%2FX80%3D","updated":"2013-09-28 08:18:44.000000000","message":"Well, the advantage is that we can factorize out the error string for example. Though we may want in the future a parent class for the 404 code indeed.","commit_id":"ea7195db3439c661bf6fa8fa81af1be9c812f8e0"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"5eb2480264a857d088c0f05fd2c4847dbbcf1ee9","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                   )"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"class AlarmNotFound(Exception):"},{"line_number":1215,"context_line":"    code \u003d 404"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def __init__(self, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FUzU%3D","line":1214,"in_reply_to":"AAAAS3%2F%2FXLA%3D","updated":"2013-09-30 07:42:58.000000000","message":"Done","commit_id":"ea7195db3439c661bf6fa8fa81af1be9c812f8e0"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"81d841d3b7a76d9d2098f2189cb813b71310b1c4","unresolved":false,"context_lines":[{"line_number":1211,"context_line":"                   )"},{"line_number":1212,"context_line":""},{"line_number":1213,"context_line":""},{"line_number":1214,"context_line":"class AlarmNotFound(Exception):"},{"line_number":1215,"context_line":"    code \u003d 404"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def __init__(self, id):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAS3%2F%2FXLA%3D","line":1214,"in_reply_to":"AAAAS3%2F%2FXNQ%3D","updated":"2013-09-28 09:00:05.000000000","message":"Couldn\u0027t the error string can just be parameterized such as:\n\n  class EntityNotFound(Exception):\n      code \u003d 404\n\n      def __init__(self, type, id):\n          super(EntityNotFound, self).__init__(_(\u0027%(type)s %(id)s Not Found\u0027) %\n                                               dict(type\u003dtype, id\u003did))\n\n   ...\n\n   raise EntityNotFound(_(\u0027Alarm\u0027), alarm_id)","commit_id":"ea7195db3439c661bf6fa8fa81af1be9c812f8e0"}]}