)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"39c171b894f7ddbc0b4cd3f102bc65840a9a3914","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     liu-wei81 \u003cliu.wei81@zte.com.cn\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-11 16:12:05 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add meters for libvirt:"},{"line_number":8,"context_line":"disk.device.read.latency, disk.device.write.latency"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I0235087af459278b9ad0a66f95c4e4c4ac72e112"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"9f436f4f_03bb030e","line":7,"updated":"2017-08-11 16:09:36.000000000","message":"please write a proper commit message","commit_id":"9be571f00c756dcfaf717e5178b53280097c3e1a"}],"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"e620474ea69899a36fc15e0eda496af35b18d8f0","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class DiskReadLatencyPollster(PerDeviceDiskPollster):"},{"line_number":243,"context_line":"    inspector_method \u003d \u0027inspect_disk_rw_latency\u0027"},{"line_number":244,"context_line":"    sample_name \u003d \u0027disk.read.latency\u0027"},{"line_number":245,"context_line":"    sample_unit \u003d \u0027ms\u0027"},{"line_number":246,"context_line":"    sample_stats_key \u003d \u0027rd_total_times\u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"df3967d1_e79ffd00","line":243,"updated":"2017-08-02 08:10:02.000000000","message":"I\u0027m going to deprecated non \"device\" libvirt metric. See https://review.openstack.org/#/c/481193/\n\nSo only add disk.device.XXX metrics.","commit_id":"e0caa09c07c28b7fa4df99ed6337a69d42aea8d8"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"33fec24b9b99305084d81bc3d20c06760cb88a8a","unresolved":false,"context_lines":[{"line_number":240,"context_line":""},{"line_number":241,"context_line":""},{"line_number":242,"context_line":"class PerDeviceDiskReadLatencyPollster(PerDeviceDiskPollster):"},{"line_number":243,"context_line":"    inspector_method \u003d \u0027inspect_disk_device_rw_latency\u0027"},{"line_number":244,"context_line":"    sample_name \u003d \u0027disk.device.read.latency\u0027"},{"line_number":245,"context_line":"    sample_unit \u003d \u0027ms\u0027"},{"line_number":246,"context_line":"    sample_stats_key \u003d \u0027rd_total_times\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_43595d58","line":243,"range":{"start_line":243,"start_character":37,"end_line":243,"end_character":43},"updated":"2017-08-09 09:58:10.000000000","message":"no need","commit_id":"22361697a6f8773597d454eff40d718c52d4999d"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"33fec24b9b99305084d81bc3d20c06760cb88a8a","unresolved":false,"context_lines":[{"line_number":243,"context_line":"    inspector_method \u003d \u0027inspect_disk_device_rw_latency\u0027"},{"line_number":244,"context_line":"    sample_name \u003d \u0027disk.device.read.latency\u0027"},{"line_number":245,"context_line":"    sample_unit \u003d \u0027ms\u0027"},{"line_number":246,"context_line":"    sample_stats_key \u003d \u0027rd_total_times\u0027"},{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class PerDeviceDiskWriteLatencyPollster(PerDeviceDiskPollster):"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_232bf994","line":246,"range":{"start_line":246,"start_character":24,"end_line":246,"end_character":38},"updated":"2017-08-09 09:58:10.000000000","message":"How do you think write to \u0027rd_total_time\u0027? i feel it may confuse someone using total times. :)","commit_id":"22361697a6f8773597d454eff40d718c52d4999d"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"33fec24b9b99305084d81bc3d20c06760cb88a8a","unresolved":false,"context_lines":[{"line_number":247,"context_line":""},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"class PerDeviceDiskWriteLatencyPollster(PerDeviceDiskPollster):"},{"line_number":250,"context_line":"    inspector_method \u003d \u0027inspect_disk_device_rw_latency\u0027"},{"line_number":251,"context_line":"    sample_name \u003d \u0027disk.device.write.latency\u0027"},{"line_number":252,"context_line":"    sample_unit \u003d \u0027ms\u0027"},{"line_number":253,"context_line":"    sample_stats_key \u003d \u0027wr_total_times\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_e31e116f","line":250,"range":{"start_line":250,"start_character":37,"end_line":250,"end_character":43},"updated":"2017-08-09 09:58:10.000000000","message":"no need","commit_id":"22361697a6f8773597d454eff40d718c52d4999d"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"33fec24b9b99305084d81bc3d20c06760cb88a8a","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    inspector_method \u003d \u0027inspect_disk_device_rw_latency\u0027"},{"line_number":251,"context_line":"    sample_name \u003d \u0027disk.device.write.latency\u0027"},{"line_number":252,"context_line":"    sample_unit \u003d \u0027ms\u0027"},{"line_number":253,"context_line":"    sample_stats_key \u003d \u0027wr_total_times\u0027"}],"source_content_type":"text/x-python","patch_set":12,"id":"9f436f4f_a3180981","line":253,"range":{"start_line":253,"start_character":24,"end_line":253,"end_character":38},"updated":"2017-08-09 09:58:10.000000000","message":"wr_total_time ?","commit_id":"22361697a6f8773597d454eff40d718c52d4999d"}],"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"40e88692fabfb547009757d0ec397ae6f7c94828","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                bool,"},{"line_number":165,"context_line":"                [target.get(\"dev\")"},{"line_number":166,"context_line":"                 for target in tree.findall(\u0027devices/disk/target\u0027)]):"},{"line_number":167,"context_line":"            block_stats_flags \u003d domain.blockStatsFlags(device, 0)"},{"line_number":168,"context_line":"            yield virt_inspector.DiskStatsFlags("},{"line_number":169,"context_line":"                device\u003ddevice,"},{"line_number":170,"context_line":"                wr_total_times\u003dblock_stats_flags[\u0027wr_total_times\u0027]*1.0/1000,"}],"source_content_type":"text/x-python","patch_set":13,"id":"9f436f4f_49b28096","line":167,"range":{"start_line":167,"start_character":39,"end_line":167,"end_character":54},"updated":"2017-08-10 07:51:53.000000000","message":"1. rd_operations, rd_bytes, wr_operations, wr_bytes, flush_operations, do not need to convert to K?\n2. some fields are duplicated with blockStats, discard unused fields?","commit_id":"64dc5c0053a5e44b010edc447a01a2928fabae6a"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"e11d9f6565ddd621d42d7ff6c412c6f42ad45e07","unresolved":false,"context_lines":[{"line_number":120,"context_line":"                bool,"},{"line_number":121,"context_line":"                [target.get(\"dev\")"},{"line_number":122,"context_line":"                 for target in tree.findall(\u0027devices/disk/target\u0027)]):"},{"line_number":123,"context_line":"            block_stats \u003d domain.blockStats(device)"},{"line_number":124,"context_line":"            yield virt_inspector.DiskStats(device\u003ddevice,"},{"line_number":125,"context_line":"                                           read_requests\u003dblock_stats[0],"},{"line_number":126,"context_line":"                                           read_bytes\u003dblock_stats[1],"}],"source_content_type":"text/x-python","patch_set":14,"id":"9f436f4f_2ca5f3b5","line":123,"updated":"2017-08-10 21:43:33.000000000","message":"i would just change this to blockStatsFlags and add the new *_total_times values to DiskStats","commit_id":"eac479b1d8841adafd4997dd81aa84060c594275"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fd3a080235a736e07e0fed4d9ba7622823759c00","unresolved":false,"context_lines":[{"line_number":123,"context_line":"            block_stats \u003d domain.blockStats(device)"},{"line_number":124,"context_line":"            block_stats_flags \u003d domain.blockStatsFlags(device, 0)"},{"line_number":125,"context_line":"            wr_times \u003d block_stats_flags[\u0027wr_total_times\u0027]*1.0/1000"},{"line_number":126,"context_line":"            rd_times \u003d block_stats_flags[\u0027rd_total_times\u0027]*1.0/1000"},{"line_number":127,"context_line":"            yield virt_inspector.DiskStats(device\u003ddevice,"},{"line_number":128,"context_line":"                                           read_requests\u003dblock_stats[0],"},{"line_number":129,"context_line":"                                           read_bytes\u003dblock_stats[1],"}],"source_content_type":"text/x-python","patch_set":19,"id":"7f287b81_b2b926ea","line":126,"updated":"2017-08-25 15:36:10.000000000","message":"can you add a note why we have \"* 1.0 / 1000\"","commit_id":"ed67c2bd3a5e1c4034a1f8a59761861f6eb0fc7d"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"fd3a080235a736e07e0fed4d9ba7622823759c00","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            wr_times \u003d block_stats_flags[\u0027wr_total_times\u0027]*1.0/1000"},{"line_number":126,"context_line":"            rd_times \u003d block_stats_flags[\u0027rd_total_times\u0027]*1.0/1000"},{"line_number":127,"context_line":"            yield virt_inspector.DiskStats(device\u003ddevice,"},{"line_number":128,"context_line":"                                           read_requests\u003dblock_stats[0],"},{"line_number":129,"context_line":"                                           read_bytes\u003dblock_stats[1],"},{"line_number":130,"context_line":"                                           write_requests\u003dblock_stats[2],"},{"line_number":131,"context_line":"                                           write_bytes\u003dblock_stats[3],"},{"line_number":132,"context_line":"                                           errors\u003dblock_stats[4],"},{"line_number":133,"context_line":"                                           wr_total_times\u003dwr_times,"},{"line_number":134,"context_line":"                                           rd_total_times\u003drd_times)"},{"line_number":135,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"7f287b81_521c4211","line":132,"range":{"start_line":128,"start_character":0,"end_line":132,"end_character":64},"updated":"2017-08-25 15:36:10.000000000","message":"this can probably use blockstatsflag as well but i\u0027m ok with doing this in another patch.","commit_id":"ed67c2bd3a5e1c4034a1f8a59761861f6eb0fc7d"}]}