)]}'
{"ceilometer/hardware/discovery.py":[{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"55588028f63a0124c2618509e4d656588b6ebbfc","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                # is a cheap detection if ironic node deployed by tripleo, but"},{"line_number":115,"context_line":"                # nova don\u0027t expose anything more useful and we must not log a"},{"line_number":116,"context_line":"                # ERROR when the instance is not a tripleo undercloud one."},{"line_number":117,"context_line":"                self.instances.pop(instance.id, None)"},{"line_number":118,"context_line":"                continue"},{"line_number":119,"context_line":"            try:"},{"line_number":120,"context_line":"                ip_address \u003d addresses[0].get(\u0027addr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_907d2d70","line":117,"updated":"2017-08-21 07:31:34.000000000","message":"I don\u0027t think it\u0027s necessary. I\u0027m pretty sure the instance will not use any more. HDYT?","commit_id":"8d5079131af339849f863ae78933aa7ffe316581"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"043518f8d3bcd0cf37053bf2a7438d05a1f7147b","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                # is a cheap detection if ironic node deployed by tripleo, but"},{"line_number":115,"context_line":"                # nova don\u0027t expose anything more useful and we must not log a"},{"line_number":116,"context_line":"                # ERROR when the instance is not a tripleo undercloud one."},{"line_number":117,"context_line":"                self.instances.pop(instance.id, None)"},{"line_number":118,"context_line":"                continue"},{"line_number":119,"context_line":"            try:"},{"line_number":120,"context_line":"                ip_address \u003d addresses[0].get(\u0027addr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_0cea210e","line":117,"in_reply_to":"9f436f4f_46402f36","updated":"2017-08-25 14:33:16.000000000","message":"agree with Hanxi Liu. also, i don\u0027t think this is safe in python3 since .values should return generator iirc.","commit_id":"8d5079131af339849f863ae78933aa7ffe316581"},{"author":{"_account_id":22752,"name":"Hanxi Liu","email":"apolloliuhx@gmail.com","username":"Hanxi_Liu"},"change_message_id":"ffdd6933f731edf329162b93c975750a3b4041a7","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                # is a cheap detection if ironic node deployed by tripleo, but"},{"line_number":115,"context_line":"                # nova don\u0027t expose anything more useful and we must not log a"},{"line_number":116,"context_line":"                # ERROR when the instance is not a tripleo undercloud one."},{"line_number":117,"context_line":"                self.instances.pop(instance.id, None)"},{"line_number":118,"context_line":"                continue"},{"line_number":119,"context_line":"            try:"},{"line_number":120,"context_line":"                ip_address \u003d addresses[0].get(\u0027addr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_46402f36","line":117,"in_reply_to":"9f436f4f_705e4977","updated":"2017-08-21 08:46:19.000000000","message":"I agree with your concern, but you can see it won\u0027t add this to resources list.","commit_id":"8d5079131af339849f863ae78933aa7ffe316581"},{"author":{"_account_id":26185,"name":"wenbin luo","email":"wbluo@fiberhome.com","username":"wbluo0907"},"change_message_id":"2e8d93823159a524c16173d707315d01c70f6e99","unresolved":false,"context_lines":[{"line_number":114,"context_line":"                # is a cheap detection if ironic node deployed by tripleo, but"},{"line_number":115,"context_line":"                # nova don\u0027t expose anything more useful and we must not log a"},{"line_number":116,"context_line":"                # ERROR when the instance is not a tripleo undercloud one."},{"line_number":117,"context_line":"                self.instances.pop(instance.id, None)"},{"line_number":118,"context_line":"                continue"},{"line_number":119,"context_line":"            try:"},{"line_number":120,"context_line":"                ip_address \u003d addresses[0].get(\u0027addr\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f436f4f_705e4977","line":117,"in_reply_to":"9f436f4f_907d2d70","updated":"2017-08-21 08:02:05.000000000","message":"Such instances will exists in self.instances unless the state is deleted or error. If there is a lot of such instances and doesn\u0027t removed it from self.instances, it will waste CPU time for every discover.","commit_id":"8d5079131af339849f863ae78933aa7ffe316581"}]}