)]}'
{"ceilometer/tests/alarm/partition/test_coordination.py":[{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"575f193ac833254fc84a6755299da9916a74b9b8","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":392,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test__record_oldest(self):"},{"line_number":395,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9iGI%3D","line":394,"updated":"2013-12-10 14:35:37.000000000","message":"Supposed to be two underscores? (probably follow-up clean up branch to gain functionality)","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"94dc358d5b471009cd45cd12c9999958d5def74b","unresolved":false,"context_lines":[{"line_number":391,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":392,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def test__record_oldest(self):"},{"line_number":395,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9iBs%3D","line":394,"in_reply_to":"AAAATn%2F9iGI%3D","updated":"2013-12-10 14:39:31.000000000","message":"this is to test the private method, the method name does have the underscore to start with.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"b9210f518ce5fe4ee074296733aa61b752614f20","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":398,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9iCU%3D","line":399,"updated":"2013-12-10 14:41:27.000000000","message":"Am I right that using Exception as side_effect you prove that method was called? If yes, it\u0027s better to use call_count (http://www.voidspace.org.uk/python/mock/mock.html#mock.Mock.call_count). The same comment for test_report_presence and test_assigned_alarms.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"f910e30e8c509f9aa2cb14ff7b2f5d8df4cd0fc2","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":398,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9hyU%3D","line":399,"in_reply_to":"AAAATn%2F9h0Q%3D","updated":"2013-12-10 15:17:27.000000000","message":"Ok, sorry for misunderstanding!","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"71b9ac9958be54a7918cfb2cecce82d5a04e4ef4","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":398,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9hmE%3D","line":399,"in_reply_to":"AAAATn%2F9hyU%3D","updated":"2013-12-10 18:34:11.000000000","message":"hmm, since it\u0027s not actually testing the logic of method rather just that an exception is caught, it\u0027d be better to rename these tests.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"57b776544e7a2a0514d1ec44d0c162feb5e20aaa","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":397,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":398,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9h0Q%3D","line":399,"in_reply_to":"AAAATn%2F9iCU%3D","updated":"2013-12-10 15:12:12.000000000","message":"not at all. It is to cause an exception and make sure that the catch clause\nget executed so that that branch of code gets tested as well. call_count\ncan not help in this case.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"2c298ad2d6306d0be6ea2c5c3d79e58527791247","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("},{"line_number":403,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":404,"context_line":"        self.partition_coordinator.check_mastership(10, None)"},{"line_number":405,"context_line":"        self.assertTrue(\u0027mastership check failed\u0027 in self.output.getvalue())"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9mLM%3D","line":402,"updated":"2013-12-09 20:41:05.000000000","message":"Should you also verify the method _is_master is called?","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"21895299cb380c1beba9fdc048c2c8525b992893","unresolved":false,"context_lines":[{"line_number":399,"context_line":""},{"line_number":400,"context_line":"    def test_check_mastership(self):"},{"line_number":401,"context_line":"        # Test the method exception condition."},{"line_number":402,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("},{"line_number":403,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":404,"context_line":"        self.partition_coordinator.check_mastership(10, None)"},{"line_number":405,"context_line":"        self.assertTrue(\u0027mastership check failed\u0027 in self.output.getvalue())"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9iNE%3D","line":402,"in_reply_to":"AAAATn%2F9mLM%3D","updated":"2013-12-10 14:12:58.000000000","message":"That is what the next couple of lines do. If it does not, then there is no way\nto get the exception.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"2c298ad2d6306d0be6ea2c5c3d79e58527791247","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_report_presence(self):"},{"line_number":408,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("},{"line_number":409,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":410,"context_line":"        self.partition_coordinator.report_presence()"},{"line_number":411,"context_line":"        self.assertTrue(\u0027presence reporting failed\u0027 in self.output.getvalue())"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9mKw%3D","line":409,"updated":"2013-12-09 20:41:05.000000000","message":"should you also verify method presence is called?","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"21895299cb380c1beba9fdc048c2c8525b992893","unresolved":false,"context_lines":[{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test_report_presence(self):"},{"line_number":408,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("},{"line_number":409,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":410,"context_line":"        self.partition_coordinator.report_presence()"},{"line_number":411,"context_line":"        self.assertTrue(\u0027presence reporting failed\u0027 in self.output.getvalue())"},{"line_number":412,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAATn%2F9iMs%3D","line":409,"in_reply_to":"AAAATn%2F9mKw%3D","updated":"2013-12-10 14:12:58.000000000","message":"same as the above.","commit_id":"b1f02b56f0cd52c5c60a961213d47414b32c8ba1"}],"tests/alarm/partition/test_coordination.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"2bf87ed19648cc842b5fa5366332effdaf497856","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.id_2nd \u003d coordination.PartitionIdentity(str(uuid.uuid4()), 2)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d self.id_2nd)"},{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F%2BI8%3D","line":41,"updated":"2013-10-07 09:21:11.000000000","message":"Use assertEqual and stuff","commit_id":"4979654c93d5f430d77b8f09f1ad68e1c47bd511"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"5ca497f7f960f811ec0fd01df88b981416b3a15c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.id_2nd \u003d coordination.PartitionIdentity(str(uuid.uuid4()), 2)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d self.id_2nd)"},{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9Vk%3D","line":41,"in_reply_to":"AAAATH%2F%2F%2BI8%3D","updated":"2013-10-07 13:57:19.000000000","message":"Julien, this is to test operators of the class, I wish to use these set of\noperators. These statements look unified and very clear.","commit_id":"4979654c93d5f430d77b8f09f1ad68e1c47bd511"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"87def2ab3cc062e89f2cd88a7352c4a4df7ed48d","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.id_2nd \u003d coordination.PartitionIdentity(str(uuid.uuid4()), 2)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d self.id_2nd)"},{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9BY%3D","line":41,"in_reply_to":"AAAATH%2F%2F9K0%3D","updated":"2013-10-07 15:02:56.000000000","message":"ok. that is fine, I can change that. thanks.","commit_id":"4979654c93d5f430d77b8f09f1ad68e1c47bd511"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"1619e9ae1f147e05a1016cd4ba4ac42189e3e79c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        self.id_2nd \u003d coordination.PartitionIdentity(str(uuid.uuid4()), 2)"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertFalse(self.id_1st \u003d\u003d self.id_2nd)"},{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATH%2F%2F9K0%3D","line":41,"in_reply_to":"AAAATH%2F%2F9Vk%3D","updated":"2013-10-07 14:26:46.000000000","message":"I see what you mean, but especially if one of these tests start to fail, it\u0027s going to be a nightmare to debug unless the right assertXXXX are used. I don\u0027t think it\u0027d be a problem to change that. :)","commit_id":"4979654c93d5f430d77b8f09f1ad68e1c47bd511"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"dddae879d7675b79fd91d71167d8b1eb3ce58da0","unresolved":false,"context_lines":[{"line_number":405,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":406,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"    def test__record_oldest(self):"},{"line_number":409,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":410,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":411,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fwxw%3D","line":408,"updated":"2013-10-10 07:12:32.000000000","message":"Since, this only test the \"stale\" flow of the function _record_oldest, how about append the method name with the appendix \"_stale\"?","commit_id":"494d5f122373028424ebfe2a9de062d62e5ed687"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"dddae879d7675b79fd91d71167d8b1eb3ce58da0","unresolved":false,"context_lines":[{"line_number":411,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":412,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":413,"context_line":""},{"line_number":414,"context_line":"    def test_check_mastership(self):"},{"line_number":415,"context_line":"        # Test the method exception condition."},{"line_number":416,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("},{"line_number":417,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2FwxM%3D","line":414,"updated":"2013-10-10 07:12:32.000000000","message":"how about append the method name with \"_exception\" for better understanding?","commit_id":"494d5f122373028424ebfe2a9de062d62e5ed687"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"dddae879d7675b79fd91d71167d8b1eb3ce58da0","unresolved":false,"context_lines":[{"line_number":418,"context_line":"        self.partition_coordinator.check_mastership(10, None)"},{"line_number":419,"context_line":"        self.assertTrue(\u0027mastership check failed\u0027 in self.output.getvalue())"},{"line_number":420,"context_line":""},{"line_number":421,"context_line":"    def test_report_presence(self):"},{"line_number":422,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("},{"line_number":423,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":424,"context_line":"        self.partition_coordinator.report_presence()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fww4%3D","line":421,"updated":"2013-10-10 07:12:32.000000000","message":"append \"_exception\" to method name?","commit_id":"494d5f122373028424ebfe2a9de062d62e5ed687"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"dddae879d7675b79fd91d71167d8b1eb3ce58da0","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        self.partition_coordinator.report_presence()"},{"line_number":425,"context_line":"        self.assertTrue(\u0027presence reporting failed\u0027 in self.output.getvalue())"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"    def test_assigned_alarms(self):"},{"line_number":428,"context_line":"        api_client \u003d mock.MagicMock()"},{"line_number":429,"context_line":"        api_client.alarms \u003d mock.Mock(side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":430,"context_line":"        self.partition_coordinator.assignment \u003d [\u0027something\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATH%2F%2Fwws%3D","line":427,"updated":"2013-10-10 07:12:32.000000000","message":"append \"_exception\" to method name?","commit_id":"494d5f122373028424ebfe2a9de062d62e5ed687"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7f7a6ad2a24f2d7a78fe2b889a8fad3b530c48d0","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"},{"line_number":45,"context_line":"        self.assertFalse(self.id_1st \u003c \u0027Nothing\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(self.id_2nd \u003e self.id_1st)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestCoordinate(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FkZ4%3D","line":46,"updated":"2013-10-14 12:47:59.000000000","message":"Still not fixed.","commit_id":"1ed831e16bd7e6c9fcd434bb60f6cc12e3816581"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"4ef030df60d1ba8816eee9e21c2db418611230b4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        self.assertTrue(self.id_1st !\u003d self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"},{"line_number":45,"context_line":"        self.assertFalse(self.id_1st \u003c \u0027Nothing\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(self.id_2nd \u003e self.id_1st)"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"class TestCoordinate(base.TestCase):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATH%2F%2FIuY%3D","line":46,"in_reply_to":"AAAATH%2F%2FkZ4%3D","updated":"2013-10-22 17:08:32.000000000","message":"Julien, if you look for assertLess, then it is not available in python 2.7, so we\nneed to use what I have here.","commit_id":"1ed831e16bd7e6c9fcd434bb60f6cc12e3816581"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"c000dbd41ee69f0e05d92ef34c5bf34a79d65f1b","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertNotEqual(self.id_1st, \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertNotEqual(self.id_1st, self.id_2nd)"},{"line_number":43,"context_line":"        self.assertNotEqual(self.id_1st, self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"},{"line_number":45,"context_line":"        self.assertFalse(self.id_1st \u003c \u0027Nothing\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(self.id_2nd \u003e self.id_1st)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATX%2F%2F%2B8Y%3D","line":43,"updated":"2013-10-23 09:52:27.000000000","message":"This line is duplicate","commit_id":"719f5f2b6af4ca243760bfd920f31cc25c626210"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"ea007a30335f20ebff5a7c4bcfc4531b6cf8c519","unresolved":false,"context_lines":[{"line_number":40,"context_line":"    def test_identity_ops(self):"},{"line_number":41,"context_line":"        self.assertNotEqual(self.id_1st, \u0027Nothing\u0027)"},{"line_number":42,"context_line":"        self.assertNotEqual(self.id_1st, self.id_2nd)"},{"line_number":43,"context_line":"        self.assertNotEqual(self.id_1st, self.id_2nd)"},{"line_number":44,"context_line":"        self.assertTrue(self.id_1st \u003c None)"},{"line_number":45,"context_line":"        self.assertFalse(self.id_1st \u003c \u0027Nothing\u0027)"},{"line_number":46,"context_line":"        self.assertTrue(self.id_2nd \u003e self.id_1st)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAATn%2F%2F5vA%3D","line":43,"in_reply_to":"AAAATX%2F%2F%2B8Y%3D","updated":"2013-10-25 13:38:31.000000000","message":"will remove it in new patch set. thanks.","commit_id":"719f5f2b6af4ca243760bfd920f31cc25c626210"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fe96b961f93de741c168c544d780de368e87da9f","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":405,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test__record_oldest(self):"},{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F5Xg%3D","line":407,"updated":"2013-10-25 15:21:02.000000000","message":"any reason for extra _?","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"b2014f4f678db8d4334f770cbcb1c38c2fe8db96","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":405,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test__record_oldest(self):"},{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F0ds%3D","line":407,"in_reply_to":"AAAATn%2F%2F3KU%3D","updated":"2013-10-28 14:16:49.000000000","message":"I see","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a7a955d469b7daf3beb3f9ddd725bf6f7aaf1ce9","unresolved":false,"context_lines":[{"line_number":404,"context_line":"        alarms \u003d self.partition_coordinator.assigned_alarms(self.api_client)"},{"line_number":405,"context_line":"        self.assertEqual(alarms, self._current_alarms())"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def test__record_oldest(self):"},{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F3KU%3D","line":407,"in_reply_to":"AAAATn%2F%2F5Xg%3D","updated":"2013-10-26 12:12:37.000000000","message":"the method being tested starts with _, from that naming style, you can see\nthat is to test the private method.","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fe96b961f93de741c168c544d780de368e87da9f","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":411,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def test_check_mastership(self):"},{"line_number":414,"context_line":"        # Test the method exception condition."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F5Wo%3D","line":411,"updated":"2013-10-25 15:21:02.000000000","message":"Suggest use assertisNone","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"b2014f4f678db8d4334f770cbcb1c38c2fe8db96","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":411,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def test_check_mastership(self):"},{"line_number":414,"context_line":"        # Test the method exception condition."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F0cc%3D","line":411,"in_reply_to":"AAAATn%2F%2F3KM%3D","updated":"2013-10-28 14:16:49.000000000","message":"true, good point","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a7a955d469b7daf3beb3f9ddd725bf6f7aaf1ce9","unresolved":false,"context_lines":[{"line_number":408,"context_line":"        # Test when the partition to be recorded is the same as the oldest."},{"line_number":409,"context_line":"        self.partition_coordinator._record_oldest("},{"line_number":410,"context_line":"            self.partition_coordinator.oldest, True)"},{"line_number":411,"context_line":"        self.assertEqual(self.partition_coordinator.oldest, None)"},{"line_number":412,"context_line":""},{"line_number":413,"context_line":"    def test_check_mastership(self):"},{"line_number":414,"context_line":"        # Test the method exception condition."}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F3KM%3D","line":411,"in_reply_to":"AAAATn%2F%2F5Wo%3D","updated":"2013-10-26 12:12:37.000000000","message":"well, unfortunately, it is only started available since 2.7. We have to support\n2.6 as well. You do not want to break Jenkins by using only 2.7 or newer\nfeatures.","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fe96b961f93de741c168c544d780de368e87da9f","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("},{"line_number":416,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":417,"context_line":"        self.partition_coordinator.check_mastership(10, None)"},{"line_number":418,"context_line":"        self.assertTrue(\u0027mastership check failed\u0027 in self.output.getvalue())"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def test_report_presence(self):"},{"line_number":421,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F5V4%3D","line":418,"updated":"2013-10-25 15:21:02.000000000","message":"suggest assertIn","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a7a955d469b7daf3beb3f9ddd725bf6f7aaf1ce9","unresolved":false,"context_lines":[{"line_number":415,"context_line":"        self.partition_coordinator._is_master \u003d mock.Mock("},{"line_number":416,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":417,"context_line":"        self.partition_coordinator.check_mastership(10, None)"},{"line_number":418,"context_line":"        self.assertTrue(\u0027mastership check failed\u0027 in self.output.getvalue())"},{"line_number":419,"context_line":""},{"line_number":420,"context_line":"    def test_report_presence(self):"},{"line_number":421,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F3KI%3D","line":418,"in_reply_to":"AAAATn%2F%2F5V4%3D","updated":"2013-10-26 12:12:37.000000000","message":"assertIn only available in 2.7","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fe96b961f93de741c168c544d780de368e87da9f","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("},{"line_number":422,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":423,"context_line":"        self.partition_coordinator.report_presence()"},{"line_number":424,"context_line":"        self.assertTrue(\u0027presence reporting failed\u0027 in self.output.getvalue())"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_assigned_alarms(self):"},{"line_number":427,"context_line":"        api_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F5Vw%3D","line":424,"updated":"2013-10-25 15:21:02.000000000","message":"suggest assertIn","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a7a955d469b7daf3beb3f9ddd725bf6f7aaf1ce9","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        self.partition_coordinator.coordination_rpc.presence \u003d mock.Mock("},{"line_number":422,"context_line":"            side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":423,"context_line":"        self.partition_coordinator.report_presence()"},{"line_number":424,"context_line":"        self.assertTrue(\u0027presence reporting failed\u0027 in self.output.getvalue())"},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"    def test_assigned_alarms(self):"},{"line_number":427,"context_line":"        api_client \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F3KE%3D","line":424,"in_reply_to":"AAAATn%2F%2F5Vw%3D","updated":"2013-10-26 12:12:37.000000000","message":"assertIn only available in 2.7","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"fe96b961f93de741c168c544d780de368e87da9f","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        api_client.alarms \u003d mock.Mock(side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":429,"context_line":"        self.partition_coordinator.assignment \u003d [\u0027something\u0027]"},{"line_number":430,"context_line":"        self.partition_coordinator.assigned_alarms(api_client)"},{"line_number":431,"context_line":"        self.assertTrue(\u0027assignment retrieval failed\u0027 in"},{"line_number":432,"context_line":"                        self.output.getvalue())"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F5Vs%3D","line":431,"updated":"2013-10-25 15:21:02.000000000","message":"suggest assertIn","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"a7a955d469b7daf3beb3f9ddd725bf6f7aaf1ce9","unresolved":false,"context_lines":[{"line_number":428,"context_line":"        api_client.alarms \u003d mock.Mock(side_effect\u003dException(\u0027Boom!\u0027))"},{"line_number":429,"context_line":"        self.partition_coordinator.assignment \u003d [\u0027something\u0027]"},{"line_number":430,"context_line":"        self.partition_coordinator.assigned_alarms(api_client)"},{"line_number":431,"context_line":"        self.assertTrue(\u0027assignment retrieval failed\u0027 in"},{"line_number":432,"context_line":"                        self.output.getvalue())"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAATn%2F%2F3KA%3D","line":431,"in_reply_to":"AAAATn%2F%2F5Vs%3D","updated":"2013-10-26 12:12:37.000000000","message":"assertIn only available in 2.7","commit_id":"d575d80d5398f6e7e4f0e7daff58658a907e685c"}]}