)]}'
{"id":"openstack%2Fceilometer~50708","triplet_id":"openstack%2Fceilometer~master~I1adae8c899112e7c3eb4e94f3f68262c84a98574","project":"openstack/ceilometer","branch":"master","hashtags":[],"change_id":"I1adae8c899112e7c3eb4e94f3f68262c84a98574","subject":"Avoid leaking admin-ness into threshold-oriented alarms","status":"MERGED","created":"2013-10-09 18:36:59.000000000","updated":"2013-10-11 20:24:09.000000000","submitted":"2013-10-11 20:24:09.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":18,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"07c0cc8889a68019d30283b0747b32a04d78f50b","_number":50708,"virtual_id_number":50708,"owner":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2013-10-11 20:24:09.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":1,"date":"2013-10-11 11:16:45.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},{"value":0,"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":2,"date":"2013-10-11 13:42:13.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-10-11 12:08:57.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},{"value":0,"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":2,"date":"2013-10-10 17:11:39.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-10-11 13:42:13.000000000","_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},{"value":0,"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"value":0,"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"date":"2013-10-10 17:11:39.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-10-10 00:56:51.000000000","updated_by":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"reviewer":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"state":"REVIEWER"},{"updated":"2013-10-10 03:50:06.000000000","updated_by":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"reviewer":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"state":"REVIEWER"},{"updated":"2013-10-10 17:11:39.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2013-10-11 11:16:45.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-10-11 12:08:57.000000000","updated_by":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"reviewer":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"state":"REVIEWER"},{"updated":"2013-10-11 13:42:13.000000000","updated_by":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"reviewer":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"state":"REVIEWER"},{"updated":"2013-10-11 20:24:09.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"5e00115b882606a3a786f57af4067ea3d6cd9f78","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-09 19:24:22.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/08/50708/1/check/gate-ceilometer-pep8/9635bff : SUCCESS in 1m 16s\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/50708/1/check/gate-ceilometer-docs/2e5850c/doc/build/html/ : SUCCESS in 3m 03s\n- gate-ceilometer-python26 http://logs.openstack.org/08/50708/1/check/gate-ceilometer-python26/cb7b0bf : SUCCESS in 7m 41s\n- gate-ceilometer-python27 http://logs.openstack.org/08/50708/1/check/gate-ceilometer-python27/529def0 : SUCCESS in 7m 00s\n- check-tempest-devstack-vm-full http://logs.openstack.org/08/50708/1/check/check-tempest-devstack-vm-full/389f38a : SUCCESS in 43m 02s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/50708/1/check/check-tempest-devstack-vm-postgres-full/3af147b : SUCCESS in 30m 34s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/08/50708/1/check/check-tempest-devstack-vm-neutron/e395513 : SUCCESS in 38m 42s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/50708/1/check/gate-tempest-devstack-vm-large-ops/994df69 : SUCCESS in 13m 25s\n- check-swift-devstack-vm-functional http://logs.openstack.org/08/50708/1/check/check-swift-devstack-vm-functional/5327eed : SUCCESS in 12m 17s\n","accounts_in_message":[],"_revision_number":1},{"id":"cca79a1a6f302dae85f9105931dc7f1ea4881d25","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-09 19:28:24.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"4fbe4fa1935d9a68f6112b6640abf8deaf99b587","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-10-09 19:28:32.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"bf0fbcb23bf0d1a13322f11bdada43f9b6a7c3fe","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-09 20:09:29.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/08/50708/2/check/gate-ceilometer-pep8/3840a6a : SUCCESS in 1m 26s\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/50708/2/check/gate-ceilometer-docs/c7c4ec4/doc/build/html/ : SUCCESS in 2m 18s\n- gate-ceilometer-python26 http://logs.openstack.org/08/50708/2/check/gate-ceilometer-python26/ff0da27 : SUCCESS in 10m 03s\n- gate-ceilometer-python27 http://logs.openstack.org/08/50708/2/check/gate-ceilometer-python27/9226366 : SUCCESS in 4m 01s\n- check-tempest-devstack-vm-full http://logs.openstack.org/08/50708/2/check/check-tempest-devstack-vm-full/a72fd8d : SUCCESS in 40m 53s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/50708/2/check/check-tempest-devstack-vm-postgres-full/3c1a165 : SUCCESS in 39m 02s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/08/50708/2/check/check-tempest-devstack-vm-neutron/69baad6 : SUCCESS in 25m 37s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/50708/2/check/gate-tempest-devstack-vm-large-ops/3910fc8 : SUCCESS in 20m 02s\n- check-swift-devstack-vm-functional http://logs.openstack.org/08/50708/2/check/check-swift-devstack-vm-functional/af643ce : SUCCESS in 15m 18s\n","accounts_in_message":[],"_revision_number":2},{"id":"0cb97adf0224e89fa0d5c9b26036a77819c0a50d","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2013-10-10 00:56:51.000000000","message":"Patch Set 2:\n\neglynn is there any way you can separate out the rework of validate from the bug? (2 patches rather that one) it makes it easier to review when each patch is simple.","accounts_in_message":[],"_revision_number":2},{"id":"15ccd4a12537bd299ffab5a362ccb9d90864949f","author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"date":"2013-10-10 03:50:06.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"fc52fbc4b591ef92ee6923cdb0167bf74f66ace4","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-10 06:31:47.000000000","message":"Patch Set 2: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"60c55e342c3f76df3a956fed64d64733942664cd","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 07:09:48.000000000","message":"Patch Set 2: (4 inline comments)\n\n@llu \u0026 @sileht:\n\nThanks for the reviews, responses inline.\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":2},{"id":"4bfd89608effdf4898d61fe7538348ed47ea42e7","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 07:10:53.000000000","message":"Patch Set 2:\n\n@asalkeld: hmmm, the rework in the sense of the separation of validation from modification was pretty central to the fix (in my understanding at least).\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":2},{"id":"707b560d4213f70b33042fc9e1418c6b19d40fe8","author":{"_account_id":4715,"name":"Angus Salkeld","email":"asalkeld@redhat.com","username":"asalkeld"},"date":"2013-10-10 10:15:10.000000000","message":"Patch Set 2: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"6ca845b0dd2826df32f3b216e03cba04490ba310","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-10 12:14:35.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\n(3 inline comments)\n\n","accounts_in_message":[],"_revision_number":2},{"id":"ae113e79c3d70b0cbd3d545703b403f5900ecebc","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 14:59:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"ece8eb413ece530f090f292d800059d39a8ffc2c","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 15:01:00.000000000","message":"Patch Set 2: (3 inline comments)\n\n@jd__: thanks for the review, responses inline.\n\nCheers,\nEoghan","accounts_in_message":[],"_revision_number":2},{"id":"83e3c564af99aab86c4c0e1d359af601ef8a847d","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-10 15:11:59.000000000","message":"Patch Set 3: (2 inline comments)\n\nlgfm, just two tiny comments.","accounts_in_message":[],"_revision_number":3},{"id":"1d823a1b9ef9aede334c03ecf3879e3e330ac0e1","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 15:17:08.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f082d938f0ab985c4062454250b4eba3a6727654","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 15:17:24.000000000","message":"Patch Set 3: (2 inline comments)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"6c555734fae54bb4f290448dc45a1a898c519933","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-10-10 15:33:57.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"ea06a5a207823d6056414daa97453c7be6fef667","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-10 16:36:19.000000000","message":"Patch Set 5: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/08/50708/5/check/gate-ceilometer-pep8/cad36b7 : SUCCESS in 1m 14s\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/50708/5/check/gate-ceilometer-docs/80676f5/doc/build/html/ : SUCCESS in 3m 45s\n- gate-ceilometer-python26 http://logs.openstack.org/08/50708/5/check/gate-ceilometer-python26/f29e07e : SUCCESS in 10m 16s\n- gate-ceilometer-python27 http://logs.openstack.org/08/50708/5/check/gate-ceilometer-python27/a20945a : SUCCESS in 3m 22s\n- check-tempest-devstack-vm-full http://logs.openstack.org/08/50708/5/check/check-tempest-devstack-vm-full/31954e3 : SUCCESS in 49m 01s\n- check-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/50708/5/check/check-tempest-devstack-vm-postgres-full/8d72fd4 : SUCCESS in 43m 10s\n- check-tempest-devstack-vm-neutron http://logs.openstack.org/08/50708/5/check/check-tempest-devstack-vm-neutron/24d1b8d : SUCCESS in 19m 49s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/50708/5/check/gate-tempest-devstack-vm-large-ops/449ed83 : SUCCESS in 31m 13s\n- check-swift-devstack-vm-functional http://logs.openstack.org/08/50708/5/check/check-swift-devstack-vm-functional/6685792 : SUCCESS in 30m 56s\n","accounts_in_message":[],"_revision_number":5},{"id":"70bc8bee3060d08b09c8da51971a4188d30d0d02","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2013-10-10 17:11:39.000000000","message":"Patch Set 5: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":5},{"id":"85023e2856683ff40793f7dad1c2e0e870883d5f","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-10-11 11:16:45.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n- Fedora 19 mongoDB https://smokestack.openstack.org/?go\u003d/jobs/143698 : SUCCESS \n- Centos 6.4 MySQL https://smokestack.openstack.org/?go\u003d/jobs/143949 : SUCCESS \n","accounts_in_message":[],"_revision_number":5},{"id":"6c97c27486ef3f47c46cd8862ea9ebfb07746d47","author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"date":"2013-10-11 12:08:57.000000000","message":"Patch Set 5: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":5},{"id":"6056c1c82b7f104b6a6d7443dd032a4f5122d5b8","author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"date":"2013-10-11 13:42:13.000000000","message":"Patch Set 5: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":5},{"id":"241829733af65cd0ebee674c5e369f7a5d8e2883","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-11 13:42:14.000000000","message":"Patch Set 5: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":5},{"id":"d939758f67abc22bf8df9d2be2b25de2d14dd3d7","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-11 20:24:09.000000000","message":"Patch Set 5: Verified\n\nBuild succeeded.\n\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/50708/5/gate/gate-ceilometer-docs/9da0f33/doc/build/html/ : SUCCESS in 2m 24s\n- gate-ceilometer-pep8 http://logs.openstack.org/08/50708/5/gate/gate-ceilometer-pep8/02ec5bb : SUCCESS in 1m 37s\n- gate-ceilometer-python26 http://logs.openstack.org/08/50708/5/gate/gate-ceilometer-python26/ed76d21 : SUCCESS in 9m 45s\n- gate-ceilometer-python27 http://logs.openstack.org/08/50708/5/gate/gate-ceilometer-python27/233b5e9 : SUCCESS in 4m 04s\n- gate-tempest-devstack-vm-full http://logs.openstack.org/08/50708/5/gate/gate-tempest-devstack-vm-full/3cd1eb3 : SUCCESS in 38m 12s\n- gate-tempest-devstack-vm-postgres-full http://logs.openstack.org/08/50708/5/gate/gate-tempest-devstack-vm-postgres-full/9e6d922 : SUCCESS in 37m 46s\n- gate-tempest-devstack-vm-neutron http://logs.openstack.org/08/50708/5/gate/gate-tempest-devstack-vm-neutron/aa84bcc : SUCCESS in 26m 41s\n- gate-tempest-devstack-vm-large-ops http://logs.openstack.org/08/50708/5/gate/gate-tempest-devstack-vm-large-ops/88f5f49 : SUCCESS in 21m 22s\n- gate-swift-devstack-vm-functional http://logs.openstack.org/08/50708/5/gate/gate-swift-devstack-vm-functional/b5bd224 : SUCCESS in 21m 38s\n","accounts_in_message":[],"_revision_number":5},{"id":"07c0cc8889a68019d30283b0747b32a04d78f50b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-10-11 20:24:09.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":5}],"current_revision_number":5,"current_revision":"7ee6f6d29451be4f2c9d5146e4cfbc147f33ee04","revisions":{"6e85566498fcaac2df3f74440af5f01cccb0340c":{"kind":"REWORK","_number":1,"created":"2013-10-09 18:36:59.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/08/50708/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/50708/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/1"}}},"commit":{"parents":[{"commit":"5a657dd9477bdf43a075cdaccb29c6c9d8329bac","subject":"Apply six for metaclass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/5a657dd9477bdf43a075cdaccb29c6c9d8329bac"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:34:00.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:31:46.000000000","tz":60},"subject":"Avoid leaking admin-ness into threshold-oriented alarms","message":"Avoid leaking admin-ness into threshold-oriented alarms\n\nFixes bug 1237567\n\nPreviously when an admin created a threshold-oriented alarm on behalf of\nan non-admin user, this had the effect of leaking visibility onto statistics\nfor resources that would not normally be visible to the non-admin user.\n\nNow we ensure an additional implicit threshold rule query constraint is added\non the project of the non-admin user who will ultimately own the alarm.\n\nChange-Id: I1adae8c899112e7c3eb4e94f3f68262c84a98574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/6e85566498fcaac2df3f74440af5f01cccb0340c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/6e85566498fcaac2df3f74440af5f01cccb0340c"}]},"branch":"refs/heads/master"},"57aeed4a638cc79a9e3c97284f42253475b07f0c":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-10-09 19:28:24.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/08/50708/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/50708/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/2"}}},"commit":{"parents":[{"commit":"5a657dd9477bdf43a075cdaccb29c6c9d8329bac","subject":"Apply six for metaclass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/5a657dd9477bdf43a075cdaccb29c6c9d8329bac"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:34:00.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 19:17:11.000000000","tz":60},"subject":"Avoid leaking admin-ness into threshold-oriented alarms","message":"Avoid leaking admin-ness into threshold-oriented alarms\n\nFixes bug 1237567\n\nPreviously when an admin created a threshold-oriented alarm on\nbehalf of an non-admin identity, this had the effect of leaking\nvisibility onto statistics for resources that would not normally\nbe visible to the non-admin tenant.\n\nNow we ensure that an additional implicit threshold rule query\nconstraint is added on the project ID of the non-admin indentity\nthat will ultimately own the alarm.\n\nThis is acheived by splitting the query validation from the\nconstruction of the kwargs from the query. The addition of the\nimplicit query constraint to the threshold rule can then be\ndelayed to a later point in the dispatch path where the full\ncontext of the alarm is known (so that we can check for the case\nwhere the alarm is created by an admin on behalf of another tenant).\n\nChange-Id: I1adae8c899112e7c3eb4e94f3f68262c84a98574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/57aeed4a638cc79a9e3c97284f42253475b07f0c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/57aeed4a638cc79a9e3c97284f42253475b07f0c"}]},"branch":"refs/heads/master"},"5fb6858e34689171c6f34f9fc2e1175b36b4b8b2":{"kind":"REWORK","_number":3,"created":"2013-10-10 14:59:43.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/08/50708/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/50708/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/3"}}},"commit":{"parents":[{"commit":"5a657dd9477bdf43a075cdaccb29c6c9d8329bac","subject":"Apply six for metaclass","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/5a657dd9477bdf43a075cdaccb29c6c9d8329bac"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:34:00.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-10 14:53:43.000000000","tz":60},"subject":"Avoid leaking admin-ness into threshold-oriented alarms","message":"Avoid leaking admin-ness into threshold-oriented alarms\n\nFixes bug 1237567\n\nPreviously when an admin created a threshold-oriented alarm on\nbehalf of an non-admin identity, this had the effect of leaking\nvisibility onto statistics for resources that would not normally\nbe visible to the non-admin tenant.\n\nNow we ensure that an additional implicit threshold rule query\nconstraint is added on the project ID of the non-admin indentity\nthat will ultimately own the alarm.\n\nThis is acheived by splitting the query validation from the\nconstruction of the kwargs from the query. The addition of the\nimplicit query constraint to the threshold rule can then be\ndelayed to a later point in the dispatch path where the full\ncontext of the alarm is known (so that we can check for the case\nwhere the alarm is created by an admin on behalf of another tenant).\n\nChange-Id: I1adae8c899112e7c3eb4e94f3f68262c84a98574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/5fb6858e34689171c6f34f9fc2e1175b36b4b8b2"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/5fb6858e34689171c6f34f9fc2e1175b36b4b8b2"}]},"branch":"refs/heads/master"},"0419ae078f90f17e3440d1221e7222579881f880":{"kind":"REWORK","_number":4,"created":"2013-10-10 15:17:08.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/08/50708/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/50708/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/4"}}},"commit":{"parents":[{"commit":"c024dcf8c1ca416b705fead7ceba036dccad2167","subject":"Merge \"Change resource.resource_metadata to text type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/c024dcf8c1ca416b705fead7ceba036dccad2167"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:34:00.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-10 15:11:23.000000000","tz":60},"subject":"Avoid leaking admin-ness into threshold-oriented alarms","message":"Avoid leaking admin-ness into threshold-oriented alarms\n\nFixes bug 1237567\n\nPreviously when an admin created a threshold-oriented alarm on\nbehalf of an non-admin identity, this had the effect of leaking\nvisibility onto statistics for resources that would not normally\nbe visible to the non-admin tenant.\n\nNow we ensure that an additional implicit threshold rule query\nconstraint is added on the project ID of the non-admin indentity\nthat will ultimately own the alarm.\n\nThis is acheived by splitting the query validation from the\nconstruction of the kwargs from the query. The addition of the\nimplicit query constraint to the threshold rule can then be\ndelayed to a later point in the dispatch path where the full\ncontext of the alarm is known (so that we can check for the case\nwhere the alarm is created by an admin on behalf of another tenant).\n\nChange-Id: I1adae8c899112e7c3eb4e94f3f68262c84a98574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0419ae078f90f17e3440d1221e7222579881f880"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/0419ae078f90f17e3440d1221e7222579881f880"}]},"branch":"refs/heads/master"},"7ee6f6d29451be4f2c9d5146e4cfbc147f33ee04":{"kind":"REWORK","_number":5,"created":"2013-10-10 15:33:57.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/08/50708/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/50708/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/50708/5"}}},"commit":{"parents":[{"commit":"c024dcf8c1ca416b705fead7ceba036dccad2167","subject":"Merge \"Change resource.resource_metadata to text type\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/c024dcf8c1ca416b705fead7ceba036dccad2167"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-09 18:34:00.000000000","tz":60},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-10-10 15:28:54.000000000","tz":60},"subject":"Avoid leaking admin-ness into threshold-oriented alarms","message":"Avoid leaking admin-ness into threshold-oriented alarms\n\nFixes bug 1237567\n\nPreviously when an admin created a threshold-oriented alarm on\nbehalf of an non-admin identity, this had the effect of leaking\nvisibility onto statistics for resources that would not normally\nbe visible to the non-admin tenant.\n\nNow we ensure that an additional implicit threshold rule query\nconstraint is added on the project ID of the non-admin indentity\nthat will ultimately own the alarm.\n\nThis is acheived by splitting the query validation from the\nconstruction of the kwargs from the query. The addition of the\nimplicit query constraint to the threshold rule can then be\ndelayed to a later point in the dispatch path where the full\ncontext of the alarm is known (so that we can check for the case\nwhere the alarm is created by an admin on behalf of another tenant).\n\nChange-Id: I1adae8c899112e7c3eb4e94f3f68262c84a98574\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/7ee6f6d29451be4f2c9d5146e4cfbc147f33ee04"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/7ee6f6d29451be4f2c9d5146e4cfbc147f33ee04"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}