)]}'
{"ceilometer/publisher/messaging.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"209f269b1d79c6cffac838f43d96ce8353679b67","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        with self.queue_lock:"},{"line_number":137,"context_line":"            self.local_queue \u003d (queue + self.local_queue)"},{"line_number":138,"context_line":"            if self.policy \u003d\u003d \u0027queue\u0027:"},{"line_number":139,"context_line":"                self._check_queue_length()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _check_queue_length(self):"},{"line_number":142,"context_line":"        queue_length \u003d len(self.local_queue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_0916c2f2","line":139,"updated":"2017-10-05 16:07:50.000000000","message":"this function should probably not exist and the code be moved here, so it\u0027s clear why you really need the lock","commit_id":"62008e0bf1bbc1ab480888ca4aee1ff6ce2c606c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"0deef142271bdc8056ea66ce01524f46c60ca35e","unresolved":false,"context_lines":[{"line_number":136,"context_line":"        with self.queue_lock:"},{"line_number":137,"context_line":"            self.local_queue \u003d (queue + self.local_queue)"},{"line_number":138,"context_line":"            if self.policy \u003d\u003d \u0027queue\u0027:"},{"line_number":139,"context_line":"                self._check_queue_length()"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"    def _check_queue_length(self):"},{"line_number":142,"context_line":"        queue_length \u003d len(self.local_queue)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_e9bb66e2","line":139,"in_reply_to":"7f515b1d_0916c2f2","updated":"2017-10-05 16:08:22.000000000","message":"Forget that comment.","commit_id":"62008e0bf1bbc1ab480888ca4aee1ff6ce2c606c"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"209f269b1d79c6cffac838f43d96ce8353679b67","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        topic \u003d self.conf.publisher_notifier.event_topic"},{"line_number":183,"context_line":"        with self.queue_lock:"},{"line_number":184,"context_line":"            self.local_queue.append((topic, ev_list))"},{"line_number":185,"context_line":"        self.flush()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_4ed040f8","line":184,"updated":"2017-10-05 16:07:50.000000000","message":"append is atomic so you don\u0027t need the lock here","commit_id":"62008e0bf1bbc1ab480888ca4aee1ff6ce2c606c"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"9802a9e9fa3b10cdfa9e5fa4c975ad916ce20f6d","unresolved":false,"context_lines":[{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        topic \u003d self.conf.publisher_notifier.event_topic"},{"line_number":183,"context_line":"        with self.queue_lock:"},{"line_number":184,"context_line":"            self.local_queue.append((topic, ev_list))"},{"line_number":185,"context_line":"        self.flush()"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"    @abc.abstractmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f515b1d_ba86ce64","line":184,"in_reply_to":"7f515b1d_4ed040f8","updated":"2017-10-05 17:27:59.000000000","message":"Well, it\u0027s more already locked by GIL.","commit_id":"62008e0bf1bbc1ab480888ca4aee1ff6ce2c606c"}]}