)]}'
{"ceilometer/publisher/warp10.py":[{"author":{"_account_id":10311,"name":"Joseph Davis","email":"joseph.davis@suse.com","username":"joadavis"},"change_message_id":"21b915bfe65c2c954875d3963b940a92ca82a978","unresolved":false,"context_lines":[{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Warp10Publisher(gnocchi.GnocchiPublisher):"},{"line_number":41,"context_line":"    \"\"\"Ceilometer publisher for pushing metrics into Warp10 backend.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, conf, parsed_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_b4738c15","line":40,"updated":"2017-12-04 16:26:05.000000000","message":"I\u0027m not sure you want to inherit from GnocchiPublisher here.  Seems like there should be a base class you can work from, as you aren\u0027t using gnocchi at all with your Warp10.","commit_id":"4a291915758ed3fa71facfc907175adf542e348f"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"aed57d27913d84e54ad7e4587d355dfe7671c3b0","unresolved":false,"context_lines":[{"line_number":37,"context_line":"]"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"class Warp10Publisher(gnocchi.GnocchiPublisher):"},{"line_number":41,"context_line":"    \"\"\"Ceilometer publisher for pushing metrics into Warp10 backend.\"\"\""},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"    def __init__(self, conf, parsed_url):"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_5ee78841","line":40,"in_reply_to":"df87a7cf_b4738c15","updated":"2017-12-06 09:21:37.000000000","message":"Yeap, true. Warp10Publisher should be independent.","commit_id":"4a291915758ed3fa71facfc907175adf542e348f"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"aed57d27913d84e54ad7e4587d355dfe7671c3b0","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        except ValueError:"},{"line_number":65,"context_line":"            pass"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _send_resource_to_gnocchi(self, resource_infos,"},{"line_number":68,"context_line":"                                  measures, resource_ids):"},{"line_number":69,"context_line":"        # NOTE(danpawlik) Taken from Gnocchi publisher with small change."},{"line_number":70,"context_line":"        # Gnocchi publisher each time tries to update resource in Gnocchi,"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_bef494d0","line":67,"range":{"start_line":67,"start_character":8,"end_line":67,"end_character":33},"updated":"2017-12-06 09:21:37.000000000","message":"I would have it as traits added when it is needed.","commit_id":"4a291915758ed3fa71facfc907175adf542e348f"},{"author":{"_account_id":25618,"name":"Paweł Suder","email":"pawel@suder.info","username":"SuderPawel"},"change_message_id":"aed57d27913d84e54ad7e4587d355dfe7671c3b0","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                resource_ids.append(self._prepare_metric_and_send("},{"line_number":166,"context_line":"                    resource_id, resource_infos, measures))"},{"line_number":167,"context_line":""},{"line_number":168,"context_line":"            # NOTE(danpawlik) Send data to Warp10 then to Gnocchi."},{"line_number":169,"context_line":"            self._send_resource_to_gnocchi(resource_infos,"},{"line_number":170,"context_line":"                                           measures,"},{"line_number":171,"context_line":"                                           resource_ids)"},{"line_number":172,"context_line":"        except Exception as e:"},{"line_number":173,"context_line":"            LOG.error(\"There is a problem on sending metrics to \""},{"line_number":174,"context_line":"                      \"warp10: %s\" % e)"}],"source_content_type":"text/x-python","patch_set":3,"id":"df87a7cf_3ed72426","line":171,"range":{"start_line":168,"start_character":12,"end_line":171,"end_character":56},"updated":"2017-12-06 09:21:37.000000000","message":"As traits should be this if Warp10 publisher will extend base publisher.","commit_id":"4a291915758ed3fa71facfc907175adf542e348f"}]}
