)]}'
{"ceilometer/publisher/gnocchi.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d4d4a150f409ace1f54066b04514a2373d3dc252","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def metric_match(self, metric_name):"},{"line_number":108,"context_line":"        for t in self.cfg[\u0027metrics\u0027]:"},{"line_number":109,"context_line":"            if fnmatch.fnmatch(metric_name, t):"},{"line_number":110,"context_line":"                return True"},{"line_number":111,"context_line":"        return False"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_a8543454","side":"PARENT","line":109,"updated":"2017-11-24 16:24:13.000000000","message":"hum is this a regression since now it\u0027s not using fnmatch anymore?","commit_id":"8e3ba4d7094c5e06e49a74ed6a4aa776978fc613"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5268173a253fc29e9aee3381c410e80acba42127","unresolved":false,"context_lines":[{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    def metric_match(self, metric_name):"},{"line_number":108,"context_line":"        for t in self.cfg[\u0027metrics\u0027]:"},{"line_number":109,"context_line":"            if fnmatch.fnmatch(metric_name, t):"},{"line_number":110,"context_line":"                return True"},{"line_number":111,"context_line":"        return False"},{"line_number":112,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_e311fd05","side":"PARENT","line":109,"in_reply_to":"ff82abbf_a8543454","updated":"2017-11-24 17:10:03.000000000","message":"see commit message :) this is always a non-wildcard string.\n\nit also doesn\u0027t work if you change gnocchi_resources.yaml to use wildcard as we use gnocchi_resources.yaml to create resources (and it\u0027s metrics) so it must be non-wildcard or it will create a metric with wildcard name gnocchi for no reason.\n\nwe can modify code more to support this but i don\u0027t see value in supporting something that decreases performance just to simplify static gnocchi_resources.yaml file","commit_id":"8e3ba4d7094c5e06e49a74ed6a4aa776978fc613"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d4d4a150f409ace1f54066b04514a2373d3dc252","unresolved":false,"context_lines":[{"line_number":282,"context_line":"             self._is_swift_account_sample(sample))"},{"line_number":283,"context_line":"        ))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _get_resource_definition_from_metric(self, metric_name):"},{"line_number":286,"context_line":"        return self.metric_map.get(metric_name)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def _get_resource_definition_from_event(self, event_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_28690420","line":285,"updated":"2017-11-24 16:24:13.000000000","message":"simplify and remove?","commit_id":"87d986d5c9ee9c3b0f2d71d899ed79786b7ef01c"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"5268173a253fc29e9aee3381c410e80acba42127","unresolved":false,"context_lines":[{"line_number":282,"context_line":"             self._is_swift_account_sample(sample))"},{"line_number":283,"context_line":"        ))"},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"    def _get_resource_definition_from_metric(self, metric_name):"},{"line_number":286,"context_line":"        return self.metric_map.get(metric_name)"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"    def _get_resource_definition_from_event(self, event_type):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_43c30939","line":285,"in_reply_to":"ff82abbf_28690420","updated":"2017-11-24 17:10:03.000000000","message":"ok.","commit_id":"87d986d5c9ee9c3b0f2d71d899ed79786b7ef01c"}]}