)]}'
{"ceilometer/publisher/rpc.py":[{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"4cd2b9f1524454498d9509a6e5a5885e7a37de12","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.CONF.import_opt(\u0027rpc_backend\u0027,"},{"line_number":66,"context_line":"                        \u0027ceilometer.openstack.common.rpc\u0027)"},{"line_number":67,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":68,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cfg.CONF.import_opt(\u0027rabbit_max_retries\u0027, kombu)"},{"line_number":71,"context_line":"        except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F5GA%3D","line":68,"updated":"2013-10-25 15:59:48.000000000","message":"Might you reduce the coupling with:\n\n  if \u0027kombu\u0027 in cfg.CONF.rpc_backend","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"382b1bed426d67b1eb7f4aef5a3f8fad77a00586","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.CONF.import_opt(\u0027rpc_backend\u0027,"},{"line_number":66,"context_line":"                        \u0027ceilometer.openstack.common.rpc\u0027)"},{"line_number":67,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":68,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cfg.CONF.import_opt(\u0027rabbit_max_retries\u0027, kombu)"},{"line_number":71,"context_line":"        except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F4k0%3D","line":68,"in_reply_to":"AAAATn%2F%2F4xw%3D","updated":"2013-10-25 17:55:55.000000000","message":"kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027\n\nOught to be a constant here, though, right?","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"3027d96f12b953b6a32baa299c521b86d187f21b","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.CONF.import_opt(\u0027rpc_backend\u0027,"},{"line_number":66,"context_line":"                        \u0027ceilometer.openstack.common.rpc\u0027)"},{"line_number":67,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":68,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cfg.CONF.import_opt(\u0027rabbit_max_retries\u0027, kombu)"},{"line_number":71,"context_line":"        except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F4xw%3D","line":68,"in_reply_to":"AAAATn%2F%2F5BM%3D","updated":"2013-10-25 17:16:06.000000000","message":"Oops, right Eoghan, if you need full reference,\nyou might as well be exact with the check.","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":7368,"name":"Thomas Maddox","email":"me@thomasem.net","username":"thomasm"},"change_message_id":"48971a72f98b6d3f771dc6981bcfc6e6b57eb635","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.CONF.import_opt(\u0027rpc_backend\u0027,"},{"line_number":66,"context_line":"                        \u0027ceilometer.openstack.common.rpc\u0027)"},{"line_number":67,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":68,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cfg.CONF.import_opt(\u0027rabbit_max_retries\u0027, kombu)"},{"line_number":71,"context_line":"        except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F5BM%3D","line":68,"in_reply_to":"AAAATn%2F%2F5Es%3D","updated":"2013-10-25 16:17:44.000000000","message":"I think this supports the spirit of the initial comment: cfg.CONF.rpc_backend.endswith(\u0027kombu\u0027)?","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"359217955110f619610406d3e2030acf5cc0bd76","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    cfg.CONF.import_opt(\u0027rpc_backend\u0027,"},{"line_number":66,"context_line":"                        \u0027ceilometer.openstack.common.rpc\u0027)"},{"line_number":67,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":68,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":69,"context_line":"        try:"},{"line_number":70,"context_line":"            cfg.CONF.import_opt(\u0027rabbit_max_retries\u0027, kombu)"},{"line_number":71,"context_line":"        except ImportError:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F5Es%3D","line":68,"in_reply_to":"AAAATn%2F%2F5GA%3D","updated":"2013-10-25 16:06:49.000000000","message":"Well, I\u0027m not sure the proposed change would achieve that much, as I\u0027d need the fully-qualified reference to \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027 for the import_opt regardless.","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"change_message_id":"4cd2b9f1524454498d9509a6e5a5885e7a37de12","unresolved":false,"context_lines":[{"line_number":82,"context_line":"       :param value: the value to override"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":85,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":86,"context_line":"        if \u0027rabbit_max_retries\u0027 in cfg.CONF:"},{"line_number":87,"context_line":"            cfg.CONF.set_override(\u0027rabbit_max_retries\u0027, value)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F5GM%3D","line":85,"updated":"2013-10-25 15:59:48.000000000","message":"Is the above check redundant here?","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"359217955110f619610406d3e2030acf5cc0bd76","unresolved":false,"context_lines":[{"line_number":82,"context_line":"       :param value: the value to override"},{"line_number":83,"context_line":"    \"\"\""},{"line_number":84,"context_line":"    kombu \u003d \u0027ceilometer.openstack.common.rpc.impl_kombu\u0027"},{"line_number":85,"context_line":"    if cfg.CONF.rpc_backend \u003d\u003d kombu:"},{"line_number":86,"context_line":"        if \u0027rabbit_max_retries\u0027 in cfg.CONF:"},{"line_number":87,"context_line":"            cfg.CONF.set_override(\u0027rabbit_max_retries\u0027, value)"},{"line_number":88,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2F5EQ%3D","line":85,"in_reply_to":"AAAATn%2F%2F5GM%3D","updated":"2013-10-25 16:06:49.000000000","message":"Yes, it is a little belt\u0027n\u0027braces-y.\n\nThe intent was for the first condition to ensure we only consider rabbit config if the kombu backend is configured, while the second condition protects this code from NoSuchOptError if the kombu backend config options ever changed out from under us (v. unlikely I know, call me paranoid ...)","commit_id":"ff2a17fefe0599b7a1120d5cce329a721fa81b69"}]}