)]}'
{"ceilometer/alarm/notifier/log.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"ae8d4be6591f55d84d955c35871d5da676bd179e","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"},{"line_number":31,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":32,"context_line":"        LOG.info(_("},{"line_number":33,"context_line":"            \"Notifying alarm %(id)s \""},{"line_number":34,"context_line":"            \"from %(pre)s to %(cur)s \""},{"line_number":35,"context_line":"            \"with action %(act)s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FQ2M%3D","line":32,"updated":"2013-11-12 03:14:50.000000000","message":"do we really need to split one line to four lines? It increase code lines a lot.","commit_id":"00c60096e165aa9602104abf45aac7d1eaa3ab6d"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"d8701a8d231c12304ccc9797c5f9c242ebe95208","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"    @staticmethod"},{"line_number":31,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":32,"context_line":"        LOG.info(_("},{"line_number":33,"context_line":"            \"Notifying alarm %(id)s \""},{"line_number":34,"context_line":"            \"from %(pre)s to %(cur)s \""},{"line_number":35,"context_line":"            \"with action %(act)s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FMtQ%3D","line":32,"in_reply_to":"AAAATn%2F%2FQ2M%3D","updated":"2013-11-13 02:38:10.000000000","message":"Done","commit_id":"00c60096e165aa9602104abf45aac7d1eaa3ab6d"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":32,"context_line":"        LOG.info(_("},{"line_number":33,"context_line":"            \"Notifying alarm %(alarm_id)s from %(previous)s to %(current)s \""},{"line_number":34,"context_line":"            \"with action %(action)s because %(reason)s\") % locals())"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2By0g%3D","line":34,"updated":"2013-11-20 04:51:44.000000000","message":"are we allowing for locals() on ceilometer I have seen other projects using the dictionary with key and vals to replace strings","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/alarm/notifier/rest.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"ae8d4be6591f55d84d955c35871d5da676bd179e","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @staticmethod"},{"line_number":57,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":58,"context_line":"        LOG.info(_("},{"line_number":59,"context_line":"            \"Notifying alarm %(id)s \""},{"line_number":60,"context_line":"            \"from %(pre)s to %(cur)s \""},{"line_number":61,"context_line":"            \"with action %(act)s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FQ18%3D","line":58,"updated":"2013-11-12 03:14:50.000000000","message":"ditto","commit_id":"00c60096e165aa9602104abf45aac7d1eaa3ab6d"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"d8701a8d231c12304ccc9797c5f9c242ebe95208","unresolved":false,"context_lines":[{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    @staticmethod"},{"line_number":57,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":58,"context_line":"        LOG.info(_("},{"line_number":59,"context_line":"            \"Notifying alarm %(id)s \""},{"line_number":60,"context_line":"            \"from %(pre)s to %(cur)s \""},{"line_number":61,"context_line":"            \"with action %(act)s \""}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAATn%2F%2FMtM%3D","line":58,"in_reply_to":"AAAATn%2F%2FQ18%3D","updated":"2013-11-13 02:38:10.000000000","message":"Done","commit_id":"00c60096e165aa9602104abf45aac7d1eaa3ab6d"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    def notify(action, alarm_id, previous, current, reason):"},{"line_number":58,"context_line":"        LOG.info(_("},{"line_number":59,"context_line":"            \"Notifying alarm %(alarm_id)s from %(previous)s to %(current)s \""},{"line_number":60,"context_line":"            \"with action %(action)s because %(reason)s\") % locals())"},{"line_number":61,"context_line":"        body \u003d {\u0027alarm_id\u0027: alarm_id, \u0027previous\u0027: previous,"},{"line_number":62,"context_line":"                \u0027current\u0027: current, \u0027reason\u0027: reason}"},{"line_number":63,"context_line":"        kwargs \u003d {\u0027data\u0027: jsonutils.dumps(body)}"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2By0c%3D","line":60,"updated":"2013-11-20 04:51:44.000000000","message":"locals()?","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/alarm/partition/coordination.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":241,"context_line":"            still_ahead \u003d self.this \u003c self.oldest"},{"line_number":242,"context_line":"        self.last_alarms \u003d set(alarms)"},{"line_number":243,"context_line":"        LOG.info(_(\u0027%(this)s not overtaken as master? %(still_ahead)s\u0027) %"},{"line_number":244,"context_line":"                 dict(this\u003dself.this, still_ahead\u003dstill_ahead))"},{"line_number":245,"context_line":"        return still_ahead"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def check_mastership(self, eval_interval, api_client):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2By0U%3D","line":244,"updated":"2013-11-20 04:51:44.000000000","message":"This is an example where locals() are not used","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/alarm/service.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":246,"context_line":""},{"line_number":247,"context_line":"        try:"},{"line_number":248,"context_line":"            LOG.debug(_(\"Notifying alarm %(id)s with action %(act)s\") % ("},{"line_number":249,"context_line":"                      {\u0027id\u0027: alarm_id, \u0027act\u0027: action}))"},{"line_number":250,"context_line":"            notifier.notify(action, alarm_id, previous, current, reason)"},{"line_number":251,"context_line":"        except Exception:"},{"line_number":252,"context_line":"            LOG.exception(_(\"Unable to notify alarm %s\"), alarm_id)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2By0M%3D","line":249,"updated":"2013-11-20 04:51:44.000000000","message":"I prefer this way instead of using dict","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/api/app.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":124,"context_line":"        LOG.info(_("},{"line_number":125,"context_line":"            \u0027serving on 0.0.0.0:%(sport)s, \u0027"},{"line_number":126,"context_line":"            \u0027view at http://127.0.0.1:%(vport)s\u0027) %"},{"line_number":127,"context_line":"            ({\u0027sport\u0027: port, \u0027vport\u0027: port}))"},{"line_number":128,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMUs%3D","line":125,"updated":"2013-11-13 05:40:03.000000000","message":"Hi,\n\nAs I commented in patch 12, there are still some code lines should be re-org to keep codes in clean style.","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    if host \u003d\u003d \u00270.0.0.0\u0027:"},{"line_number":124,"context_line":"        LOG.info(_("},{"line_number":125,"context_line":"            \u0027serving on 0.0.0.0:%(sport)s, \u0027"},{"line_number":126,"context_line":"            \u0027view at http://127.0.0.1:%(vport)s\u0027) %"},{"line_number":127,"context_line":"            ({\u0027sport\u0027: port, \u0027vport\u0027: port}))"},{"line_number":128,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMFI%3D","line":125,"in_reply_to":"AAAATn%2F%2FMUs%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":125,"context_line":"            \u0027serving on 0.0.0.0:%(sport)s, view at http://127.0.0.1:%(vport)s\u0027)"},{"line_number":126,"context_line":"            % ({\u0027sport\u0027: port, \u0027vport\u0027: port}))"},{"line_number":127,"context_line":"    else:"},{"line_number":128,"context_line":"        LOG.info(_(\"serving on http://%(h)s:%(p)s\") % ("},{"line_number":129,"context_line":"                 {\u0027h\u0027: host, \u0027p\u0027: port}))"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    srv.serve_forever()"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byz8%3D","line":128,"updated":"2013-11-20 04:51:44.000000000","message":"be consistent, use full names for keys","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":799,"context_line":"        computed \u003d pecan.request.storage_conn.get_meter_statistics(f,"},{"line_number":800,"context_line":"                                                                   period,"},{"line_number":801,"context_line":"                                                                   g)"},{"line_number":802,"context_line":"        LOG.debug(_(\u0027computed value coming from %r\u0027) %"},{"line_number":803,"context_line":"                  pecan.request.storage_conn)"},{"line_number":804,"context_line":"        # Find the original timestamp in the query to use for clamping"},{"line_number":805,"context_line":"        # the duration returned in the statistics."}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byz0%3D","line":802,"updated":"2013-11-20 04:51:44.000000000","message":"why % instead of leaving ,","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/api/v1/blueprint.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":570,"context_line":"                \u0027end_timestamp %(et)s, \u0027"},{"line_number":571,"context_line":"                \u0027min_ts %(mnt)s, \u0027"},{"line_number":572,"context_line":"                \u0027max_ts %(mxt)s\u0027) % ("},{"line_number":573,"context_line":"              {\u0027st\u0027: start_timestamp,"},{"line_number":574,"context_line":"               \u0027et\u0027: end_timestamp,"},{"line_number":575,"context_line":"               \u0027mnt\u0027: min_ts,"},{"line_number":576,"context_line":"               \u0027mxt\u0027: max_ts}))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byzo%3D","line":573,"updated":"2013-11-20 04:51:44.000000000","message":"use full names","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/central/manager.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    ))"},{"line_number":49,"context_line":"                    publisher(samples)"},{"line_number":50,"context_line":"                except Exception as err:"},{"line_number":51,"context_line":"                    LOG.warning(_("},{"line_number":52,"context_line":"                        \u0027Continue after error \u0027"},{"line_number":53,"context_line":"                        \u0027from %(name)s: %(e)s\u0027) % ({\u0027name\u0027: pollster.name,"},{"line_number":54,"context_line":"                                                    \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMUk%3D","line":51,"updated":"2013-11-13 05:40:03.000000000","message":"ditto","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    ))"},{"line_number":49,"context_line":"                    publisher(samples)"},{"line_number":50,"context_line":"                except Exception as err:"},{"line_number":51,"context_line":"                    LOG.warning(_("},{"line_number":52,"context_line":"                        \u0027Continue after error \u0027"},{"line_number":53,"context_line":"                        \u0027from %(name)s: %(e)s\u0027) % ({\u0027name\u0027: pollster.name,"},{"line_number":54,"context_line":"                                                    \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FME0%3D","line":51,"in_reply_to":"AAAATn%2F%2FMUk%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                    ))"},{"line_number":49,"context_line":"                    publisher(samples)"},{"line_number":50,"context_line":"                except Exception as err:"},{"line_number":51,"context_line":"                    LOG.warning(_(\u0027Continue after error from %(name)s: %(e)s\u0027)"},{"line_number":52,"context_line":"                                % ({\u0027name\u0027: pollster.name, \u0027e\u0027: err}))"},{"line_number":53,"context_line":"                    LOG.exception(err)"},{"line_number":54,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byzk%3D","line":51,"updated":"2013-11-20 04:51:44.000000000","message":"change e to error","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/collector/dispatcher/database.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        for meter in data:"},{"line_number":51,"context_line":"            LOG.debug(_("},{"line_number":52,"context_line":"                \u0027metering data %(name)s \u0027"},{"line_number":53,"context_line":"                \u0027for %(id)s \u0027"},{"line_number":54,"context_line":"                \u0027@ %(t)s: \u0027"},{"line_number":55,"context_line":"                \u0027%(v)s\u0027) % ({\u0027name\u0027: meter[\u0027counter_name\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMUc%3D","line":52,"updated":"2013-11-13 05:40:03.000000000","message":"ditto","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"        for meter in data:"},{"line_number":51,"context_line":"            LOG.debug(_("},{"line_number":52,"context_line":"                \u0027metering data %(name)s \u0027"},{"line_number":53,"context_line":"                \u0027for %(id)s \u0027"},{"line_number":54,"context_line":"                \u0027@ %(t)s: \u0027"},{"line_number":55,"context_line":"                \u0027%(v)s\u0027) % ({\u0027name\u0027: meter[\u0027counter_name\u0027],"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMEw%3D","line":52,"in_reply_to":"AAAATn%2F%2FMUc%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":51,"context_line":"            LOG.debug(_(\u0027metering data %(name)s for %(id)s @ %(t)s: %(v)s\u0027)"},{"line_number":52,"context_line":"                      % ({\u0027name\u0027: meter[\u0027counter_name\u0027],"},{"line_number":53,"context_line":"                          \u0027id\u0027: meter[\u0027resource_id\u0027],"},{"line_number":54,"context_line":"                          \u0027t\u0027: meter.get(\u0027timestamp\u0027, \u0027NO TIMESTAMP\u0027),"},{"line_number":55,"context_line":"                          \u0027v\u0027: meter[\u0027counter_volume\u0027]}))"},{"line_number":56,"context_line":"            if publisher_rpc.verify_signature("},{"line_number":57,"context_line":"                    meter,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byzc%3D","line":54,"updated":"2013-11-20 04:51:44.000000000","message":"full name for t and v","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/collector/service.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        handler \u003d ext.obj"},{"line_number":184,"context_line":"        ack_on_error \u003d cfg.CONF.collector.ack_on_event_error"},{"line_number":185,"context_line":"        LOG.debug(_("},{"line_number":186,"context_line":"            \u0027Event types from %(n)s: \u0027"},{"line_number":187,"context_line":"            \u0027%(type)s \u0027"},{"line_number":188,"context_line":"            \u0027(ack_on_error\u003d%(e)s)\u0027) % ({\u0027n\u0027: ext.name,"},{"line_number":189,"context_line":"                                        \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMUU%3D","line":186,"updated":"2013-11-13 05:40:03.000000000","message":"ditto","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":183,"context_line":"        handler \u003d ext.obj"},{"line_number":184,"context_line":"        ack_on_error \u003d cfg.CONF.collector.ack_on_event_error"},{"line_number":185,"context_line":"        LOG.debug(_("},{"line_number":186,"context_line":"            \u0027Event types from %(n)s: \u0027"},{"line_number":187,"context_line":"            \u0027%(type)s \u0027"},{"line_number":188,"context_line":"            \u0027(ack_on_error\u003d%(e)s)\u0027) % ({\u0027n\u0027: ext.name,"},{"line_number":189,"context_line":"                                        \u0027type\u0027: \u0027, \u0027.join(handler.event_types),"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMEI%3D","line":186,"in_reply_to":"AAAATn%2F%2FMUU%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":157,"context_line":"            )"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"        if not list(self.notification_manager):"},{"line_number":160,"context_line":"            LOG.warning(_(\u0027Failed to load any notification handlers for %s\u0027) %"},{"line_number":161,"context_line":"                        self.COLLECTOR_NAMESPACE)"},{"line_number":162,"context_line":"        self.notification_manager.map(self._setup_subscription)"},{"line_number":163,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByzQ%3D","line":160,"updated":"2013-11-20 04:51:44.000000000","message":"I would leave the coma is not exactly the same","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/compute/manager.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        ))"},{"line_number":49,"context_line":"                        publisher(samples)"},{"line_number":50,"context_line":"                    except Exception as err:"},{"line_number":51,"context_line":"                        LOG.warning(_("},{"line_number":52,"context_line":"                            \u0027Continue after error \u0027"},{"line_number":53,"context_line":"                            \u0027from %(name)s: %(e)s\u0027) % ({\u0027name\u0027: pollster.name,"},{"line_number":54,"context_line":"                                                        \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMUQ%3D","line":51,"updated":"2013-11-13 05:40:03.000000000","message":"ditto","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":48,"context_line":"                        ))"},{"line_number":49,"context_line":"                        publisher(samples)"},{"line_number":50,"context_line":"                    except Exception as err:"},{"line_number":51,"context_line":"                        LOG.warning(_("},{"line_number":52,"context_line":"                            \u0027Continue after error \u0027"},{"line_number":53,"context_line":"                            \u0027from %(name)s: %(e)s\u0027) % ({\u0027name\u0027: pollster.name,"},{"line_number":54,"context_line":"                                                        \u0027e\u0027: err}))"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMDk%3D","line":51,"in_reply_to":"AAAATn%2F%2FMUQ%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":49,"context_line":"                        publisher(samples)"},{"line_number":50,"context_line":"                    except Exception as err:"},{"line_number":51,"context_line":"                        LOG.warning(_(\u0027Continue after error from %(n)s: %(e)s\u0027)"},{"line_number":52,"context_line":"                                    % ({\u0027n\u0027: pollster.name, \u0027e\u0027: err}))"},{"line_number":53,"context_line":"                        LOG.exception(err)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"    def poll_and_publish(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByzM%3D","line":52,"updated":"2013-11-20 04:51:44.000000000","message":"full names","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/compute/pollsters/cpu.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":36,"context_line":"        try:"},{"line_number":37,"context_line":"            cpu_info \u003d manager.inspector.inspect_cpus(instance_name)"},{"line_number":38,"context_line":"            LOG.info(_(\"CPUTIME USAGE: %(ints)s %(time)d\") % ("},{"line_number":39,"context_line":"                     {\u0027ints\u0027: instance.__dict__, \u0027time\u0027: cpu_info.time}))"},{"line_number":40,"context_line":"            cpu_num \u003d {\u0027cpu_number\u0027: cpu_info.number}"},{"line_number":41,"context_line":"            yield util.make_sample_from_instance("},{"line_number":42,"context_line":"                instance,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByzI%3D","line":39,"updated":"2013-11-20 04:51:44.000000000","message":"insts \u003e instance","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/compute/pollsters/disk.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":93,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":94,"context_line":"        except Exception as err:"},{"line_number":95,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(e)s\u0027) % ("},{"line_number":96,"context_line":"                        {\u0027name\u0027: instance_name, \u0027e\u0027: err}))"},{"line_number":97,"context_line":"            LOG.exception(err)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byy4%3D","line":96,"updated":"2013-11-20 04:51:44.000000000","message":"e \u003e error","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/compute/pollsters/net.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":90,"context_line":"            LOG.debug(_(\u0027Exception while getting samples %s\u0027), err)"},{"line_number":91,"context_line":"        except Exception as err:"},{"line_number":92,"context_line":"            LOG.warning(_(\u0027Ignoring instance %(name)s: %(e)s\u0027) % ("},{"line_number":93,"context_line":"                        {\u0027name\u0027: instance_name, \u0027e\u0027: err}))"},{"line_number":94,"context_line":"            LOG.exception(err)"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byy0%3D","line":93,"updated":"2013-11-20 04:51:44.000000000","message":"e \u003e error","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/compute/virt/inspector.py":[{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"0fcd651cd88fe08e81949a6f173704b2a65d3c92","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                   cfg.CONF.hypervisor_inspector,"},{"line_number":152,"context_line":"                                   invoke_on_load\u003dTrue)"},{"line_number":153,"context_line":"        return mgr.driver"},{"line_number":154,"context_line":"    except ImportError as e:"},{"line_number":155,"context_line":"        LOG.error(_(\"Unable to load the hypervisor inspector: %s\") % (e))"},{"line_number":156,"context_line":"        return Inspector()"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2Bskg%3D","line":154,"updated":"2013-11-21 13:25:21.000000000","message":"As I understand \u0027e\u0027 will be translated here. Do we really want to translate exception?","commit_id":"74778636f7f20b128fb238029af4376f9786c162"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"62fc172390a6c6785cc4ca61c08505cd67c818fd","unresolved":false,"context_lines":[{"line_number":151,"context_line":"                                   cfg.CONF.hypervisor_inspector,"},{"line_number":152,"context_line":"                                   invoke_on_load\u003dTrue)"},{"line_number":153,"context_line":"        return mgr.driver"},{"line_number":154,"context_line":"    except ImportError as e:"},{"line_number":155,"context_line":"        LOG.error(_(\"Unable to load the hypervisor inspector: %s\") % (e))"},{"line_number":156,"context_line":"        return Inspector()"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2BsD8%3D","line":154,"in_reply_to":"AAAATn%2F%2Bskg%3D","updated":"2013-11-21 14:36:27.000000000","message":"As far as i knew, based on other components, it shall be translated, and not only the exception, but the error sentence.","commit_id":"74778636f7f20b128fb238029af4376f9786c162"}],"ceilometer/network/floatingip.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1daa83edfad1c97420ac8058dddafc5d76d5e40b","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.central import plugin"},{"line_number":23,"context_line":"from ceilometer import nova_client"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ceilometer.openstack.common.gettextutils import _  # noqa"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":"from ceilometer.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2BNao%3D","line":24,"updated":"2013-11-29 05:36:33.000000000","message":"no need to put empty line here.","commit_id":"3de8c3d8e4d6e5f91a795f3449f8dccabba52ae9"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"02f1717d99362d8946fd2e328a5949386d8bb7a8","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.central import plugin"},{"line_number":23,"context_line":"from ceilometer import nova_client"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"from ceilometer.openstack.common.gettextutils import _  # noqa"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":"from ceilometer.openstack.common import timeutils"}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2BMcg%3D","line":24,"in_reply_to":"AAAATn%2F%2BNao%3D","updated":"2013-11-29 11:18:20.000000000","message":"Done","commit_id":"3de8c3d8e4d6e5f91a795f3449f8dccabba52ae9"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1daa83edfad1c97420ac8058dddafc5d76d5e40b","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ceilometer.openstack.common.gettextutils import _  # noqa"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":"from ceilometer.openstack.common import timeutils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ceilometer import sample"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2BNac%3D","line":28,"updated":"2013-11-29 05:36:33.000000000","message":"no need to put empty line here.","commit_id":"3de8c3d8e4d6e5f91a795f3449f8dccabba52ae9"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"02f1717d99362d8946fd2e328a5949386d8bb7a8","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from ceilometer.openstack.common.gettextutils import _  # noqa"},{"line_number":26,"context_line":"from ceilometer.openstack.common import log"},{"line_number":27,"context_line":"from ceilometer.openstack.common import timeutils"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from ceilometer import sample"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"AAAATn%2F%2BMcY%3D","line":28,"in_reply_to":"AAAATn%2F%2BNac%3D","updated":"2013-11-29 11:18:20.000000000","message":"Done","commit_id":"3de8c3d8e4d6e5f91a795f3449f8dccabba52ae9"}],"ceilometer/notifier.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    namespace \u003d \u0027ceilometer.collector\u0027"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"    LOG.debug(_(\u0027loading notification handlers from %s\u0027) % namespace)"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    _notification_manager \u003d extension.ExtensionManager("},{"line_number":42,"context_line":"        namespace\u003dnamespace,"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byyw%3D","line":39,"updated":"2013-11-20 04:51:44.000000000","message":"keep with coma","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":43,"context_line":"        invoke_on_load\u003dTrue)"},{"line_number":44,"context_line":""},{"line_number":45,"context_line":"    if not list(_notification_manager):"},{"line_number":46,"context_line":"        LOG.warning(_(\u0027Failed to load any notification handlers for %s\u0027) %"},{"line_number":47,"context_line":"                    namespace)"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byys%3D","line":46,"updated":"2013-11-20 04:51:44.000000000","message":"keep with coma","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/openstack/common/db/sqlalchemy/session.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":274,"context_line":"               default\u003d\u0027sqlite:///\u0027 +"},{"line_number":275,"context_line":"               os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":276,"context_line":"                               \u0027../\u0027, \u0027$sqlite_db\u0027)),"},{"line_number":277,"context_line":"               help\u003d\u0027The SQLAlchemy connection string used to connect to the \u0027"},{"line_number":278,"context_line":"                    \u0027database\u0027,"},{"line_number":279,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMT4%3D","line":276,"updated":"2013-11-13 05:40:03.000000000","message":"why need this change?","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":273,"context_line":"    cfg.StrOpt(\u0027connection\u0027,"},{"line_number":274,"context_line":"               default\u003d\u0027sqlite:///\u0027 +"},{"line_number":275,"context_line":"               os.path.abspath(os.path.join(os.path.dirname(__file__),"},{"line_number":276,"context_line":"                               \u0027../\u0027, \u0027$sqlite_db\u0027)),"},{"line_number":277,"context_line":"               help\u003d\u0027The SQLAlchemy connection string used to connect to the \u0027"},{"line_number":278,"context_line":"                    \u0027database\u0027,"},{"line_number":279,"context_line":"               deprecated_opts\u003d[cfg.DeprecatedOpt(\u0027sql_connection\u0027,"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMC4%3D","line":276,"in_reply_to":"AAAATn%2F%2FMT4%3D","updated":"2013-11-13 07:53:25.000000000","message":"If not change, it will hit pep8","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"}],"ceilometer/openstack/common/db/sqlalchemy/test_migrations.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":114,"context_line":""},{"line_number":115,"context_line":"        # Load test databases from the config file. Only do this"},{"line_number":116,"context_line":"        # once. No need to re-run this on each test..."},{"line_number":117,"context_line":"        LOG.debug(_(\u0027config_path is %s\u0027) % self.CONFIG_FILE_PATH)"},{"line_number":118,"context_line":"        if os.path.exists(self.CONFIG_FILE_PATH):"},{"line_number":119,"context_line":"            cp \u003d ConfigParser.RawConfigParser()"},{"line_number":120,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byx8%3D","line":117,"updated":"2013-11-20 04:51:44.000000000","message":"Do we need translation in test modules?","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":285,"context_line":"                if check:"},{"line_number":286,"context_line":"                    check(engine, data)"},{"line_number":287,"context_line":"        except Exception:"},{"line_number":288,"context_line":"            LOG.error(_(\"Failed to migrate to version %s on engine %s\") %"},{"line_number":289,"context_line":"                      (version, engine))"},{"line_number":290,"context_line":"            raise"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byxw%3D","line":288,"updated":"2013-11-20 04:51:44.000000000","message":"use dictionary","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/openstack/common/rpc/common.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                # log the issue and the kwargs"},{"line_number":90,"context_line":"                LOG.exception(_(\u0027Exception in string format operation\u0027))"},{"line_number":91,"context_line":"                for name, value in kwargs.iteritems():"},{"line_number":92,"context_line":"                    LOG.error(_(\"%s: %s\") % (name, value))"},{"line_number":93,"context_line":"                # at least get the core message out if something happened"},{"line_number":94,"context_line":"                message \u003d self.msg_fmt"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMTo%3D","line":92,"updated":"2013-11-13 05:40:03.000000000","message":"remove this, these variables can\u0027t be transalted","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":89,"context_line":"                # log the issue and the kwargs"},{"line_number":90,"context_line":"                LOG.exception(_(\u0027Exception in string format operation\u0027))"},{"line_number":91,"context_line":"                for name, value in kwargs.iteritems():"},{"line_number":92,"context_line":"                    LOG.error(_(\"%s: %s\") % (name, value))"},{"line_number":93,"context_line":"                # at least get the core message out if something happened"},{"line_number":94,"context_line":"                message \u003d self.msg_fmt"},{"line_number":95,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMCk%3D","line":92,"in_reply_to":"AAAATn%2F%2FMTo%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"}],"ceilometer/pipeline.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":173,"context_line":"                \"with parameter %(param)s\") % ("},{"line_number":174,"context_line":"                {\u0027pipeline\u0027: self,"},{"line_number":175,"context_line":"                 \u0027name\u0027: transformer[\u0027name\u0027],"},{"line_number":176,"context_line":"                 \u0027param\u0027: parameter}))"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":"        return transformers"},{"line_number":179,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2Fkgc%3D","line":176,"updated":"2013-11-01 05:46:46.000000000","message":"your code changes aren\u0027t right, you should use \"_\" like this:\nLOG.info(_(\"Pipeline %s: Setup transformer instance %s \"\n                     \"with parameter %s\"),\n                     self,\n                     transformer[\u0027name\u0027],\n                     parameter)","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                        \"Pipeline %(pipeline)s: Sample dropped by \""},{"line_number":187,"context_line":"                        \"transformer %(trans)s\") % ("},{"line_number":188,"context_line":"                        {\u0027pipeline\u0027: self,"},{"line_number":189,"context_line":"                         \u0027param\u0027: transformer}))"},{"line_number":190,"context_line":"                    return"},{"line_number":191,"context_line":"            return sample"},{"line_number":192,"context_line":"        except Exception as err:"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FkgU%3D","line":189,"updated":"2013-11-01 05:46:46.000000000","message":"ditto","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":195,"context_line":"                          \"%(trans)s for %(smp)s\") % ("},{"line_number":196,"context_line":"                        {\u0027pipeline\u0027: self,"},{"line_number":197,"context_line":"                         \u0027trans\u0027: transformer,"},{"line_number":198,"context_line":"                         \u0027smp\u0027: sample}))"},{"line_number":199,"context_line":"            LOG.exception(err)"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"    def _publish_samples(self, start, ctxt, samples):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FkgQ%3D","line":198,"updated":"2013-11-01 05:46:46.000000000","message":"ditto","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":216,"context_line":"                \"%(smp)s from %(trans)s transformer\") % ("},{"line_number":217,"context_line":"                {\u0027pipeline\u0027: self,"},{"line_number":218,"context_line":"                 \u0027smp\u0027: sample,"},{"line_number":219,"context_line":"                 \u0027trans\u0027: start}))"},{"line_number":220,"context_line":"            sample \u003d self._transform_sample(start, ctxt, sample)"},{"line_number":221,"context_line":"            if sample:"},{"line_number":222,"context_line":"                transformed_samples.append(sample)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FkgM%3D","line":219,"updated":"2013-11-01 05:46:46.000000000","message":"ditto","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":231,"context_line":"                        \"Pipeline %(pipeline)s: Continue after error \""},{"line_number":232,"context_line":"                        \"from publisher %(pub)s\") % ("},{"line_number":233,"context_line":"                        {\u0027pipeline\u0027: self,"},{"line_number":234,"context_line":"                         \u0027pub\u0027: p}))"},{"line_number":235,"context_line":"            LOG.audit(_(\"Pipeline %s: Published samples\"), self)"},{"line_number":236,"context_line":""},{"line_number":237,"context_line":"    def publish_sample(self, ctxt, sample):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FkgI%3D","line":234,"updated":"2013-11-01 05:46:46.000000000","message":"ditto","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"8ebddc964adee4c34fd154e1c72d97048d3c6ee8","unresolved":false,"context_lines":[{"line_number":291,"context_line":"                    \"Pipeline %(pipeline)s: Error flushing \""},{"line_number":292,"context_line":"                    \"transformer %(trans)s\") % ("},{"line_number":293,"context_line":"                    {\u0027pipeline\u0027: self,"},{"line_number":294,"context_line":"                     \u0027trans\u0027: transformer}))"},{"line_number":295,"context_line":"                LOG.exception(err)"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":"    def get_interval(self):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2FkgE%3D","line":294,"updated":"2013-11-01 05:46:46.000000000","message":"ditto","commit_id":"2571847648ff723b6815a654ac8f65f6e42c265d"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                    LOG.debug(_("},{"line_number":186,"context_line":"                        \"Pipeline %(pipeline)s: Sample dropped by \""},{"line_number":187,"context_line":"                        \"transformer %(trans)s\") % ({\u0027pipeline\u0027: self,"},{"line_number":188,"context_line":"                                                     \u0027param\u0027: transformer}))"},{"line_number":189,"context_line":"                    return"},{"line_number":190,"context_line":"            return sample"},{"line_number":191,"context_line":"        except Exception as err:"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2Byxk%3D","line":188,"updated":"2013-11-20 04:51:44.000000000","message":"param \u003e trans","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/storage/__init__.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"230409feeb23583ddf50df5d0f2b39d3fbab6105","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from stevedore import driver"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ceilometer.openstack.common import log"},{"line_number":28,"context_line":"from ceilometer import utils"},{"line_number":29,"context_line":"from ceilometer import service"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2FkP0%3D","line":28,"updated":"2013-11-01 07:49:01.000000000","message":"please try adding below code line into the file\n\"from ceilometer.openstack.common.gettextutils import _\"","commit_id":"ff003bba2ac6d9ec4a18564c02811109d91e4a20"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"17c0e5bb0794002d4e58b6b735a86e477d3473f0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"from stevedore import driver"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from ceilometer.openstack.common import log"},{"line_number":28,"context_line":"from ceilometer import utils"},{"line_number":29,"context_line":"from ceilometer import service"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAATn%2F%2Fj8U%3D","line":28,"in_reply_to":"AAAATn%2F%2FkP0%3D","updated":"2013-11-01 10:03:10.000000000","message":"Done","commit_id":"ff003bba2ac6d9ec4a18564c02811109d91e4a20"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"0fcd651cd88fe08e81949a6f173704b2a65d3c92","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if conf.database_connection:"},{"line_number":68,"context_line":"        conf.set_override(\u0027connection\u0027, conf.database_connection,"},{"line_number":69,"context_line":"                          group\u003d\u0027database\u0027)"},{"line_number":70,"context_line":"    engine_name \u003d urlparse.urlparse(conf.database.connection).scheme"},{"line_number":71,"context_line":"    LOG.debug(_(\u0027looking for %(name)r driver in %(namespace)r\u0027) % ("},{"line_number":72,"context_line":"              {\u0027name\u0027: engine_name,"},{"line_number":73,"context_line":"               \u0027namespace\u0027: STORAGE_ENGINE_NAMESPACE}))"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2BsWY%3D","line":70,"updated":"2013-11-21 13:25:21.000000000","message":"Some messages are started with up-case and some with lower-case. Should we choose the one way?","commit_id":"74778636f7f20b128fb238029af4376f9786c162"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"62fc172390a6c6785cc4ca61c08505cd67c818fd","unresolved":false,"context_lines":[{"line_number":67,"context_line":"    if conf.database_connection:"},{"line_number":68,"context_line":"        conf.set_override(\u0027connection\u0027, conf.database_connection,"},{"line_number":69,"context_line":"                          group\u003d\u0027database\u0027)"},{"line_number":70,"context_line":"    engine_name \u003d urlparse.urlparse(conf.database.connection).scheme"},{"line_number":71,"context_line":"    LOG.debug(_(\u0027looking for %(name)r driver in %(namespace)r\u0027) % ("},{"line_number":72,"context_line":"              {\u0027name\u0027: engine_name,"},{"line_number":73,"context_line":"               \u0027namespace\u0027: STORAGE_ENGINE_NAMESPACE}))"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAATn%2F%2BsDc%3D","line":70,"in_reply_to":"AAAATn%2F%2BsWY%3D","updated":"2013-11-21 14:36:27.000000000","message":"I just add i18n support, if the case issue is matter, it shall be in another commit IMO. thx.","commit_id":"74778636f7f20b128fb238029af4376f9786c162"}],"ceilometer/storage/impl_hbase.py":[{"author":{"_account_id":7138,"name":"David Jia","email":"jiataotj@cn.ibm.com","username":"jiataotj"},"change_message_id":"5e234ca811cec2429afedf58f16c89ba18cbbf2f","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        LOG.debug(_(\u0027connecting to HBase on %(ch)s:%(cp)s\u0027) % ("},{"line_number":137,"context_line":"                  {\u0027ch\u0027: conf[\u0027host\u0027], \u0027cp\u0027: conf[\u0027port\u0027]}))"},{"line_number":138,"context_line":"        return happybase.Connection(host\u003dconf[\u0027host\u0027],"},{"line_number":139,"context_line":"                                    port\u003dconf[\u0027port\u0027],"},{"line_number":140,"context_line":"                                    table_prefix\u003dconf[\u0027table_prefix\u0027])"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMTU%3D","line":138,"updated":"2013-11-13 05:40:03.000000000","message":"why change this line?","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":8607,"name":"ChenZheng","email":"czheng@cn.ibm.com","username":"ChenZheng"},"change_message_id":"9a394d268d9ccb038281f7b4d1ca005bf509cf04","unresolved":false,"context_lines":[{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        LOG.debug(_(\u0027connecting to HBase on %(ch)s:%(cp)s\u0027) % ("},{"line_number":137,"context_line":"                  {\u0027ch\u0027: conf[\u0027host\u0027], \u0027cp\u0027: conf[\u0027port\u0027]}))"},{"line_number":138,"context_line":"        return happybase.Connection(host\u003dconf[\u0027host\u0027],"},{"line_number":139,"context_line":"                                    port\u003dconf[\u0027port\u0027],"},{"line_number":140,"context_line":"                                    table_prefix\u003dconf[\u0027table_prefix\u0027])"},{"line_number":141,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAATn%2F%2FMCc%3D","line":138,"in_reply_to":"AAAATn%2F%2FMTU%3D","updated":"2013-11-13 07:53:25.000000000","message":"Done","commit_id":"324d234f02c50e99f232f9189ed8a4ce81c15c69"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":134,"context_line":"          in-memory connection."},{"line_number":135,"context_line":"        \"\"\""},{"line_number":136,"context_line":"        LOG.debug(_(\u0027connecting to HBase on %(ch)s:%(cp)s\u0027) % ("},{"line_number":137,"context_line":"                  {\u0027ch\u0027: conf[\u0027host\u0027], \u0027cp\u0027: conf[\u0027port\u0027]}))"},{"line_number":138,"context_line":"        return happybase.Connection(host\u003dconf[\u0027host\u0027], port\u003dconf[\u0027port\u0027],"},{"line_number":139,"context_line":"                                    table_prefix\u003dconf[\u0027table_prefix\u0027])"},{"line_number":140,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByxU%3D","line":137,"updated":"2013-11-20 04:51:44.000000000","message":"spell out ch and cp","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/storage/impl_log.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":55,"context_line":"        \"\"\""},{"line_number":56,"context_line":"        LOG.info(_(\u0027metering data %(cn)s for %(rid)s: %(cv)s\u0027) % ("},{"line_number":57,"context_line":"                 {\u0027cn\u0027: data[\u0027counter_name\u0027], \u0027rid\u0027: data[\u0027resource_id\u0027],"},{"line_number":58,"context_line":"                  \u0027cv\u0027: data[\u0027counter_volume\u0027]}))"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":"    def clear_expired_metering_data(self, ttl):"},{"line_number":61,"context_line":"        \"\"\"Clear expired data from the backend storage system according to the"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByxM%3D","line":58,"updated":"2013-11-20 04:51:44.000000000","message":"spell out cn, cv and rid","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}],"ceilometer/transformer/conversions.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def handle_sample(self, context, s):"},{"line_number":100,"context_line":"        \"\"\"Handle a sample, converting if necessary.\"\"\""},{"line_number":101,"context_line":"        LOG.debug(_(\u0027handling sample %s\u0027) % (s,))"},{"line_number":102,"context_line":"        if (self.source.get(\u0027unit\u0027, s.unit) \u003d\u003d s.unit):"},{"line_number":103,"context_line":"            s \u003d self._convert(s)"},{"line_number":104,"context_line":"            LOG.debug(_(\u0027converted to: %s\u0027) % (s,))"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByxE%3D","line":101,"updated":"2013-11-20 04:51:44.000000000","message":"leave ,?","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"3c5f3d374fb86c3d9799497381b649eaada63cb4","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def handle_sample(self, context, s):"},{"line_number":122,"context_line":"        \"\"\"Handle a sample, converting if necessary.\"\"\""},{"line_number":123,"context_line":"        LOG.debug(_(\u0027handling sample %s\u0027) % (s,))"},{"line_number":124,"context_line":"        key \u003d s.name + s.resource_id"},{"line_number":125,"context_line":"        prev \u003d self.cache.get(key)"},{"line_number":126,"context_line":"        timestamp \u003d timeutils.parse_isotime(s.timestamp)"}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAATn%2F%2ByxA%3D","line":123,"updated":"2013-11-20 04:51:44.000000000","message":"leave ,","commit_id":"7f2ae74ef76c9d7dbb725f153cd15725efd83b33"}]}