)]}'
{"ceilometer/transformer/conversions.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"de0c482b4350e5e32ecdb11e0d60396c17cc25e6","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            volume_delta \u003d (s.volume - prev_volume"},{"line_number":213,"context_line":"                            if (prev_volume \u003c\u003d s.volume or"},{"line_number":214,"context_line":"                                s.type !\u003d sample.TYPE_CUMULATIVE)"},{"line_number":215,"context_line":"                            else s.volume)"},{"line_number":216,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"},{"line_number":217,"context_line":"                              if time_delta else 0.0)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_f97837f9","side":"PARENT","line":215,"updated":"2018-03-06 16:17:32.000000000","message":"just change this to use prev_volume","commit_id":"14906f8672282b21467d705b316f0b8ec88c6bee"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"f1caffbdbe2bc1705a9aafb6574d88217bf5c9e3","unresolved":false,"context_lines":[{"line_number":212,"context_line":"            volume_delta \u003d (s.volume - prev_volume"},{"line_number":213,"context_line":"                            if (prev_volume \u003c\u003d s.volume or"},{"line_number":214,"context_line":"                                s.type !\u003d sample.TYPE_CUMULATIVE)"},{"line_number":215,"context_line":"                            else s.volume)"},{"line_number":216,"context_line":"            rate_of_change \u003d ((1.0 * volume_delta / time_delta)"},{"line_number":217,"context_line":"                              if time_delta else 0.0)"},{"line_number":218,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_d98773d7","side":"PARENT","line":215,"in_reply_to":"ff6b8bd7_f97837f9","updated":"2018-03-06 16:17:49.000000000","message":"ignore this.","commit_id":"14906f8672282b21467d705b316f0b8ec88c6bee"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"de0c482b4350e5e32ecdb11e0d60396c17cc25e6","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            # times greater than s.volume, we may get wrong rate of change"},{"line_number":215,"context_line":"            # from this sample."},{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), (s,))"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_b90ddf91","line":217,"range":{"start_line":217,"start_character":31,"end_line":217,"end_character":32},"updated":"2018-03-06 16:17:32.000000000","message":"how is previous sample bigger if it\u0027s not out of order?","commit_id":"dc46e4eb1bb8d93a2d22265512f78669a4e6ecd3"},{"author":{"_account_id":26159,"name":"xiexianbin","email":"xiexianbin@yovole.com","username":"xianbin"},"change_message_id":"e02870d8e0782a4a263d616717f7f3bc891744fb","unresolved":false,"context_lines":[{"line_number":214,"context_line":"            # times greater than s.volume, we may get wrong rate of change"},{"line_number":215,"context_line":"            # from this sample."},{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), (s,))"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_4dd09951","line":217,"range":{"start_line":217,"start_character":31,"end_line":217,"end_character":32},"in_reply_to":"ff6b8bd7_b90ddf91","updated":"2018-03-07 03:09:30.000000000","message":"1. sample out of order.\n2. some counter for cumulative value is an unsigned interger, may be more than 2^32 or 2^64.","commit_id":"dc46e4eb1bb8d93a2d22265512f78669a4e6ecd3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"de0c482b4350e5e32ecdb11e0d60396c17cc25e6","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            # from this sample."},{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), (s,))"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"},{"line_number":221,"context_line":"                volume_delta \u003d s.volume - prev_volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff6b8bd7_f91357b7","line":218,"range":{"start_line":218,"start_character":56,"end_line":218,"end_character":60},"updated":"2018-03-06 16:17:32.000000000","message":"this shouldn\u0027t be a tuple","commit_id":"dc46e4eb1bb8d93a2d22265512f78669a4e6ecd3"},{"author":{"_account_id":26159,"name":"xiexianbin","email":"xiexianbin@yovole.com","username":"xianbin"},"change_message_id":"e02870d8e0782a4a263d616717f7f3bc891744fb","unresolved":false,"context_lines":[{"line_number":215,"context_line":"            # from this sample."},{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), (s,))"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"},{"line_number":221,"context_line":"                volume_delta \u003d s.volume - prev_volume"}],"source_content_type":"text/x-python","patch_set":5,"id":"df7087c5_5f04c3c6","line":218,"range":{"start_line":218,"start_character":56,"end_line":218,"end_character":60},"in_reply_to":"ff6b8bd7_f91357b7","updated":"2018-03-07 03:09:30.000000000","message":"Done","commit_id":"dc46e4eb1bb8d93a2d22265512f78669a4e6ecd3"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"c1c6369fd1e08294d32698ab8078fc1395930cbf","unresolved":false,"context_lines":[{"line_number":213,"context_line":"            # samples, just drop it. because prev_volume is thousands of"},{"line_number":214,"context_line":"            # times greater than s.volume, we may get wrong rate of change"},{"line_number":215,"context_line":"            # from this sample."},{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), s)"},{"line_number":219,"context_line":"                return None"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_18516537","line":216,"updated":"2018-03-08 04:14:53.000000000","message":"your scenarios in previous patchset don\u0027t seem correct:\n\n1. it can\u0027t be out of order, line 203-207 checks for this already. if it is, it\u0027s broken and we should fix above.\n\n2. i don\u0027t understand unsigned scenario, can you explain? it\u0027s a cumulative sample so it should always be increasing (unless it resets like when vm restarts)","commit_id":"1ce119b2d5c0dfe13f4c5d2a634af1ccbecd8deb"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"3b98990a33269707fe1b81efd823e1c0ddb6acfd","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), s)"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"},{"line_number":221,"context_line":"                volume_delta \u003d s.volume - prev_volume"},{"line_number":222,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_00a14846","line":219,"range":{"start_line":219,"start_character":16,"end_line":219,"end_character":27},"updated":"2018-03-15 02:10:29.000000000","message":"Why not just use s.volume?\nFor example, the VM restarts may cause the data not to increase, but dropping it may not be a good idea.","commit_id":"1ce119b2d5c0dfe13f4c5d2a634af1ccbecd8deb"},{"author":{"_account_id":26159,"name":"xiexianbin","email":"xiexianbin@yovole.com","username":"xianbin"},"change_message_id":"cb43118452519efbb1a2dc0f525b2135d279e52c","unresolved":false,"context_lines":[{"line_number":216,"context_line":"            if prev_volume \u003e s.volume and s.type \u003d\u003d sample.TYPE_CUMULATIVE:"},{"line_number":217,"context_line":"                LOG.warning(_(\u0027dropping less than prev \u0027"},{"line_number":218,"context_line":"                              \u0027cumulative sample: %s\u0027), s)"},{"line_number":219,"context_line":"                return None"},{"line_number":220,"context_line":"            elif prev_volume \u003c\u003d s.volume or s.type !\u003d sample.TYPE_CUMULATIVE:"},{"line_number":221,"context_line":"                volume_delta \u003d s.volume - prev_volume"},{"line_number":222,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":6,"id":"df7087c5_ef573357","line":219,"range":{"start_line":219,"start_character":16,"end_line":219,"end_character":27},"in_reply_to":"df7087c5_00a14846","updated":"2018-03-16 12:05:47.000000000","message":"1.use s.volume may get wrong rate like :https://goo.gl/hGgUJp\n2. qemu-kvm-ev-2.6.0-28，restart vm not no-increase.","commit_id":"1ce119b2d5c0dfe13f4c5d2a634af1ccbecd8deb"}]}