)]}'
{"tests/network/test_floatingip.py":[{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b0cb0ae33fec28a3e3db96c2866424358d5a098e","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":38,"context_line":"        self.manager \u003d manager.AgentManager()"},{"line_number":39,"context_line":"        self.pollster \u003d floatingip.FloatingIPPollster()"},{"line_number":40,"context_line":"        fake_ips \u003d self.faux_get_ips(self)"},{"line_number":41,"context_line":"        patch_virt \u003d mock.patch(\u0027ceilometer.nova_client.Client.\u0027"},{"line_number":42,"context_line":"                                \u0027floating_ip_get_all\u0027,"},{"line_number":43,"context_line":"                                mock.Mock(return_value\u003dfake_ips))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FYak%3D","line":40,"updated":"2013-11-07 17:14:17.000000000","message":"(unrelated to the issue) \"faux\" sounds like the french word for \"false\" or \"fake\", if it\u0027s the case, it would be nice to rename the method to fake_get_ips().","commit_id":"1bfa96e996617d62cad019390be7f2a56446484b"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"208c505630bf814609ca6367431bf8d458b59e81","unresolved":false,"context_lines":[{"line_number":37,"context_line":"        self.context \u003d context.get_admin_context()"},{"line_number":38,"context_line":"        self.manager \u003d manager.AgentManager()"},{"line_number":39,"context_line":"        self.pollster \u003d floatingip.FloatingIPPollster()"},{"line_number":40,"context_line":"        fake_ips \u003d self.faux_get_ips(self)"},{"line_number":41,"context_line":"        patch_virt \u003d mock.patch(\u0027ceilometer.nova_client.Client.\u0027"},{"line_number":42,"context_line":"                                \u0027floating_ip_get_all\u0027,"},{"line_number":43,"context_line":"                                mock.Mock(return_value\u003dfake_ips))"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FYR8%3D","line":40,"in_reply_to":"AAAATn%2F%2FYak%3D","updated":"2013-11-07 18:51:06.000000000","message":"You may use \"faux\" in English :)\n\nhttp://www.wordreference.com/enfr/faux","commit_id":"1bfa96e996617d62cad019390be7f2a56446484b"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b0cb0ae33fec28a3e3db96c2866424358d5a098e","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        fake_ips \u003d self.faux_get_ips(self)"},{"line_number":41,"context_line":"        patch_virt \u003d mock.patch(\u0027ceilometer.nova_client.Client.\u0027"},{"line_number":42,"context_line":"                                \u0027floating_ip_get_all\u0027,"},{"line_number":43,"context_line":"                                mock.Mock(return_value\u003dfake_ips))"},{"line_number":44,"context_line":"        patch_virt.start()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FYa8%3D","line":43,"updated":"2013-11-07 17:14:17.000000000","message":"You can just write: patch(\"...\", return_value\u003dfake_ips) instead of patch(\"...\", mock.Mock(return_value\u003dfake_ips))","commit_id":"1bfa96e996617d62cad019390be7f2a56446484b"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"6b97b1cc6db40cdaf606b2980cdc94185a96504a","unresolved":false,"context_lines":[{"line_number":40,"context_line":"        fake_ips \u003d self.faux_get_ips(self)"},{"line_number":41,"context_line":"        patch_virt \u003d mock.patch(\u0027ceilometer.nova_client.Client.\u0027"},{"line_number":42,"context_line":"                                \u0027floating_ip_get_all\u0027,"},{"line_number":43,"context_line":"                                mock.Mock(return_value\u003dfake_ips))"},{"line_number":44,"context_line":"        patch_virt.start()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FXoE%3D","line":43,"in_reply_to":"AAAATn%2F%2FYa8%3D","updated":"2013-11-08 03:29:17.000000000","message":"+1","commit_id":"1bfa96e996617d62cad019390be7f2a56446484b"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"b0cb0ae33fec28a3e3db96c2866424358d5a098e","unresolved":false,"context_lines":[{"line_number":44,"context_line":"        patch_virt.start()"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    @staticmethod"},{"line_number":47,"context_line":"    def faux_get_ips(self):"},{"line_number":48,"context_line":"        ips \u003d []"},{"line_number":49,"context_line":"        for i in range(1, 4):"},{"line_number":50,"context_line":"            ip \u003d mock.MagicMock()"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2FYaE%3D","line":47,"updated":"2013-11-07 17:14:17.000000000","message":"(unrelated to the issue) it\u0027s strange for a static method to get a self parameter... especially when self is not used","commit_id":"1bfa96e996617d62cad019390be7f2a56446484b"}]}