)]}'
{"ceilometer/tests/collector/dispatcher/test_db.py":[{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"0106fc3d594e69fbd922d9e0b6fa90dfd96dcb3f","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                          \u0027record_metering_data\u0027) as record_metering_data:"},{"line_number":91,"context_line":"            self.dispatcher.record_metering_data(self.ctx, msg)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            record_metering_data.assert_called_once_with(expected)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_timestamp_tzinfo_conversion(self):"},{"line_number":96,"context_line":"        msg \u003d {\u0027counter_name\u0027: \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B6ak%3D","line":93,"updated":"2013-11-18 16:39:16.000000000","message":"I have seen this check done outside the with, do you know if it makes a diff?","commit_id":"9f784f18405500f02cbaac6d28d3386bd10b1097"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3b47a0284c10189e562c854cfed1dfac7c4c5283","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                          \u0027record_metering_data\u0027) as record_metering_data:"},{"line_number":91,"context_line":"            self.dispatcher.record_metering_data(self.ctx, msg)"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"            record_metering_data.assert_called_once_with(expected)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    def test_timestamp_tzinfo_conversion(self):"},{"line_number":96,"context_line":"        msg \u003d {\u0027counter_name\u0027: \u0027test\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B18g%3D","line":93,"in_reply_to":"AAAATn%2F%2B6ak%3D","updated":"2013-11-19 13:14:30.000000000","message":"Done","commit_id":"9f784f18405500f02cbaac6d28d3386bd10b1097"}],"ceilometer/tests/collector/test_service.py":[{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"ec581bc9c0f510cea46a0a4121fe88d362bdabfd","unresolved":false,"context_lines":[{"line_number":134,"context_line":"        self.counter[\u0027counter_type\u0027] \u003d self.counter[\u0027type\u0027]"},{"line_number":135,"context_line":"        self.counter[\u0027counter_unit\u0027] \u003d self.counter[\u0027unit\u0027]"},{"line_number":136,"context_line":""},{"line_number":137,"context_line":"        with self._patch_socket():"},{"line_number":138,"context_line":"            self.srv.start()"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"        mock_dispatcher.record_metering_data.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B9iU%3D","line":137,"updated":"2013-11-18 03:01:26.000000000","message":"Old test case verifies whether both udp_socket.setsockopt is called and udp_socket.bind is called.\n\nI think this test should verify those.\ne.g.\n \n def _make_fake_socket(self):\n   udp_socket \u003d mock.Mock()\n   ....\n   return udp_socket\n\n def _patch_object(self, udp_socket):\n   return patch(\u0027socket.socket\u0027, return_value\u003dudp_socket)\n\n def _verify_udp_socket( self, fake_socket):\n   fake_socket.setsockopt.assert_called_once_with(socket.SOL_SOCKET, socket.SO_REUSEADDR, 1)\n   fake_socket.bind((self.CONF.collector.udp_address, self.CONF.collector.udp_port))\n\n def test_udp_receive(self):\n   ...\n   fake_socket \u003d self._make_fake_socket()\n   with self._patch_object(fake_socket):\n     self.srv.start()\n   self._verify_udp_socket(fake_socket)\n   ...","commit_id":"ddbbc240346e337324d3a9af546b5c2928292732"},{"author":{"_account_id":7203,"name":"yuuichi fujioka","email":"fujioka.yuuichi@gmail.com","username":"FujiokaYuuichi"},"change_message_id":"ec581bc9c0f510cea46a0a4121fe88d362bdabfd","unresolved":false,"context_lines":[{"line_number":157,"context_line":"        self.counter[\u0027counter_type\u0027] \u003d self.counter[\u0027type\u0027]"},{"line_number":158,"context_line":"        self.counter[\u0027counter_unit\u0027] \u003d self.counter[\u0027unit\u0027]"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"        with self._patch_socket():"},{"line_number":161,"context_line":"            self.srv.start()"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"        mock_dispatcher.record_metering_data.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B9iM%3D","line":160,"updated":"2013-11-18 03:01:26.000000000","message":"ditto","commit_id":"ddbbc240346e337324d3a9af546b5c2928292732"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"89efb697f259663f5b7e710c7ca300ab201546eb","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _verify_udp_socket(self, udp_socket):"},{"line_number":108,"context_line":"        udp_socket.setsockopt.assert_called_once_with(socket.SOL_SOCKET,"},{"line_number":109,"context_line":"                                                      socket.SO_REUSEADDR, 1)"},{"line_number":110,"context_line":"        udp_socket.bind((self.CONF.collector.udp_address,"},{"line_number":111,"context_line":"                         self.CONF.collector.udp_port))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B8Io%3D","line":110,"updated":"2013-11-18 11:05:47.000000000","message":"\u0027bind\u0027 doesn\u0027t need \u0027assert_called_once_with\u0027 ?","commit_id":"9db6c2fcda48e6d871008b267380972a688c5e4a"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"8b0c8a3f4f5950dbc4e7f78e023318d8de7c81ef","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    def _verify_udp_socket(self, udp_socket):"},{"line_number":108,"context_line":"        udp_socket.setsockopt.assert_called_once_with(socket.SOL_SOCKET,"},{"line_number":109,"context_line":"                                                      socket.SO_REUSEADDR, 1)"},{"line_number":110,"context_line":"        udp_socket.bind((self.CONF.collector.udp_address,"},{"line_number":111,"context_line":"                         self.CONF.collector.udp_port))"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2B7hk%3D","line":110,"in_reply_to":"AAAATn%2F%2B8Io%3D","updated":"2013-11-18 13:23:34.000000000","message":"Oops, correct. My patch base 2 is based on Yuuichi Fujioka \u0027s comment, I didn\u0027t notice the missing call.","commit_id":"9db6c2fcda48e6d871008b267380972a688c5e4a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"5b4522e0e3a0311d0005543e7ca5546f54244032","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":"from mock import patch"},{"line_number":25,"context_line":"import msgpack"},{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"from stevedore import extension"},{"line_number":28,"context_line":"from stevedore.tests import manager as test_manager"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B4N0%3D","line":26,"updated":"2013-11-19 02:14:57.000000000","message":"this is a standard library. should be in the old place.","commit_id":"9f784f18405500f02cbaac6d28d3386bd10b1097"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"3b47a0284c10189e562c854cfed1dfac7c4c5283","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import mock"},{"line_number":24,"context_line":"from mock import patch"},{"line_number":25,"context_line":"import msgpack"},{"line_number":26,"context_line":"import socket"},{"line_number":27,"context_line":"from stevedore import extension"},{"line_number":28,"context_line":"from stevedore.tests import manager as test_manager"},{"line_number":29,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAATn%2F%2B180%3D","line":26,"in_reply_to":"AAAATn%2F%2B4N0%3D","updated":"2013-11-19 13:14:30.000000000","message":"Done","commit_id":"9f784f18405500f02cbaac6d28d3386bd10b1097"}]}