)]}'
{"ceilometer/tests/compute/test_manager.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ac25e0a90c4f166ef480fc123d21b7589af4a36e","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":"from ceilometer.compute import manager"},{"line_number":23,"context_line":"from ceilometer import nova_client"},{"line_number":24,"context_line":"from ceilometer.openstack.common.fixture.mockpatch import PatchObject"},{"line_number":25,"context_line":"from ceilometer.openstack.common import test"},{"line_number":26,"context_line":"from ceilometer.tests import agentbase"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B4Ps%3D","line":24,"updated":"2013-11-19 02:05:32.000000000","message":"Please do not import objects, only modules. See http://docs.openstack.org/developer/hacking/#imports","commit_id":"babfd2a95da89b7ffd47d292d6aa69378d1a5dfb"},{"author":{"_account_id":8122,"name":"Cyril Roelandt","email":"cyril@redhat.com","username":"cyril.roelandt.enovance"},"change_message_id":"c6c905384c7dbca0338b8e62e2dc412f3029ecad","unresolved":false,"context_lines":[{"line_number":64,"context_line":"        self.useFixture(PatchObject(nova_client.Client,"},{"line_number":65,"context_line":"                                    \u0027instance_get_all_by_host\u0027,"},{"line_number":66,"context_line":"                                    side_effect\u003dinstance_get_all_by_host))"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"    def test_notifier_task(self):"},{"line_number":69,"context_line":"        self.mgr.setup_notifier_task()"},{"line_number":70,"context_line":"        self.mgr.poll_instance(None, self.instance)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B4vc%3D","line":67,"updated":"2013-11-18 23:14:52.000000000","message":"Can\u0027t you keep the lambda here ?","commit_id":"babfd2a95da89b7ffd47d292d6aa69378d1a5dfb"},{"author":{"_account_id":5313,"name":"David Peraza","email":"david_peraza@persistentsys.com","username":"dperaza"},"change_message_id":"563e6afe6fe5f545d5af91d3c12848d17d348361","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_manager_exception_persistency(self):"},{"line_number":86,"context_line":"        super(TestRunTasks, self).test_manager_exception_persistency()"},{"line_number":87,"context_line":"        with mock.patch.object(nova_client.Client, \u0027instance_get_all_by_host\u0027,"},{"line_number":88,"context_line":"                               side_effect\u003dlambda *x: self._raise_exception()):"},{"line_number":89,"context_line":"            mgr \u003d manager.AgentManager()"},{"line_number":90,"context_line":"            polling_task \u003d manager.PollingTask(mgr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2Byu8%3D","line":87,"updated":"2013-11-20 05:12:37.000000000","message":"I like how decorators work, specially if you have to nest multiple mocks: http://www.voidspace.org.uk/python/mock/patch.html. OK in this case though if you want to keep like this","commit_id":"b6636897b1490e6c101f6302cf934362f634d234"},{"author":{"_account_id":9107,"name":"Victor Stinner","email":"vstinner@redhat.com","username":"haypo"},"change_message_id":"523cd241d35c4670b4bde8f2841c2238d3956161","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    def test_manager_exception_persistency(self):"},{"line_number":86,"context_line":"        super(TestRunTasks, self).test_manager_exception_persistency()"},{"line_number":87,"context_line":"        with mock.patch.object(nova_client.Client, \u0027instance_get_all_by_host\u0027,"},{"line_number":88,"context_line":"                               side_effect\u003dlambda *x: self._raise_exception()):"},{"line_number":89,"context_line":"            mgr \u003d manager.AgentManager()"},{"line_number":90,"context_line":"            polling_task \u003d manager.PollingTask(mgr)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F%2ByIw%3D","line":87,"in_reply_to":"AAAATn%2F%2Byu8%3D","updated":"2013-11-20 09:04:59.000000000","message":"The problem is that self is not accessible in the decorator. It might be possible to convert _raise_exception() to a static method or class method, but I prefer with syntax to delim exactly which lines are modified by the patch.","commit_id":"b6636897b1490e6c101f6302cf934362f634d234"}],"ceilometer/tests/test_novaclient.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"ac25e0a90c4f166ef480fc123d21b7589af4a36e","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import novaclient"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"from ceilometer import nova_client"},{"line_number":25,"context_line":"from ceilometer.openstack.common.fixture.mockpatch import PatchObject"},{"line_number":26,"context_line":"from ceilometer.openstack.common import test"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAATn%2F%2B4Pg%3D","line":25,"updated":"2013-11-19 02:05:32.000000000","message":"not to import object, http://docs.openstack.org/developer/hacking/#imports","commit_id":"babfd2a95da89b7ffd47d292d6aa69378d1a5dfb"}]}