)]}'
{"ceilometer/compute/discovery.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"abc25dcce62e7278132bb42615f4dbf5c4b4cd02","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":298,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        filters \u003d {\u0027binding:host_id\u0027: self.conf.host}"},{"line_number":301,"context_line":"        ports \u003d self.neutron_cli.port_get_all(**filters)"},{"line_number":302,"context_line":"        return [p for p in ports"},{"line_number":303,"context_line":"                if p.get(\u0027status\u0027) \u003d\u003d \u0027ACTIVE\u0027 and p.get(\u0027admin_state_up\u0027)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_014c949c","line":300,"updated":"2018-08-06 19:15:18.000000000","message":"This will add a huge load on neutron API. Since all compute nodes will poll it.\n\nWe already made this mistake one time, I don\u0027t want to see it a second time.","commit_id":"bfd3318f476c840741c0cf866ea53afabb590645"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"ff02739252ab1775d745e9c51a002c71e5d9bb6a","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":298,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        filters \u003d {\u0027binding:host_id\u0027: self.conf.host}"},{"line_number":301,"context_line":"        ports \u003d self.neutron_cli.port_get_all(**filters)"},{"line_number":302,"context_line":"        return [p for p in ports"},{"line_number":303,"context_line":"                if p.get(\u0027status\u0027) \u003d\u003d \u0027ACTIVE\u0027 and p.get(\u0027admin_state_up\u0027)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_bb2132b7","line":300,"in_reply_to":"3f79a3b5_014c949c","updated":"2018-08-07 21:18:31.000000000","message":"Right, but every compute node already polls Nova, so what difference does it make?\n\nAlso, because of the added filter, it sends a much smaller subset of all ports assigned.\n\nThe reason why this is important is because there isn\u0027t enough information inside Open vSwitch in order to identify the network that the port belongs to.\n\nThis is problematic because it\u0027s impossible to know which network the user is consuming, for example, in the use-case of a public cloud, we don\u0027t want to charge usage on our private networks but ensure charges on private network.\n\nDo you have alternative suggestions?  I am more than open to hear these out to see how we can improve this.","commit_id":"bfd3318f476c840741c0cf866ea53afabb590645"},{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"ddcb35b4998611e71aa1e390a15933e7371aafd3","unresolved":false,"context_lines":[{"line_number":297,"context_line":"    def discover(self, manager, param\u003dNone):"},{"line_number":298,"context_line":"        \"\"\"Discover resources to monitor.\"\"\""},{"line_number":299,"context_line":""},{"line_number":300,"context_line":"        filters \u003d {\u0027binding:host_id\u0027: self.conf.host}"},{"line_number":301,"context_line":"        ports \u003d self.neutron_cli.port_get_all(**filters)"},{"line_number":302,"context_line":"        return [p for p in ports"},{"line_number":303,"context_line":"                if p.get(\u0027status\u0027) \u003d\u003d \u0027ACTIVE\u0027 and p.get(\u0027admin_state_up\u0027)]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f79a3b5_0bfed1ad","line":300,"in_reply_to":"3f79a3b5_bb2132b7","updated":"2018-08-08 05:14:00.000000000","message":"This is not the case anymore.","commit_id":"bfd3318f476c840741c0cf866ea53afabb590645"}],"setup.cfg":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"be31a9b434531181ee6af3afb2463f418e7712fb","unresolved":false,"context_lines":[{"line_number":54,"context_line":""},{"line_number":55,"context_line":"ceilometer.discover.compute \u003d"},{"line_number":56,"context_line":"    local_instances \u003d ceilometer.compute.discovery:InstanceDiscovery"},{"line_number":57,"context_line":"    ports \u003d ceilometer.compute.discovery:PortDiscovery"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"ceilometer.discover.central \u003d"},{"line_number":60,"context_line":"    endpoint \u003d ceilometer.polling.discovery.endpoint:EndpointDiscovery"}],"source_content_type":"text/x-ttcn-cfg","patch_set":1,"id":"3f79a3b5_8e6b1683","line":57,"updated":"2018-08-16 14:04:22.000000000","message":"i\u0027m missing why we put a compute discovery things that is ports and neutron related","commit_id":"bfd3318f476c840741c0cf866ea53afabb590645"}]}