)]}'
{"id":"openstack%2Fceilometer~60483","triplet_id":"openstack%2Fceilometer~stable%2Fhavana~If966bb25e49b5837293a1bb181bbb02086599d81","project":"openstack/ceilometer","branch":"stable/havana","hashtags":[],"change_id":"If966bb25e49b5837293a1bb181bbb02086599d81","subject":"Properly reconnect subscribing clients when QPID broker restarts","status":"MERGED","created":"2013-12-06 11:33:46.000000000","updated":"2013-12-08 01:23:29.000000000","submitted":"2013-12-08 01:23:29.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"8283a7af10cf92ed09569dc581ec38853bc1d4cd","_number":60483,"virtual_id_number":60483,"owner":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":0,"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":2,"date":"2013-12-08 01:23:29.000000000","post_submit":true,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"all":[{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":2,"date":"2013-12-08 00:16:44.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"all":[{"value":0,"date":"2013-12-06 11:38:36.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"date":"2013-12-06 14:49:09.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"value":0,"date":"2013-12-06 13:49:59.000000000","_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},{"value":0,"date":"2013-12-06 13:49:14.000000000","_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"value":1,"date":"2013-12-08 00:16:44.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-12-06 13:49:14.000000000","updated_by":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"reviewer":{"_account_id":1812,"name":"p-draigbrady","email":"P@draigBrady.com","username":"p-draigbrady"},"state":"REVIEWER"},{"updated":"2013-12-06 13:49:59.000000000","updated_by":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"reviewer":{"_account_id":2472,"name":"Doug Hellmann","email":"dhellmann@redhat.com","username":"doug-hellmann"},"state":"REVIEWER"},{"updated":"2013-12-06 14:49:09.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-12-08 00:16:44.000000000","updated_by":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"reviewer":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"state":"REVIEWER"},{"updated":"2013-12-08 01:23:29.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"63e0fb7c89c8aa12b9f3e01e1acaefc2000bfc2a","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2013-12-06 11:38:36.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"7add6c257f57490c199c43ba408c8fd0bf5c58bf","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-12-06 11:38:43.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"0e022820c593a67f49c4349d49ca204ac2b5d4f3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-06 12:18:25.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/83/60483/2/check/gate-ceilometer-pep8/cd038c3 : SUCCESS in 1m 33s\n- gate-ceilometer-docs http://docs-draft.openstack.org/83/60483/2/check/gate-ceilometer-docs/9f5e93f/doc/build/html/ : SUCCESS in 3m 33s\n- gate-ceilometer-python26 http://logs.openstack.org/83/60483/2/check/gate-ceilometer-python26/f42c821 : SUCCESS in 10m 19s\n- gate-ceilometer-python27 http://logs.openstack.org/83/60483/2/check/gate-ceilometer-python27/49fbdd2 : SUCCESS in 4m 50s\n- check-tempest-dsvm-full http://logs.openstack.org/83/60483/2/check/check-tempest-dsvm-full/c6f1a30 : SUCCESS in 39m 43s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/83/60483/2/check/check-tempest-dsvm-postgres-full/fbd5a1c : SUCCESS in 31m 15s\n- check-tempest-dsvm-neutron http://logs.openstack.org/83/60483/2/check/check-tempest-dsvm-neutron/1584275 : SUCCESS in 36m 49s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/83/60483/2/check/gate-tempest-dsvm-large-ops/96b967f : SUCCESS in 13m 27s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/83/60483/2/check/gate-tempest-dsvm-neutron-large-ops/23314a9 : SUCCESS in 19m 05s\n- check-swift-dsvm-functional http://logs.openstack.org/83/60483/2/check/check-swift-dsvm-functional/9d62b0f : SUCCESS in 10m 43s\n","accounts_in_message":[],"_revision_number":2},{"id":"e9862da03e75bc3034306df0448e96d94827d065","author":{"_account_id":1955,"name":"Alan Pevec","email":"alan.pevec@redhat.com","username":"apevec"},"date":"2013-12-08 00:16:44.000000000","message":"Patch Set 2: Looks good to me (core reviewer); Approved\n\nApproving as freeze exception for 2013.2.1","accounts_in_message":[],"_revision_number":2},{"id":"5c01236f3f275f2e6b426be4bb11ff3d29aa095a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-08 00:16:45.000000000","message":"Patch Set 2: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":2},{"id":"d7b4a2c5ffb3b9051229e710a008e82408ad5539","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-08 01:23:29.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":2},{"id":"8283a7af10cf92ed09569dc581ec38853bc1d4cd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-12-08 01:23:29.000000000","message":"Patch Set 2: Verified\n\nBuild succeeded.\n\n- gate-ceilometer-docs http://docs-draft.openstack.org/83/60483/2/gate/gate-ceilometer-docs/fef0184/doc/build/html/ : SUCCESS in 3m 40s\n- gate-ceilometer-pep8 http://logs.openstack.org/83/60483/2/gate/gate-ceilometer-pep8/1877612 : SUCCESS in 1m 15s\n- gate-ceilometer-python26 http://logs.openstack.org/83/60483/2/gate/gate-ceilometer-python26/c513c8f : SUCCESS in 10m 10s\n- gate-ceilometer-python27 http://logs.openstack.org/83/60483/2/gate/gate-ceilometer-python27/c24fb6b : SUCCESS in 4m 00s\n- gate-tempest-dsvm-full http://logs.openstack.org/83/60483/2/gate/gate-tempest-dsvm-full/1b1b70e : SUCCESS in 40m 18s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/83/60483/2/gate/gate-tempest-dsvm-postgres-full/eaab46e : SUCCESS in 40m 46s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/83/60483/2/gate/gate-tempest-dsvm-neutron/a7f5078 : SUCCESS in 31m 32s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/83/60483/2/gate/gate-tempest-dsvm-large-ops/6699bd8 : SUCCESS in 11m 46s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/83/60483/2/gate/gate-tempest-dsvm-neutron-large-ops/bf0a7b0 : SUCCESS in 13m 21s\n- gate-swift-dsvm-functional http://logs.openstack.org/83/60483/2/gate/gate-swift-dsvm-functional/166806b : SUCCESS in 10m 20s\n","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"43a892138a506257992a116d2d33d3914c95e406","revisions":{"8abb093ad716079fd0c4d8644b05a3c00d7da632":{"kind":"REWORK","_number":1,"created":"2013-12-06 11:33:46.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/83/60483/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/60483/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/1"}}},"commit":{"parents":[{"commit":"99b21df1e5f049c37033f9861ba344c140c7ccf1","subject":"Merge \"Changes FakeMemcache to set token to expire on utcnow + 5 mins\" into stable/havana","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/99b21df1e5f049c37033f9861ba344c140c7ccf1"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-12-05 22:16:55.000000000","tz":0},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-12-06 11:26:32.000000000","tz":0},"subject":"Properly reconnect subscribing clients when QPID broker restarts","message":"Properly reconnect subscribing clients when QPID broker restarts\n\nFixes bug 1251757\n\nThis is a cherrypick of oslo-incubator:\ne227c0ed7e0ed1f9b8d029336f8aeb60e38c23df\n\nFrom the oslo-incubator bug:\nWhen the QPID broker is restarted (or fails over), subscribed clients\nwill attempt to re-establish their connections.  In the case of fanout\nsubscriptions, this reconnection functionality is broken. For version\n1 topologies, the clients attempt to reconnect twice to the same\nexclusive address - which is illegal.  In the case of version 2\ntopologies, the address parsing is broken and an illegal address is\ncreated on reconnect.  This fix avoids the problem by removing the\nspecial-case reconnect code that manages UUID addresses; it is\nunnecessary as the QPID broker will generate unique queue names\nautomatically when the clients reconnect.\n\nChange-Id: If966bb25e49b5837293a1bb181bbb02086599d81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/8abb093ad716079fd0c4d8644b05a3c00d7da632"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/8abb093ad716079fd0c4d8644b05a3c00d7da632"}]},"branch":"refs/heads/stable/havana"},"43a892138a506257992a116d2d33d3914c95e406":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-12-06 11:38:36.000000000","uploader":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"ref":"refs/changes/83/60483/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/83/60483/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/83/60483/2"}}},"commit":{"parents":[{"commit":"99b21df1e5f049c37033f9861ba344c140c7ccf1","subject":"Merge \"Changes FakeMemcache to set token to expire on utcnow + 5 mins\" into stable/havana","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/99b21df1e5f049c37033f9861ba344c140c7ccf1"}]}],"author":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-12-05 22:16:55.000000000","tz":0},"committer":{"name":"Eoghan Glynn","email":"eglynn@redhat.com","date":"2013-12-06 11:31:37.000000000","tz":0},"subject":"Properly reconnect subscribing clients when QPID broker restarts","message":"Properly reconnect subscribing clients when QPID broker restarts\n\nFixes bug 1251757\n\nThis is a cherrypick of oslo-incubator:\n55678c7ab7fbc1b2beb428d046bb4162f23b0a53\n\nFrom the oslo-incubator bug:\nWhen the QPID broker is restarted (or fails over), subscribed clients\nwill attempt to re-establish their connections.  In the case of fanout\nsubscriptions, this reconnection functionality is broken. For version\n1 topologies, the clients attempt to reconnect twice to the same\nexclusive address - which is illegal.  In the case of version 2\ntopologies, the address parsing is broken and an illegal address is\ncreated on reconnect.  This fix avoids the problem by removing the\nspecial-case reconnect code that manages UUID addresses; it is\nunnecessary as the QPID broker will generate unique queue names\nautomatically when the clients reconnect.\n\nChange-Id: If966bb25e49b5837293a1bb181bbb02086599d81\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/43a892138a506257992a116d2d33d3914c95e406"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/43a892138a506257992a116d2d33d3914c95e406"}]},"branch":"refs/heads/stable/havana"}},"requirements":[],"submit_records":[],"submit_requirements":[]}