)]}'
{"ceilometer/publisher/rpc.py":[{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"e755756f519a7820aaa5bafab57dac9b25d23d35","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                             samples)"},{"line_number":257,"context_line":"                    return queue"},{"line_number":258,"context_line":"                elif policy \u003d\u003d \u0027drop\u0027:"},{"line_number":259,"context_line":"                    LOG.warn(\"Failed to publish %d samples, dropping them\","},{"line_number":260,"context_line":"                             samples)"},{"line_number":261,"context_line":"                    return []"},{"line_number":262,"context_line":"                # default, occur only if rabbit_max_retries \u003e 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAATn%2F8oM4%3D","side":"PARENT","line":259,"updated":"2013-12-24 03:25:15.000000000","message":"I modified the %d to %s, it is ok since samples is a number var.\n\nIt is better to keep the two log messages to same format, either both %d or %s, and i prefer %s because it is more compatible (while not so precise)","commit_id":"dfed6ac2a38461458a3161635c1886fe68bf3154"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"37f655508ffb01cf8a0e2fc3b1b3eacf0f746d9f","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                             samples)"},{"line_number":257,"context_line":"                    return queue"},{"line_number":258,"context_line":"                elif policy \u003d\u003d \u0027drop\u0027:"},{"line_number":259,"context_line":"                    LOG.warn(\"Failed to publish %d samples, dropping them\","},{"line_number":260,"context_line":"                             samples)"},{"line_number":261,"context_line":"                    return []"},{"line_number":262,"context_line":"                # default, occur only if rabbit_max_retries \u003e 0"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAT3%2F%2F9bY%3D","side":"PARENT","line":259,"in_reply_to":"AAAATn%2F8oM4%3D","updated":"2013-12-26 09:35:05.000000000","message":"Being more compatible means that it will also happily show a string instead of a number and will not fail if the code is wrongly passing it something that\u0027s not a number. That does not sound like a good thing.","commit_id":"dfed6ac2a38461458a3161635c1886fe68bf3154"}]}