)]}'
{"ceilometer/compute/virt/libvirt/inspector.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"60a6d045b77728bff0a6ff9c73ea9e98d5bd2955","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":155,"context_line":"        for device in self._get_disk_devices(domain):"},{"line_number":156,"context_line":"            block_info \u003d domain.blockInfo(device)"},{"line_number":157,"context_line":"            disk_capacity \u003d max(block_info[0], block_info[2])"},{"line_number":158,"context_line":"            yield virt_inspector.DiskInfo(device\u003ddevice,"},{"line_number":159,"context_line":"                                          capacity\u003ddisk_capacity,"},{"line_number":160,"context_line":"                                          allocation\u003dblock_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fce034c_634ae1ac","line":157,"range":{"start_line":157,"start_character":32,"end_line":157,"end_character":45},"updated":"2019-04-18 03:40:48.000000000","message":"I wonder if block_info[0] does not indicate the device\u0027s capacity, what is it for? Moreover, if that is the case, I think the problem is at the domain.blockInfo function. Am I missing something?","commit_id":"376860b527e45dbfb768ce85d6798be81cc92461"},{"author":{"_account_id":6732,"name":"Lingxian Kong","email":"anlin.kong@gmail.com","username":"kong"},"change_message_id":"3127aef0f42017aedd538c70a6ddc0d5a76a9ff2","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":155,"context_line":"        for device in self._get_disk_devices(domain):"},{"line_number":156,"context_line":"            block_info \u003d domain.blockInfo(device)"},{"line_number":157,"context_line":"            disk_capacity \u003d max(block_info[0], block_info[2])"},{"line_number":158,"context_line":"            yield virt_inspector.DiskInfo(device\u003ddevice,"},{"line_number":159,"context_line":"                                          capacity\u003ddisk_capacity,"},{"line_number":160,"context_line":"                                          allocation\u003dblock_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_a35b512c","line":157,"range":{"start_line":157,"start_character":32,"end_line":157,"end_character":45},"in_reply_to":"3fce034c_634ae1ac","updated":"2019-04-23 09:20:41.000000000","message":"I\u0027m ok with the change, but please add a note above this line to explain the intention, a link to virDomainBlockInfo definition would be helpful. Thanks!","commit_id":"376860b527e45dbfb768ce85d6798be81cc92461"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"e08d40a240bc8b3e7d29b7a1773e75f56289f1fa","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":155,"context_line":"        for device in self._get_disk_devices(domain):"},{"line_number":156,"context_line":"            block_info \u003d domain.blockInfo(device)"},{"line_number":157,"context_line":"            disk_capacity \u003d max(block_info[0], block_info[2])"},{"line_number":158,"context_line":"            yield virt_inspector.DiskInfo(device\u003ddevice,"},{"line_number":159,"context_line":"                                          capacity\u003ddisk_capacity,"},{"line_number":160,"context_line":"                                          allocation\u003dblock_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_52aedde7","line":157,"range":{"start_line":157,"start_character":32,"end_line":157,"end_character":45},"in_reply_to":"ffb9cba7_a35b512c","updated":"2019-04-25 02:41:56.000000000","message":"+1","commit_id":"376860b527e45dbfb768ce85d6798be81cc92461"},{"author":{"_account_id":20100,"name":"Shaoman Zhang","email":"zhang.shaoman@zte.com.cn","username":"zhang.shaoman"},"change_message_id":"a2128d455ddd5bccc2869d9c0c6282cd6a77c864","unresolved":false,"context_lines":[{"line_number":154,"context_line":"        domain \u003d self._get_domain_not_shut_off_or_raise(instance)"},{"line_number":155,"context_line":"        for device in self._get_disk_devices(domain):"},{"line_number":156,"context_line":"            block_info \u003d domain.blockInfo(device)"},{"line_number":157,"context_line":"            disk_capacity \u003d max(block_info[0], block_info[2])"},{"line_number":158,"context_line":"            yield virt_inspector.DiskInfo(device\u003ddevice,"},{"line_number":159,"context_line":"                                          capacity\u003ddisk_capacity,"},{"line_number":160,"context_line":"                                          allocation\u003dblock_info[1],"}],"source_content_type":"text/x-python","patch_set":1,"id":"ffb9cba7_e1e86117","line":157,"range":{"start_line":157,"start_character":32,"end_line":157,"end_character":45},"in_reply_to":"ffb9cba7_a35b512c","updated":"2019-04-23 21:35:41.000000000","message":"Done","commit_id":"376860b527e45dbfb768ce85d6798be81cc92461"}]}