)]}'
{"ceilometer/ipmi/platform/ipmitool.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer.i18n import _"},{"line_number":19,"context_line":"from ceilometer.ipmi.platform import exception as ipmiexcept"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import ceilometer.privsep.ipmitool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Following 2 functions are copied from ironic project to handle ipmitool\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_1c6b291e","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":34},"updated":"2019-04-30 02:28:35.000000000","message":"from ceilometer.privsep import ipmitool","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"4442af057a99f7953532012bb2e1472866fc1959","unresolved":false,"context_lines":[{"line_number":18,"context_line":"from ceilometer.i18n import _"},{"line_number":19,"context_line":"from ceilometer.ipmi.platform import exception as ipmiexcept"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"import ceilometer.privsep.ipmitool"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"# Following 2 functions are copied from ironic project to handle ipmitool\u0027s"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_8a85875c","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":34},"in_reply_to":"ffb9cba7_1c6b291e","updated":"2019-04-30 05:06:49.000000000","message":"this is the same, this is also can pass the pep8\nnova also write like this too.\nhttps://github.com/openstack/nova/blob/master/nova/virt/libvirt/storage/lvm.py#L32","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":124,"context_line":"            command \u003d f(self, **kwargs)"},{"line_number":125,"context_line":"            args.extend(command.split(\" \"))"},{"line_number":126,"context_line":"            try:"},{"line_number":127,"context_line":"                (out, __) \u003d ceilometer.privsep.ipmitool.ipmi(*args)"},{"line_number":128,"context_line":"            except processutils.ProcessExecutionError:"},{"line_number":129,"context_line":"                raise ipmiexcept.IPMIException(_(\"running ipmitool failure\"))"},{"line_number":130,"context_line":"            return _parse_output(out, template)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_dc70310b","line":127,"range":{"start_line":127,"start_character":28,"end_line":127,"end_character":60},"updated":"2019-04-30 02:28:35.000000000","message":"ipmitool.ipmi","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"}],"ceilometer/privsep/__init__.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":19,"context_line":"sys_admin_pctxt \u003d priv_context.PrivContext("},{"line_number":20,"context_line":"    \u0027ceilometer\u0027,"},{"line_number":21,"context_line":"    cfg_section\u003d\u0027ceilometer_sys_admin\u0027,"},{"line_number":22,"context_line":"    pypath\u003d__name__ + \u0027.sys_admin_pctxt\u0027,"},{"line_number":23,"context_line":"    capabilities\u003d[capabilities.CAP_CHOWN,"},{"line_number":24,"context_line":"                  capabilities.CAP_DAC_OVERRIDE,"},{"line_number":25,"context_line":"                  capabilities.CAP_DAC_READ_SEARCH,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_3c438d6e","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":39},"updated":"2019-04-30 02:28:35.000000000","message":"So Will this file be generated when the module is called?","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"4442af057a99f7953532012bb2e1472866fc1959","unresolved":false,"context_lines":[{"line_number":19,"context_line":"sys_admin_pctxt \u003d priv_context.PrivContext("},{"line_number":20,"context_line":"    \u0027ceilometer\u0027,"},{"line_number":21,"context_line":"    cfg_section\u003d\u0027ceilometer_sys_admin\u0027,"},{"line_number":22,"context_line":"    pypath\u003d__name__ + \u0027.sys_admin_pctxt\u0027,"},{"line_number":23,"context_line":"    capabilities\u003d[capabilities.CAP_CHOWN,"},{"line_number":24,"context_line":"                  capabilities.CAP_DAC_OVERRIDE,"},{"line_number":25,"context_line":"                  capabilities.CAP_DAC_READ_SEARCH,"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_2a96db94","line":22,"range":{"start_line":22,"start_character":24,"end_line":22,"end_character":39},"in_reply_to":"ffb9cba7_3c438d6e","updated":"2019-04-30 05:06:49.000000000","message":"the filter config using this\n--privsep_context, ceilometer.privsep.sys_admin_pctxt\nalso privsep/ipmitool.py\n@ceilometer.privsep.sys_admin_pctxt.entrypoint","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"}],"ceilometer/privsep/ipmitool.py":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ceilometer.privsep.sys_admin_pctxt.entrypoint"},{"line_number":24,"context_line":"def ipmi(*cmd):"},{"line_number":25,"context_line":"    processutils.execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_5c3d21db","line":24,"range":{"start_line":24,"start_character":9,"end_line":24,"end_character":13},"updated":"2019-04-30 02:28:35.000000000","message":"(*cmd, **kwargs) ?","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ceilometer.privsep.sys_admin_pctxt.entrypoint"},{"line_number":24,"context_line":"def ipmi(*cmd):"},{"line_number":25,"context_line":"    processutils.execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_fc25f5c2","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":29},"updated":"2019-04-30 02:28:35.000000000","message":"(*cmd, **kwargs)?","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"4442af057a99f7953532012bb2e1472866fc1959","unresolved":false,"context_lines":[{"line_number":22,"context_line":""},{"line_number":23,"context_line":"@ceilometer.privsep.sys_admin_pctxt.entrypoint"},{"line_number":24,"context_line":"def ipmi(*cmd):"},{"line_number":25,"context_line":"    processutils.execute(*cmd)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffb9cba7_4ac9cfa9","line":25,"range":{"start_line":25,"start_character":25,"end_line":25,"end_character":29},"in_reply_to":"ffb9cba7_fc25f5c2","updated":"2019-04-30 05:06:49.000000000","message":"the original using kwargs due to pass the run_as_root to this function, but now just pass cmd with no kwargs. So I think we doesn\u0027t need kwargs here.","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"}],"etc/ceilometer/rootwrap.d/ipmi.filters":[{"author":{"_account_id":27068,"name":"Trinh Nguyen","email":"dangtrinhnt@gmail.com","username":"dangtrinhnt"},"change_message_id":"578fe8235404d61a75336ae84b6f0dd77c77caa7","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"privsep-rootwrap-sys_admin: RegExpFilter, privsep-helper, root, privsep-helper, --config-file, /etc/(?!\\.\\.).*, --privsep_context, ceilometer.privsep.sys_admin_pctxt, --privsep_sock_path, /tmp/.*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ffb9cba7_bcfa1d40","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":195},"updated":"2019-04-30 02:28:35.000000000","message":"Can we split it into multiple lines?","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"4442af057a99f7953532012bb2e1472866fc1959","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"},{"line_number":5,"context_line":"privsep-rootwrap-sys_admin: RegExpFilter, privsep-helper, root, privsep-helper, --config-file, /etc/(?!\\.\\.).*, --privsep_context, ceilometer.privsep.sys_admin_pctxt, --privsep_sock_path, /tmp/.*"}],"source_content_type":"application/octet-stream","patch_set":2,"id":"ffb9cba7_aa8acb66","line":5,"range":{"start_line":5,"start_character":0,"end_line":5,"end_character":195},"in_reply_to":"ffb9cba7_bcfa1d40","updated":"2019-04-30 05:06:49.000000000","message":"this is one line\nhttps://github.com/openstack/nova/blob/master/etc/nova/rootwrap.d/compute.filters#L140","commit_id":"bd0d5a8a27b29455e19ad062f44dd1ffb8af1abf"}]}