)]}'
{"ceilometer/openstack/common/db/sqlalchemy/session.py":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"c85df6e93e7955914b19458121d170e752792540","unresolved":false,"context_lines":[{"line_number":402,"context_line":"    engine \u003d get_engine(sqlite_fk\u003dsqlite_fk, slave_engine\u003dslave_session)"},{"line_number":403,"context_line":"    maker \u003d get_maker(engine, autocommit, expire_on_commit)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    return maker()"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":""},{"line_number":408,"context_line":"# note(boris-42): In current versions of DB backends unique constraint"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FTmY%3D","line":405,"updated":"2014-01-15 08:42:43.000000000","message":"I\u0027m struggling to understand why this change is needed. sessionmaker is already a factory object returning a new Session instance each time it\u0027s called. Why would we need to create a factory on each call?\n\nSession instances can\u0027t be shared among concurrent threads, but a sessionmaker instance can.\n\nget_session() has been returning a new session on each call without this change too, so I don\u0027t see how this fixes any concurrency errors.","commit_id":"7fb2be41598f314fb96f261be28918817613668c"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"c85df6e93e7955914b19458121d170e752792540","unresolved":false,"context_lines":[{"line_number":536,"context_line":"    if slave_engine:"},{"line_number":537,"context_line":"        db_uri \u003d CONF.database.slave_connection"},{"line_number":538,"context_line":""},{"line_number":539,"context_line":"    engine \u003d _ENGINE_CACHE.get(db_uri)"},{"line_number":540,"context_line":"    if engine is None:"},{"line_number":541,"context_line":"        engine \u003d create_engine(db_uri, sqlite_fk\u003dsqlite_fk)"},{"line_number":542,"context_line":"        _ENGINE_CACHE[db_uri] \u003d engine"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FTmM%3D","line":539,"updated":"2014-01-15 08:42:43.000000000","message":"What\u0027s is the profit of having _ENGINE_CACHE dict if db_uri is retrieved from the config?","commit_id":"7fb2be41598f314fb96f261be28918817613668c"}]}