)]}'
{"ceilometer/nova_client.py":[{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"cbc7ebeae390f287116484134efc591bca0b9325","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            instance.flavor[attr] \u003d getattr(flavor, attr, default)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _with_image(self, instance):"},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            iid \u003d instance.image[\u0027id\u0027]"},{"line_number":86,"context_line":"        except TypeError:"},{"line_number":87,"context_line":"            instance.image \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FRa0%3D","line":84,"updated":"2014-01-15 16:18:54.000000000","message":"two try catch in a row, is there anyway to re-arrange these two try catch blocks. like make it one try, two catches\n\ntry:\n   iid \u003d instance.image[\u0027id\u0027]\n   image \u003d self.nova_client.images.get(iid)\n   instance.image[\u0027name\u0027] \u003d getattr(image, \u0027name\u0027)\n   image_metadata \u003d getattr(image, \u0027metadata\u0027, None)\nexcept TypeError:\n  ...\nexcept novaclient.exceptions.NotFound:\n  ...\ndoing this can also get rid of these return statements.","commit_id":"2a269b7ceb3e82ffb5a69923c1c7e86379ba554f"},{"author":{"_account_id":2860,"name":"litong01","email":"email4tong@yahoo.com","username":"litong01"},"change_message_id":"0f8457c5b192eef01c1e47926b5351c303ced04c","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            instance.flavor[attr] \u003d getattr(flavor, attr, default)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _with_image(self, instance):"},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            iid \u003d instance.image[\u0027id\u0027]"},{"line_number":86,"context_line":"        except TypeError:"},{"line_number":87,"context_line":"            instance.image \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FRQQ%3D","line":84,"in_reply_to":"AAAAUH%2F%2FRYE%3D","updated":"2014-01-15 16:41:48.000000000","message":"I understand. thanks.","commit_id":"2a269b7ceb3e82ffb5a69923c1c7e86379ba554f"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"a863c1476325dbb71f1c5d465aa91d435ee8deeb","unresolved":false,"context_lines":[{"line_number":81,"context_line":"            instance.flavor[attr] \u003d getattr(flavor, attr, default)"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def _with_image(self, instance):"},{"line_number":84,"context_line":"        try:"},{"line_number":85,"context_line":"            iid \u003d instance.image[\u0027id\u0027]"},{"line_number":86,"context_line":"        except TypeError:"},{"line_number":87,"context_line":"            instance.image \u003d None"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FRYE%3D","line":84,"in_reply_to":"AAAAUH%2F%2FRa0%3D","updated":"2014-01-15 16:25:33.000000000","message":"yea I understand where you\u0027re getting at and i\u0027m not totally opposed to that clean up. This is a backport of a fix thats already merged into master, so a cherrypick. Would you be ok with getting this merged and i can provide a separate patch to merge the two try blocks to master and havana?","commit_id":"2a269b7ceb3e82ffb5a69923c1c7e86379ba554f"}]}