)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"d437add707ba6bf0b3832c6677f26d4442547e63","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"        else:"},{"line_number":1107,"context_line":"            valid_filter_fields \u003d valid_fields"},{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"        self.schema_field[\"patternProperties\"] \u003d {"},{"line_number":1110,"context_line":"            valid_filter_fields: self.schema_value}"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"        self.schema_field_in[\"patternProperties\"] \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2FrRc%3D","line":1109,"updated":"2014-02-25 10:17:10.000000000","message":"This is going to modify the value for all instances as it\u0027s not copied to the object, but uses the class attribute.","commit_id":"77e2371124d99154d3f1f648491040b16a22d7e0"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"94564ccd961a34ed3eba7b5368e543e0c73a0ad5","unresolved":false,"context_lines":[{"line_number":1106,"context_line":"        else:"},{"line_number":1107,"context_line":"            valid_filter_fields \u003d valid_fields"},{"line_number":1108,"context_line":""},{"line_number":1109,"context_line":"        self.schema_field[\"patternProperties\"] \u003d {"},{"line_number":1110,"context_line":"            valid_filter_fields: self.schema_value}"},{"line_number":1111,"context_line":""},{"line_number":1112,"context_line":"        self.schema_field_in[\"patternProperties\"] \u003d {"}],"source_content_type":"text/x-python","patch_set":9,"id":"AAAAU3%2F%2Fdq0%3D","line":1109,"in_reply_to":"AAAAU3%2F%2FrRc%3D","updated":"2014-02-26 13:47:40.000000000","message":"Good catch! I moved the schema into object level.\nDone.","commit_id":"77e2371124d99154d3f1f648491040b16a22d7e0"}],"ceilometer/storage/impl_sqlalchemy.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"aa8eec365f5aad1b6081c6d7b3ffedb9b3db4eff","unresolved":false,"context_lines":[{"line_number":183,"context_line":"class Connection(base.Connection):"},{"line_number":184,"context_line":"    \"\"\"SqlAlchemy connection.\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    ordering_functions \u003d {\"asc\": asc,"},{"line_number":187,"context_line":"                          \"desc\": desc}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAU3%2F%2Fc%2BM%3D","line":186,"updated":"2014-02-26 15:04:28.000000000","message":"not used.","commit_id":"a3187706ad3717f3adbbab6a1540d9ba707725e1"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"839cbe3cc16917a4c3ba7090cd7545a0f2df32d7","unresolved":false,"context_lines":[{"line_number":183,"context_line":"class Connection(base.Connection):"},{"line_number":184,"context_line":"    \"\"\"SqlAlchemy connection.\"\"\""},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    ordering_functions \u003d {\"asc\": asc,"},{"line_number":187,"context_line":"                          \"desc\": desc}"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"    def __init__(self, conf):"}],"source_content_type":"text/x-python","patch_set":11,"id":"AAAAU3%2F%2Fc3M%3D","line":186,"in_reply_to":"AAAAU3%2F%2Fc%2BM%3D","updated":"2014-02-26 15:14:14.000000000","message":"Done","commit_id":"a3187706ad3717f3adbbab6a1540d9ba707725e1"}],"ceilometer/storage/pymongo_base.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"c65ee94ec03a7ecd541e0b5d957c53980ca6a246","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            else:"},{"line_number":375,"context_line":"                field_name \u003d nodes.keys()[0]"},{"line_number":376,"context_line":"                if field_name.startswith(\"metadata.\"):"},{"line_number":377,"context_line":"                    field_name \u003d \"resource_\" + field_name"},{"line_number":378,"context_line":"                field_value \u003d nodes.values()[0]"},{"line_number":379,"context_line":"                # no operator for equal in Mongo"},{"line_number":380,"context_line":"                if operator_node \u003d\u003d \"\u003d\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVX%2F%2F1hI%3D","line":377,"updated":"2014-02-27 23:29:10.000000000","message":"I\u0027m really not loving the cruft we\u0027re accreting over time one field name to another. It\u0027s becoming extremely tortuous and brittle (not a criticism of this individual patch, just a general point).\n\nI\u0027m wondering if there\u0027s a better place for this mapping ... could for example all field name mappings be done upfront at one well-defined point in the query dispatch patch?","commit_id":"4b5985f5a44edf70816cbc326f70183c47ef32bd"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"59173aee1bee8793a01e1664ecee00b39921ef9e","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            else:"},{"line_number":375,"context_line":"                field_name \u003d nodes.keys()[0]"},{"line_number":376,"context_line":"                if field_name.startswith(\"metadata.\"):"},{"line_number":377,"context_line":"                    field_name \u003d \"resource_\" + field_name"},{"line_number":378,"context_line":"                field_value \u003d nodes.values()[0]"},{"line_number":379,"context_line":"                # no operator for equal in Mongo"},{"line_number":380,"context_line":"                if operator_node \u003d\u003d \"\u003d\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVX%2F%2FzJE%3D","line":377,"in_reply_to":"AAAAVX%2F%2F1as%3D","updated":"2014-02-28 07:36:26.000000000","message":"I agree with both of you here, but I agree with Gordon a bit more. Metadata handling is not a well controlled mechanism in OpenStack and therefore it is not well handled in Ceilometer either (https://bugs.launchpad.net/ceilometer/+bug/1262190). We had a short discussion about metadata on the IRC channel with Gordon and Doug not so long ago (http://eavesdrop.openstack.org/irclogs/%23openstack-ceilometer/%23openstack-ceilometer.2014-02-25.log). The problem is not solved, however, I think, there are options, but those are out of the scope of this patch set, as it was mentioned by Gordon. In my opinion it would not worth the effort here to introduce one additional workaround for this issue, as we already have a few in the project, we will not get real benefit, neither the solution of the base problem.","commit_id":"4b5985f5a44edf70816cbc326f70183c47ef32bd"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"38f22232a8ee12fba9fa6604fea3ee10ec082a78","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            else:"},{"line_number":375,"context_line":"                field_name \u003d nodes.keys()[0]"},{"line_number":376,"context_line":"                if field_name.startswith(\"metadata.\"):"},{"line_number":377,"context_line":"                    field_name \u003d \"resource_\" + field_name"},{"line_number":378,"context_line":"                field_value \u003d nodes.values()[0]"},{"line_number":379,"context_line":"                # no operator for equal in Mongo"},{"line_number":380,"context_line":"                if operator_node \u003d\u003d \"\u003d\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVX%2F%2F1as%3D","line":377,"in_reply_to":"AAAAVX%2F%2F1hI%3D","updated":"2014-02-27 23:48:55.000000000","message":"agreed, but i think it\u0027s outside the scope of this patchset as it\u0027s not just here, it\u0027s in all the backends, api (sample_filter), and tests.\n\nit\u0027ll be a large change with or without adding these additional cases i think","commit_id":"4b5985f5a44edf70816cbc326f70183c47ef32bd"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"0ff8b976468c55374ed1c62a35e3dcc1cf80d87a","unresolved":false,"context_lines":[{"line_number":374,"context_line":"            else:"},{"line_number":375,"context_line":"                field_name \u003d nodes.keys()[0]"},{"line_number":376,"context_line":"                if field_name.startswith(\"metadata.\"):"},{"line_number":377,"context_line":"                    field_name \u003d \"resource_\" + field_name"},{"line_number":378,"context_line":"                field_value \u003d nodes.values()[0]"},{"line_number":379,"context_line":"                # no operator for equal in Mongo"},{"line_number":380,"context_line":"                if operator_node \u003d\u003d \"\u003d\":"}],"source_content_type":"text/x-python","patch_set":13,"id":"AAAAVX%2F%2FyXw%3D","line":377,"in_reply_to":"AAAAVX%2F%2FzJE%3D","updated":"2014-02-28 09:36:10.000000000","message":"I moved this particular name mapping up to the API layer. This way I could remove a code duplication in the \"not\" operator patch. \nOf course this change does not solve root cause of the problem so we still map the names but maybe we map it now in a better place.","commit_id":"4b5985f5a44edf70816cbc326f70183c47ef32bd"}]}