)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"10ebc270eef084cde5da3f801f53b845272c71e8","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"    def set_traits(self, traits):"},{"line_number":1677,"context_line":"        self._traits \u003d map((lambda x: x"},{"line_number":1678,"context_line":"                            if isinstance(x, Trait)"},{"line_number":1679,"context_line":"                            else self._convert_storage_trait(x)),"},{"line_number":1680,"context_line":"                           traits)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    traits \u003d wsme.wsproperty(wtypes.ArrayType(Trait),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FLx0%3D","line":1679,"updated":"2014-01-16 16:55:10.000000000","message":"Would it be clearer to just do the isinstance(x, Trait) check within _convert_storage_trait and leave t unchanged if so?","commit_id":"6d713b1b61afc9e97a5ee1f58353402dc4fc8004"},{"author":{"_account_id":5678,"name":"John Herndon","email":"john.herndon@hp.com","username":"john-herndon"},"change_message_id":"beb1dfaeb37f9c51dc02734a41b6cccec18cc4a3","unresolved":false,"context_lines":[{"line_number":1676,"context_line":"    def set_traits(self, traits):"},{"line_number":1677,"context_line":"        self._traits \u003d map((lambda x: x"},{"line_number":1678,"context_line":"                            if isinstance(x, Trait)"},{"line_number":1679,"context_line":"                            else self._convert_storage_trait(x)),"},{"line_number":1680,"context_line":"                           traits)"},{"line_number":1681,"context_line":""},{"line_number":1682,"context_line":"    traits \u003d wsme.wsproperty(wtypes.ArrayType(Trait),"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2FLr8%3D","line":1679,"in_reply_to":"AAAAUH%2F%2FLx0%3D","updated":"2014-01-16 17:09:06.000000000","message":"Done","commit_id":"6d713b1b61afc9e97a5ee1f58353402dc4fc8004"},{"author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"change_message_id":"a9736974cd8cd8e38ab1b87a398b63d1a75cbf1a","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        return Trait(name\u003dt.name, type\u003dtype, value\u003dvalue)"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    def set_traits(self, traits):"},{"line_number":1682,"context_line":"        self._traits \u003d map((lambda x: self._convert_storage_trait(x)), traits)"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    traits \u003d wsme.wsproperty(wtypes.ArrayType(Trait),"},{"line_number":1685,"context_line":"                             get_traits,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FGg8%3D","line":1682,"updated":"2014-01-17 12:34:02.000000000","message":"Is the lambda wrapping  _convert_storage_trait even required?\n\ni.e. would it be cleaner as:\n\n  self._traits \u003d map(self._convert_storage_trait, traits)","commit_id":"effc96c041fc896d62b97390e6e36538ad047dfe"},{"author":{"_account_id":5678,"name":"John Herndon","email":"john.herndon@hp.com","username":"john-herndon"},"change_message_id":"bb64ab783f5e299a72776268c4639e6cbc3971db","unresolved":false,"context_lines":[{"line_number":1679,"context_line":"        return Trait(name\u003dt.name, type\u003dtype, value\u003dvalue)"},{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"    def set_traits(self, traits):"},{"line_number":1682,"context_line":"        self._traits \u003d map((lambda x: self._convert_storage_trait(x)), traits)"},{"line_number":1683,"context_line":""},{"line_number":1684,"context_line":"    traits \u003d wsme.wsproperty(wtypes.ArrayType(Trait),"},{"line_number":1685,"context_line":"                             get_traits,"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAUH%2F%2FGKU%3D","line":1682,"in_reply_to":"AAAAUH%2F%2FGg8%3D","updated":"2014-01-17 13:55:11.000000000","message":"Oh, good point, duh.  Fixing now...","commit_id":"effc96c041fc896d62b97390e6e36538ad047dfe"}]}