)]}'
{"id":"openstack%2Fceilometer~67608","triplet_id":"openstack%2Fceilometer~master~I7072fef7fe5f76e526fc0ccca7a4894accaae80f","project":"openstack/ceilometer","branch":"master","topic":"bug/1268480","hashtags":[],"change_id":"I7072fef7fe5f76e526fc0ccca7a4894accaae80f","subject":"assertTrue(isinstance) replace by assertIsInstance","status":"MERGED","created":"2014-01-18 01:19:19.000000000","updated":"2014-01-23 03:10:18.000000000","submitted":"2014-01-23 03:10:17.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"c0e4fd90363fc3d26d2eda7bc59c42775de3b59c","_number":67608,"virtual_id_number":67608,"owner":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":2,"date":"2014-01-23 03:10:17.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":0,"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"recommended":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2014-01-18 14:28:33.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":1,"date":"2014-01-18 15:48:16.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":1,"date":"2014-01-18 14:19:18.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":2,"date":"2014-01-18 14:23:09.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":2,"date":"2014-01-21 08:15:56.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"all":[{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"value":0,"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"value":0,"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"value":0,"date":"2014-01-18 14:23:09.000000000","_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"value":1,"date":"2014-01-21 08:15:56.000000000","_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"value":0,"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2014-01-18 14:19:18.000000000","updated_by":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"reviewer":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"state":"REVIEWER"},{"updated":"2014-01-18 14:23:09.000000000","updated_by":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"reviewer":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"state":"REVIEWER"},{"updated":"2014-01-18 14:28:33.000000000","updated_by":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"reviewer":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"state":"REVIEWER"},{"updated":"2014-01-18 15:48:16.000000000","updated_by":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"reviewer":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"state":"REVIEWER"},{"updated":"2014-01-21 08:15:56.000000000","updated_by":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"reviewer":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"state":"REVIEWER"},{"updated":"2014-01-23 03:10:17.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"73fb450abbd98f26a86a5b5ed51c5096d5ea6868","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-18 03:26:52.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/08/67608/1/check/gate-ceilometer-pep8/aefe867 : SUCCESS in 2m 30s\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/67608/1/check/gate-ceilometer-docs/b99730b/doc/build/html/ : SUCCESS in 6m 34s\n- gate-ceilometer-python26 http://logs.openstack.org/08/67608/1/check/gate-ceilometer-python26/bc97909 : SUCCESS in 9m 25s\n- gate-ceilometer-python27 http://logs.openstack.org/08/67608/1/check/gate-ceilometer-python27/a76d3f8 : SUCCESS in 7m 14s\n- check-tempest-dsvm-full http://logs.openstack.org/08/67608/1/check/check-tempest-dsvm-full/9c5038a : SUCCESS in 58m 53s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/67608/1/check/check-tempest-dsvm-postgres-full/ad7979c : SUCCESS in 51m 50s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/67608/1/check/check-tempest-dsvm-neutron/3de8497 : SUCCESS in 37m 18s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/67608/1/check/gate-tempest-dsvm-large-ops/14c0889 : SUCCESS in 12m 03s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/67608/1/check/gate-tempest-dsvm-neutron-large-ops/75eeb36 : SUCCESS in 13m 54s\n- check-swift-dsvm-functional http://logs.openstack.org/08/67608/1/check/check-swift-dsvm-functional/a6bea73 : SUCCESS in 16m 22s\n","accounts_in_message":[],"_revision_number":1},{"id":"dd8f2a3856d7fb1cbfdbed7ac6d45b0224c1f210","author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"date":"2014-01-18 07:43:19.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nHi,\n\nI saw 5 more occurrences of assertTrue(isinstance()) in the tests folder besides this two, you\u0027ve replaced. Could you please check?\n\nBest Regards,\nIldiko","accounts_in_message":[],"_revision_number":1},{"id":"3e197595527bff8e57df99e8167026e85b062dc3","author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"date":"2014-01-18 07:59:34.000000000","message":"Patch Set 1:\n\nthanks.\r\nbut I git from master,Ok,I will check it later.","accounts_in_message":[],"_revision_number":1},{"id":"86c9f542a04aa3c1c0eccb9ab7f2037a3cf3d119","author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"date":"2014-01-18 11:51:35.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"e8cf5d8d2d1a85d4fd9032adb248b3f58ba3431f","author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"date":"2014-01-18 12:01:04.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nHi,\n\nI\u0027m sorry to say, but there is still one more:\nhttps://github.com/openstack/ceilometer/blob/master/ceilometer/tests/alarm/test_rpc.py#L103\n\nBest Regards,\nIldiko","accounts_in_message":[],"_revision_number":2},{"id":"0425af5e1cdd66296494a58d4183402f7f659294","author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"date":"2014-01-18 12:15:33.000000000","message":"Patch Set 2:\n\nsorry, it my mistake. thank you very much!","accounts_in_message":[],"_revision_number":2},{"id":"d0329ee5a7c06894df5a131dd24de19797a2a099","author":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"date":"2014-01-18 12:19:50.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"23545ef42a61ea49098a4decb0286e477e6ec5a3","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-18 14:16:21.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- gate-ceilometer-pep8 http://logs.openstack.org/08/67608/3/check/gate-ceilometer-pep8/8582988 : SUCCESS in 2m 35s\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/67608/3/check/gate-ceilometer-docs/654fe3e/doc/build/html/ : SUCCESS in 6m 15s\n- gate-ceilometer-python26 http://logs.openstack.org/08/67608/3/check/gate-ceilometer-python26/826d402 : SUCCESS in 9m 57s\n- gate-ceilometer-python27 http://logs.openstack.org/08/67608/3/check/gate-ceilometer-python27/3679cb0 : SUCCESS in 7m 31s\n- check-tempest-dsvm-full http://logs.openstack.org/08/67608/3/check/check-tempest-dsvm-full/0b7c219 : SUCCESS in 1h 00m 12s\n- check-tempest-dsvm-postgres-full http://logs.openstack.org/08/67608/3/check/check-tempest-dsvm-postgres-full/ac016e6 : SUCCESS in 57m 54s\n- check-tempest-dsvm-neutron http://logs.openstack.org/08/67608/3/check/check-tempest-dsvm-neutron/b349319 : SUCCESS in 39m 42s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/67608/3/check/gate-tempest-dsvm-large-ops/97a1590 : SUCCESS in 11m 23s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/67608/3/check/gate-tempest-dsvm-neutron-large-ops/df20d5b : SUCCESS in 12m 16s\n- check-swift-dsvm-functional http://logs.openstack.org/08/67608/3/check/check-swift-dsvm-functional/e913ca1 : SUCCESS in 12m 39s\n","accounts_in_message":[],"_revision_number":3},{"id":"4597365eb1bfd855032bd6f7504d0cf4d5a093e6","author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"date":"2014-01-18 14:19:18.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\nHi,\n\nNo problem! :)\n\nBest Regards,\nIldiko","accounts_in_message":[],"_revision_number":3},{"id":"0287ff07ed1b0740519080718c25c0112319536a","author":{"_account_id":2284,"name":"Eoghan Glynn","email":"eglynn@redhat.com","username":"eglynn"},"date":"2014-01-18 14:23:09.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7b74d6ce0778844514a7f0bbf23197be6fc0e482","author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"date":"2014-01-18 14:28:33.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"57c18a8a5c7b7122d1921f8cd88b04f192aee4ad","author":{"_account_id":8276,"name":"kiwik","email":"chenrui.momo@gmail.com","username":"kiwik"},"date":"2014-01-18 15:48:16.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"d2250a24f69ff3f6e62cbf795694bb90594301ed","author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"date":"2014-01-21 08:15:56.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"1994da6654c065ed8e91ee7970e285f31ad6b320","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-21 09:43:25.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"8057bc656cb99ad63266c5e4c95a50b192df1771","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-22 20:57:23.000000000","message":"Patch Set 3:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"4f9b1a53db08f63b7c042b8ac6b2d8eb4b541c92","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 03:10:17.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- gate-ceilometer-docs http://docs-draft.openstack.org/08/67608/3/gate/gate-ceilometer-docs/be503fa/doc/build/html/ : SUCCESS in 6m 44s\n- gate-ceilometer-pep8 http://logs.openstack.org/08/67608/3/gate/gate-ceilometer-pep8/d750d4e : SUCCESS in 2m 38s\n- gate-ceilometer-python26 http://logs.openstack.org/08/67608/3/gate/gate-ceilometer-python26/9e26fb8 : SUCCESS in 10m 45s\n- gate-ceilometer-python27 http://logs.openstack.org/08/67608/3/gate/gate-ceilometer-python27/202e890 : SUCCESS in 7m 30s\n- gate-tempest-dsvm-full http://logs.openstack.org/08/67608/3/gate/gate-tempest-dsvm-full/7009bea : SUCCESS in 57m 28s\n- gate-tempest-dsvm-postgres-full http://logs.openstack.org/08/67608/3/gate/gate-tempest-dsvm-postgres-full/b9b964f : SUCCESS in 1h 01m 55s\n- gate-tempest-dsvm-neutron http://logs.openstack.org/08/67608/3/gate/gate-tempest-dsvm-neutron/64410dd : SUCCESS in 35m 19s\n- gate-tempest-dsvm-large-ops http://logs.openstack.org/08/67608/3/gate/gate-tempest-dsvm-large-ops/e9a5041 : SUCCESS in 12m 45s\n- gate-tempest-dsvm-neutron-large-ops http://logs.openstack.org/08/67608/3/gate/gate-tempest-dsvm-neutron-large-ops/761d374 : SUCCESS in 15m 00s\n- gate-swift-dsvm-functional http://logs.openstack.org/08/67608/3/gate/gate-swift-dsvm-functional/2d79e71 : SUCCESS in 14m 08s\n","accounts_in_message":[],"_revision_number":3},{"id":"ff659d980eb88a23aea9215adc5782a0d345cf6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2014-01-23 03:10:18.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"f9381c656eafdc054e6af4b84a50097aa6dabb45","revisions":{"131a8054428a08064f2fba6fd6769089648077c4":{"kind":"REWORK","_number":1,"created":"2014-01-18 01:19:19.000000000","uploader":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"ref":"refs/changes/08/67608/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/67608/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/1"}}},"commit":{"parents":[{"commit":"87c1a8a99e8839248bccce0fbbc752c11a9f1bc4","subject":"Merge \"Remove unused imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/87c1a8a99e8839248bccce0fbbc752c11a9f1bc4"}]}],"author":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 01:16:38.000000000","tz":480},"committer":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 01:16:38.000000000","tz":480},"subject":"assertTrue(isinstance) replace by assertIsInstance","message":"assertTrue(isinstance) replace by assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: I7072fef7fe5f76e526fc0ccca7a4894accaae80f\nCloses-Bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/131a8054428a08064f2fba6fd6769089648077c4"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/131a8054428a08064f2fba6fd6769089648077c4"}]},"branch":"refs/heads/master"},"ffbf695a5131a944e5baee714e3fb74e57857e6b":{"kind":"REWORK","_number":2,"created":"2014-01-18 11:51:35.000000000","uploader":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"ref":"refs/changes/08/67608/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/67608/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/2"}}},"commit":{"parents":[{"commit":"87c1a8a99e8839248bccce0fbbc752c11a9f1bc4","subject":"Merge \"Remove unused imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/87c1a8a99e8839248bccce0fbbc752c11a9f1bc4"}]}],"author":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 01:16:38.000000000","tz":480},"committer":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 11:50:42.000000000","tz":480},"subject":"assertTrue(isinstance) replace by assertIsInstance","message":"assertTrue(isinstance) replace by assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: I7072fef7fe5f76e526fc0ccca7a4894accaae80f\nCloses-Bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/ffbf695a5131a944e5baee714e3fb74e57857e6b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/ffbf695a5131a944e5baee714e3fb74e57857e6b"}]},"branch":"refs/heads/master"},"f9381c656eafdc054e6af4b84a50097aa6dabb45":{"kind":"REWORK","_number":3,"created":"2014-01-18 12:19:50.000000000","uploader":{"_account_id":9645,"name":"lizheming","email":"lizheming.li@huawei.com","username":"lizheming"},"ref":"refs/changes/08/67608/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/ceilometer","ref":"refs/changes/08/67608/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/ceilometer refs/changes/08/67608/3"}}},"commit":{"parents":[{"commit":"87c1a8a99e8839248bccce0fbbc752c11a9f1bc4","subject":"Merge \"Remove unused imports\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/87c1a8a99e8839248bccce0fbbc752c11a9f1bc4"}]}],"author":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 01:16:38.000000000","tz":480},"committer":{"name":"lizheming","email":"lizheming.li@huawei.com","date":"2014-01-18 12:18:21.000000000","tz":480},"subject":"assertTrue(isinstance) replace by assertIsInstance","message":"assertTrue(isinstance) replace by assertIsInstance\n\nsome of tests use different method of assertTrue(isinstance(A, B))\nor assertEqual(type(A), B). The correct way is to use\nassertIsInstance(A, B) provided by testtools\n\nChange-Id: I7072fef7fe5f76e526fc0ccca7a4894accaae80f\nCloses-Bug: #1268480\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/f9381c656eafdc054e6af4b84a50097aa6dabb45"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/ceilometer/commit/f9381c656eafdc054e6af4b84a50097aa6dabb45"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}