)]}'
{"ceilometer/storage/impl_hbase.py":[{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6af1972976223bb5d3c4e128d53f417b5a6a140b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                if metadata:"},{"line_number":456,"context_line":"                    for key, v in utils.dict_to_keyval(metadata):"},{"line_number":457,"context_line":"                        keys[\"metadata.\" + key] \u003d v"},{"line_number":458,"context_line":"                    if set(metaquery.items()).issubset(set(keys.items())):"},{"line_number":459,"context_line":"                        if limit:"},{"line_number":460,"context_line":"                            limit -\u003d 1"},{"line_number":461,"context_line":"                        yield make_sample(meter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FrQw%3D","line":458,"updated":"2014-02-11 15:29:13.000000000","message":"is this a safe comparison? i believe a set doesn\u0027t recognise order so a metaquery key of a.b.c could technically match a metadata key of a.c.b no?","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"f7ab9247c7e54efca52d56af6182864970e073b0","unresolved":false,"context_lines":[{"line_number":455,"context_line":"                if metadata:"},{"line_number":456,"context_line":"                    for key, v in utils.dict_to_keyval(metadata):"},{"line_number":457,"context_line":"                        keys[\"metadata.\" + key] \u003d v"},{"line_number":458,"context_line":"                    if set(metaquery.items()).issubset(set(keys.items())):"},{"line_number":459,"context_line":"                        if limit:"},{"line_number":460,"context_line":"                            limit -\u003d 1"},{"line_number":461,"context_line":"                        yield make_sample(meter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FCUk%3D","line":458,"in_reply_to":"AAAAUX%2F%2FrQw%3D","updated":"2014-02-17 14:16:20.000000000","message":"Gordon, I\u0027ve completly removed this part in new patch set","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"},{"author":{"_account_id":6537,"name":"gordon chung","email":"gord@live.ca","username":"chungg"},"change_message_id":"6af1972976223bb5d3c4e128d53f417b5a6a140b","unresolved":false,"context_lines":[{"line_number":459,"context_line":"                        if limit:"},{"line_number":460,"context_line":"                            limit -\u003d 1"},{"line_number":461,"context_line":"                        yield make_sample(meter)"},{"line_number":462,"context_line":"                else:"},{"line_number":463,"context_line":"                    if limit:"},{"line_number":464,"context_line":"                        limit -\u003d 1"},{"line_number":465,"context_line":"                    yield make_sample(meter)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUX%2F%2FrS0%3D","line":462,"updated":"2014-02-11 15:29:13.000000000","message":"i don\u0027t think this else condition should be here anymore. i would expect no result if metaquery and not metadata.","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"}],"ceilometer/tests/api/v2/test_list_meters_scenarios.py":[{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d2df149d08580497df9cfccdceb82dfc0b6c0fc5","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def test_list_samples_with_complex_metadata(self):"},{"line_number":249,"context_line":"        data \u003d self.get_json(\u0027/samples\u0027,"},{"line_number":250,"context_line":"                             q\u003d[{\u0027field\u0027:"},{"line_number":251,"context_line":"                                 \u0027metadata.properties.prop_30[0].a\u0027,"},{"line_number":252,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027,"},{"line_number":253,"context_line":"                                 \u0027value\u0027: \u0027aa\u0027,"},{"line_number":254,"context_line":"                                 }])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BpHI%3D","line":251,"updated":"2014-01-23 16:18:15.000000000","message":"If we finally include the functionality to all the DB backends, it would be good to add some examples to the API doc.","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"},{"author":{"_account_id":9562,"name":"Ildiko Vancsa","email":"ildiko.vancsa@gmail.com","username":"ildikov"},"change_message_id":"d07f557a463036139a85f8bb0349c918475a3e1e","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def test_list_samples_with_complex_metadata(self):"},{"line_number":249,"context_line":"        data \u003d self.get_json(\u0027/samples\u0027,"},{"line_number":250,"context_line":"                             q\u003d[{\u0027field\u0027:"},{"line_number":251,"context_line":"                                 \u0027metadata.properties.prop_30[0].a\u0027,"},{"line_number":252,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027,"},{"line_number":253,"context_line":"                                 \u0027value\u0027: \u0027aa\u0027,"},{"line_number":254,"context_line":"                                 }])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BoAk%3D","line":251,"in_reply_to":"AAAAUH%2F%2BoZM%3D","updated":"2014-01-23 19:23:43.000000000","message":"Great. :) As Jenkins liked it, I assumed that it will be good, at least as a first step, to solve this issue. :)","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"},{"author":{"_account_id":7478,"name":"Nadya Shakhat","email":"nadmi4@gmail.com","username":"nprivalova"},"change_message_id":"c61bd4f6c5ea0b25002022de00896eb1008a5df0","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    def test_list_samples_with_complex_metadata(self):"},{"line_number":249,"context_line":"        data \u003d self.get_json(\u0027/samples\u0027,"},{"line_number":250,"context_line":"                             q\u003d[{\u0027field\u0027:"},{"line_number":251,"context_line":"                                 \u0027metadata.properties.prop_30[0].a\u0027,"},{"line_number":252,"context_line":"                                 \u0027op\u0027: \u0027eq\u0027,"},{"line_number":253,"context_line":"                                 \u0027value\u0027: \u0027aa\u0027,"},{"line_number":254,"context_line":"                                 }])"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BoZM%3D","line":251,"in_reply_to":"AAAAUH%2F%2BpHI%3D","updated":"2014-01-23 18:20:05.000000000","message":"yes, Ildiko, thank you! I\u0027m planning to add the docs just wanted to show this to community to sure that fix is ok :)","commit_id":"84f8e5e2917779714f996a5685a4346a0b0bb009"}]}