)]}'
{"ceilometer/polling/discovery/non_openstack_credentials_discovery.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"277dab7c506d492fea60b334c527e604cd2ff0d5","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        barbican_endpoints \u003d super(NonOpenStackCredentialsDiscovery,"},{"line_number":39,"context_line":"                                   self).discover(\"key-manager\")"},{"line_number":40,"context_line":"        if not barbican_endpoints:"},{"line_number":41,"context_line":"            LOG.warning(\"No Barbican endpoints found to execute the\""},{"line_number":42,"context_line":"                        \" credentials discovery process to [%s].\","},{"line_number":43,"context_line":"                        param)"},{"line_number":44,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_393c93e0","line":41,"updated":"2019-11-06 00:34:45.000000000","message":"If there is no barbican_endpoints, you just log a warn and then continue with the flow, then how do you will handle an empty list in line 47?\n\nCould you use thrown an exception after logging the warn or set a default barbican_server if there is no barbican_endpoints.","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"3d29f7d581e8ab287a8b607c4e627f42466273c7","unresolved":false,"context_lines":[{"line_number":38,"context_line":"        barbican_endpoints \u003d super(NonOpenStackCredentialsDiscovery,"},{"line_number":39,"context_line":"                                   self).discover(\"key-manager\")"},{"line_number":40,"context_line":"        if not barbican_endpoints:"},{"line_number":41,"context_line":"            LOG.warning(\"No Barbican endpoints found to execute the\""},{"line_number":42,"context_line":"                        \" credentials discovery process to [%s].\","},{"line_number":43,"context_line":"                        param)"},{"line_number":44,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_9529c38a","line":41,"in_reply_to":"3fa7e38b_393c93e0","updated":"2019-11-06 12:42:59.000000000","message":"Ah, I see. I should return `None`.","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"}],"ceilometer/polling/dynamic_pollster.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"277dab7c506d492fea60b334c527e604cd2ff0d5","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            LOG.debug(\"No resources received for processing.\")"},{"line_number":119,"context_line":"            yield None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        for r in resources:"},{"line_number":122,"context_line":"            LOG.debug(\"Executing get sample for resource [%s].\", r)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            samples \u003d list([])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_3915734a","line":121,"updated":"2019-11-06 00:34:45.000000000","message":"Maybe change the \u0027r\u0027 variable name to \u0027resource\u0027.","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"3d29f7d581e8ab287a8b607c4e627f42466273c7","unresolved":false,"context_lines":[{"line_number":118,"context_line":"            LOG.debug(\"No resources received for processing.\")"},{"line_number":119,"context_line":"            yield None"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"        for r in resources:"},{"line_number":122,"context_line":"            LOG.debug(\"Executing get sample for resource [%s].\", r)"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"            samples \u003d list([])"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_153ab3c3","line":121,"in_reply_to":"3fa7e38b_3915734a","updated":"2019-11-06 12:42:59.000000000","message":"Done","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"}],"ceilometer/polling/manager.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"277dab7c506d492fea60b334c527e604cd2ff0d5","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        key \u003d Resources.key(source.name, pollster)"},{"line_number":145,"context_line":"        self.resources[key].setup(source)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def poll_and_notify(self):"},{"line_number":149,"context_line":"        \"\"\"Polling sample and notify.\"\"\""},{"line_number":150,"context_line":"        cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2b53da18","line":147,"updated":"2019-11-06 00:34:45.000000000","message":"This new line. Could you remove it?\n\nI think it will raise an error in pep8","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"3d29f7d581e8ab287a8b607c4e627f42466273c7","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        key \u003d Resources.key(source.name, pollster)"},{"line_number":145,"context_line":"        self.resources[key].setup(source)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":""},{"line_number":148,"context_line":"    def poll_and_notify(self):"},{"line_number":149,"context_line":"        \"\"\"Polling sample and notify.\"\"\""},{"line_number":150,"context_line":"        cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f56597e3","line":147,"in_reply_to":"3fa7e38b_2b53da18","updated":"2019-11-06 12:42:59.000000000","message":"done","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"}],"ceilometer/tests/unit/polling/test_non_openstack_dynamic_pollster.py":[{"author":{"_account_id":30695,"name":"Pedro Henrique Pereira Martins","email":"phpm13@gmail.com","username":"pedrohpmartins"},"change_message_id":"277dab7c506d492fea60b334c527e604cd2ff0d5","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027resource_id_attribute\u0027: \u0027id\u0027, \u0027barbican_secret_id\u0027: \u0027barbican_id\u0027,"},{"line_number":57,"context_line":"            \u0027authentication_parameters\u0027: \u0027parameters\u0027}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_all_fields_declrated(self):"},{"line_number":60,"context_line":"        pollster \u003d NonOpenStackApisDynamicPollster("},{"line_number":61,"context_line":"            self.pollster_definition_only_required_fields)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_2ba19af8","line":59,"updated":"2019-11-06 00:34:45.000000000","message":"typo in method name \u0027declarated\u0027","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"3d29f7d581e8ab287a8b607c4e627f42466273c7","unresolved":false,"context_lines":[{"line_number":56,"context_line":"            \u0027resource_id_attribute\u0027: \u0027id\u0027, \u0027barbican_secret_id\u0027: \u0027barbican_id\u0027,"},{"line_number":57,"context_line":"            \u0027authentication_parameters\u0027: \u0027parameters\u0027}"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    def test_all_fields_declrated(self):"},{"line_number":60,"context_line":"        pollster \u003d NonOpenStackApisDynamicPollster("},{"line_number":61,"context_line":"            self.pollster_definition_only_required_fields)"},{"line_number":62,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3fa7e38b_f5aa77d1","line":59,"in_reply_to":"3fa7e38b_2ba19af8","updated":"2019-11-06 12:42:59.000000000","message":"done","commit_id":"5ac14a0f0cafde56018e2639999a2ca88ac9c7cb"},{"author":{"_account_id":14107,"name":"zhurong","email":"aaronzhu1121@gmail.com","username":"zhurong"},"change_message_id":"ef8cef08c4b891ced486d4a364d45c2ccdfc9dc0","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027resource_id_attribute\u0027: \u0027id\u0027, \u0027barbican_secret_id\u0027: \u0027barbican_id\u0027,"},{"line_number":59,"context_line":"            \u0027authentication_parameters\u0027: \u0027parameters\u0027}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_all_fields_declrated(self):"},{"line_number":62,"context_line":"        pollster \u003d NonOpenStackApisDynamicPollster("},{"line_number":63,"context_line":"            self.pollster_definition_only_required_fields)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_008a3e63","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":33},"updated":"2019-11-12 09:14:37.000000000","message":"missing the typo note, declarated","commit_id":"d06f424af0e7e954ac976f9a898b008a128672c7"},{"author":{"_account_id":28356,"name":"Rafael Weingartner","email":"rafael@apache.org","username":"rafaelweingartner"},"change_message_id":"792fe92714d3ef37ec691a2f26b8ad0157920cf8","unresolved":false,"context_lines":[{"line_number":58,"context_line":"            \u0027resource_id_attribute\u0027: \u0027id\u0027, \u0027barbican_secret_id\u0027: \u0027barbican_id\u0027,"},{"line_number":59,"context_line":"            \u0027authentication_parameters\u0027: \u0027parameters\u0027}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def test_all_fields_declrated(self):"},{"line_number":62,"context_line":"        pollster \u003d NonOpenStackApisDynamicPollster("},{"line_number":63,"context_line":"            self.pollster_definition_only_required_fields)"},{"line_number":64,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_41c4b841","line":61,"range":{"start_line":61,"start_character":24,"end_line":61,"end_character":33},"in_reply_to":"3fa7e38b_008a3e63","updated":"2019-11-12 13:32:32.000000000","message":"Good catch!\nSorry for the miss.\nFixed.","commit_id":"d06f424af0e7e954ac976f9a898b008a128672c7"}]}