)]}'
{"ceilometer/api/controllers/v2.py":[{"author":{"_account_id":2813,"name":"Mehdi Abaakouk","email":"sileht@sileht.net","username":"sileht"},"change_message_id":"faf5f04e54e26f9c8c3a4253e26f8a24ace4007d","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    def __init__(self, **kwargs):"},{"line_number":857,"context_line":"        meter_id \u003d base64.encodestring(\u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027],"},{"line_number":858,"context_line":"                                                  kwargs[\u0027name\u0027]))"},{"line_number":859,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id.replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":860,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BXlQ%3D","line":859,"updated":"2014-01-27 16:46:39.000000000","message":"You should removed the last \u0027\\n\u0027 not all \u0027\\n\u0027 in the string. .rstrip() looks more appropriate.","commit_id":"999bd00f09f58e78b51b3cc74d43f885c1de7428"},{"author":{"_account_id":10987,"name":"Igor Degtiarov","username":"tovstun","inactive":true},"change_message_id":"0a88b27428797a97d89df0588323e0a717398523","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    def __init__(self, **kwargs):"},{"line_number":857,"context_line":"        meter_id \u003d base64.encodestring(\u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027],"},{"line_number":858,"context_line":"                                                  kwargs[\u0027name\u0027]))"},{"line_number":859,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id.replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":860,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a4dcd0f_f791459b","line":859,"in_reply_to":"AAAAUH%2F%2BU54%3D","updated":"2015-08-11 13:42:50.000000000","message":"It seems fair enough to me. Thanks for explanation.","commit_id":"999bd00f09f58e78b51b3cc74d43f885c1de7428"},{"author":{"_account_id":6676,"name":"zqfan","email":"aji.zqfan@gmail.com","username":"aji-zqfan"},"change_message_id":"62403fcfc21698a2664de2441315b9709676c174","unresolved":false,"context_lines":[{"line_number":856,"context_line":"    def __init__(self, **kwargs):"},{"line_number":857,"context_line":"        meter_id \u003d base64.encodestring(\u0027%s+%s\u0027 % (kwargs[\u0027resource_id\u0027],"},{"line_number":858,"context_line":"                                                  kwargs[\u0027name\u0027]))"},{"line_number":859,"context_line":"        kwargs[\u0027meter_id\u0027] \u003d meter_id.replace(\u0027\\n\u0027, \u0027\u0027)"},{"line_number":860,"context_line":"        super(Meter, self).__init__(**kwargs)"},{"line_number":861,"context_line":""},{"line_number":862,"context_line":"    @classmethod"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAUH%2F%2BU54%3D","line":859,"in_reply_to":"AAAAUH%2F%2BXlQ%3D","updated":"2014-01-28 00:19:36.000000000","message":"@Mehdi Abaakouk\n\nActually, the first fix in my local environment is just use rstrip to fix the problem described in the bug, but after read the ref link, I thought the readability base64 string for id is not necessary, for example, keystone use a very long token when it is using pki token format but without a single newline (this is for readability issue not another base64 example). \n\nFor meter model, the meter_id actually should not visible to end user since they are not use it (AFAIK, please correct it if I\u0027m wrong), so redundant character for readability just increase storage burden (even that is not too much)\n\nAnyway, I\u0027m OK just remove the last newline since that is my original thought, but I will wait for other developer\u0027s opinion.\n\nThank you very much :)","commit_id":"999bd00f09f58e78b51b3cc74d43f885c1de7428"}],"ceilometer/tests/api/v2/test_list_meters_scenarios.py":[{"author":{"_account_id":7409,"name":"Eric Pendergrass","email":"epende@gmail.com","username":"epende"},"change_message_id":"7e7e24542311eee91f91067d31598756e17847d6","unresolved":false,"context_lines":[{"line_number":532,"context_line":"        for i in data:"},{"line_number":533,"context_line":"            expected \u003d base64.encodestring(\u0027%s+%s\u0027 % (i[\u0027resource_id\u0027],"},{"line_number":534,"context_line":"                                                      i[\u0027name\u0027]))"},{"line_number":535,"context_line":"            self.assertEqual(expected.replace(\u0027\\n\u0027, \u0027\u0027), i[\u0027meter_id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa32b979_bb1a807b","line":535,"updated":"2015-06-24 20:31:08.000000000","message":"Regarding the comment in v2.py, this should replace only the trailing \u0027\\n\u0027 if that\u0027s what is decided","commit_id":"999bd00f09f58e78b51b3cc74d43f885c1de7428"}]}