)]}'
{"ceilometer/tests/api/v2/test_app.py":[{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"80d941649b46da986e1448a1307590758e5e178a","unresolved":false,"context_lines":[{"line_number":77,"context_line":"class TestPecanApp(FunctionalTest):"},{"line_number":78,"context_line":"    database_connection \u003d tests_db.MongoDBFakeConnectionUrl()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def setUp(self):"},{"line_number":81,"context_line":"        super(TestPecanApp, self).setUp()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if not str(self.database_connection):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F9rc%3D","line":80,"updated":"2014-02-08 08:05:05.000000000","message":"I don\u0027t think we need this for further test of self.database_connection. \nFunctionalTest is a subclass of ceilometer.tests.db.TestBase which already does this in its own setUp().","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"ea783ea9020e5e4ae91db6daa39441a7811fc4a0","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def setUp(self):"},{"line_number":81,"context_line":"        super(TestPecanApp, self).setUp()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if not str(self.database_connection):"},{"line_number":84,"context_line":"            self.skipTest(\"No connection URL set\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_pecan_extension_guessing_unset(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BEUM%3D","line":83,"updated":"2014-01-30 14:26:57.000000000","message":"Why convert to a str to do a not check? what If self.database_connection is None? just a not on self.databse_connection seems enough?","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4e59344dab47fc68c048b93d3a38284448ebfff4","unresolved":false,"context_lines":[{"line_number":80,"context_line":"    def setUp(self):"},{"line_number":81,"context_line":"        super(TestPecanApp, self).setUp()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"        if not str(self.database_connection):"},{"line_number":84,"context_line":"            self.skipTest(\"No connection URL set\")"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"    def test_pecan_extension_guessing_unset(self):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9%2BsI%3D","line":83,"in_reply_to":"AAAAUH%2F%2BEUM%3D","updated":"2014-01-31 12:34:57.000000000","message":"Answered in ceilometer/tests/db.py","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"80d941649b46da986e1448a1307590758e5e178a","unresolved":false,"context_lines":[{"line_number":94,"context_line":"    # This doesn\u0027t really matter"},{"line_number":95,"context_line":"    database_connection \u003d tests_db.MongoDBFakeConnectionUrl()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"    def setUp(self):"},{"line_number":98,"context_line":"        super(TestApiMiddleware, self).setUp()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not str(self.database_connection):"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUX%2F%2F9rY%3D","line":97,"updated":"2014-02-08 08:05:05.000000000","message":"same comment as the above","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"ea783ea9020e5e4ae91db6daa39441a7811fc4a0","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def setUp(self):"},{"line_number":98,"context_line":"        super(TestApiMiddleware, self).setUp()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not str(self.database_connection):"},{"line_number":101,"context_line":"            self.skipTest(\"No connection URL set\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    no_lang_translated_error \u003d \u0027No lang translated error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BEUI%3D","line":100,"updated":"2014-01-30 14:26:57.000000000","message":"same here","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4e59344dab47fc68c048b93d3a38284448ebfff4","unresolved":false,"context_lines":[{"line_number":97,"context_line":"    def setUp(self):"},{"line_number":98,"context_line":"        super(TestApiMiddleware, self).setUp()"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"        if not str(self.database_connection):"},{"line_number":101,"context_line":"            self.skipTest(\"No connection URL set\")"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    no_lang_translated_error \u003d \u0027No lang translated error\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9%2Br8%3D","line":100,"in_reply_to":"AAAAUH%2F%2BEUI%3D","updated":"2014-01-31 12:34:57.000000000","message":"Answered in ceilometer/tests/db.py","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1ba8d6c50cb29bd2435dcd3d838abb0ff6365a9d","unresolved":false,"context_lines":[{"line_number":77,"context_line":"class TestPecanApp(FunctionalTest):"},{"line_number":78,"context_line":"    database_connection \u003d tests_db.MongoDBFakeConnectionUrl()"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def setUp(self):"},{"line_number":81,"context_line":"        super(TestPecanApp, self).setUp()"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    def test_pecan_extension_guessing_unset(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BnMI%3D","line":80,"updated":"2014-02-20 07:48:32.000000000","message":"I don\u0027t think this is needed ever.","commit_id":"207bd2421eaa32d3a3f1a9c7049d0683b0bceb01"},{"author":{"_account_id":4491,"name":"Lianhao Lu","email":"llh_misc@outlook.com","username":"lianhao-lu"},"change_message_id":"1ba8d6c50cb29bd2435dcd3d838abb0ff6365a9d","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    # This doesn\u0027t really matter"},{"line_number":92,"context_line":"    database_connection \u003d tests_db.MongoDBFakeConnectionUrl()"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def setUp(self):"},{"line_number":95,"context_line":"        super(TestApiMiddleware, self).setUp()"},{"line_number":96,"context_line":""},{"line_number":97,"context_line":"        if not str(self.database_connection):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAUX%2F%2BnLw%3D","line":94,"updated":"2014-02-20 07:48:32.000000000","message":"It\u0027s not needed. The base class will do the same thing.","commit_id":"207bd2421eaa32d3a3f1a9c7049d0683b0bceb01"}],"ceilometer/tests/db.py":[{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"ea783ea9020e5e4ae91db6daa39441a7811fc4a0","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not hasattr(self, \u0027database_connection\u0027) or \\"},{"line_number":38,"context_line":"                not self.database_connection or \\"},{"line_number":39,"context_line":"                not str(self.database_connection):"},{"line_number":40,"context_line":"                self.skipTest(\"No connection URL set\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F%2BETk%3D","line":39,"updated":"2014-01-30 14:26:57.000000000","message":"same here, i think a None check should suffice? dont see the point of converting to a string to do a not check.","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":7729,"name":"Ilya Tyaptin","email":"ityaptin@mirantis.com","username":"ityaptin"},"change_message_id":"4e59344dab47fc68c048b93d3a38284448ebfff4","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not hasattr(self, \u0027database_connection\u0027) or \\"},{"line_number":38,"context_line":"                not self.database_connection or \\"},{"line_number":39,"context_line":"                not str(self.database_connection):"},{"line_number":40,"context_line":"                self.skipTest(\"No connection URL set\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9%2BsU%3D","line":39,"in_reply_to":"AAAAUH%2F%2BETk%3D","updated":"2014-01-31 12:34:57.000000000","message":"Tests use str(database_connection) for create connection. String representation of database_connection based on attribute url. If database_connection was created, but database_connection.url is None or empty we have to skip test.","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"},{"author":{"_account_id":6924,"name":"Pradeep Kilambi","email":"pkilambi@redhat.com","username":"pkilambi"},"change_message_id":"d731e353ed0144d2bf3fa0e6a1a79dcba44d0ab8","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"        if not hasattr(self, \u0027database_connection\u0027) or \\"},{"line_number":38,"context_line":"                not self.database_connection or \\"},{"line_number":39,"context_line":"                not str(self.database_connection):"},{"line_number":40,"context_line":"                self.skipTest(\"No connection URL set\")"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        self.CONF \u003d self.useFixture(config.Config()).conf"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAUH%2F9%2BpU%3D","line":39,"in_reply_to":"AAAAUH%2F9%2BsU%3D","updated":"2014-01-31 12:50:17.000000000","message":"Thanks for clarifying.","commit_id":"3e998d16398b188af8f4dc8bfdd749acf3cb649a"}]}